Skip to contentSkip to conversation

RISC-V: Don't set CLONE_BACKWARDS

RFC In review Palmer Dabbelt 2 participants 3 messages Jan 9, 2018 RISC-V

lore
Share & tools
lore
#0 lore raw

RFC 1/1 RISC-V: Don't set CLONE_BACKWARDS

During the glibc upstreaming it was suggested that CLONE_BACKWARDS was a deprecated ABI decision. I think we just copied it from ARM, but I don't see any reason to favor one over the other.

While we haven't released yet so I think it's still legal to change our ABI, I'd actually kind of prefer to avoid changing our ABI this late in the game. I guess this is more of an RFC than a patch: is there a reason to avoid CLONE_BACKWARDS?

Note that I haven't tried any of this -- I'll give it some thourough testing and submit an actual patch if this is the way we want to go.

CC Adhemerval Zanella <[email protected]>
---
 arch/riscv/Kconfig | 1 -
 1 file changed, 1 deletion(-)
arch/riscv/Kconfig +0 -1
index 2c6adf12713a..02076f3a2883 100644
@@ -10,7 +10,6 @@ config RISCV
 	select OF_IRQ
 	select ARCH_HAS_ATOMIC64_DEC_IF_POSITIVE
 	select ARCH_WANT_FRAME_POINTERS
-	select CLONE_BACKWARDS
 	select COMMON_CLK
 	select GENERIC_CLOCKEVENTS
 	select GENERIC_CPU_DEVICES
Signature · 1 line
2.13.6
#1 lore raw
Quoted 11 lines · Palmer Dabbelt

During the glibc upstreaming it was suggested that CLONE_BACKWARDS was a deprecated ABI decision. I think we just copied it from ARM, but I don't see any reason to favor one over the other.

While we haven't released yet so I think it's still legal to change our ABI, I'd actually kind of prefer to avoid changing our ABI this late in the game. I guess this is more of an RFC than a patch: is there a reason to avoid CLONE_BACKWARDS?

Note that I haven't tried any of this -- I'll give it some thourough testing and submit an actual patch if this is the way we want to go.

I see absolutely no reason to change this. Linux currently has 30 architecture port, out of which 10 (including riscv, i386, arm and arm64) set CLONE_BACKWARDS.

There are no performance benefits of doing it one way or another, and changing it now will break all the riscv enablement that's been going on.

#2 lore raw
Quoted 13 lines · On Tue, 09 Jan 2018 00:11:45 PST (-0800), [email protected] wrote:
Quoted 11 lines · Palmer Dabbelt

During the glibc upstreaming it was suggested that CLONE_BACKWARDS was a deprecated ABI decision. I think we just copied it from ARM, but I don't see any reason to favor one over the other.

While we haven't released yet so I think it's still legal to change our ABI, I'd actually kind of prefer to avoid changing our ABI this late in the game. I guess this is more of an RFC than a patch: is there a reason to avoid CLONE_BACKWARDS?

Note that I haven't tried any of this -- I'll give it some thourough testing and submit an actual patch if this is the way we want to go.

Quoted 7 lines

I see absolutely no reason to change this. Linux currently has 30 architecture port, out of which 10 (including riscv, i386, arm and arm64) set CLONE_BACKWARDS.

There are no performance benefits of doing it one way or another, and changing it now will break all the riscv enablement that's been going on.

OK, works for me! Unless anyone has a strong argument against CLONE_BACKWARDS we're just going to leave it alone.