drm/i915: Fix using BIT_ULL() vs. BIT() for power domain masks
Subsystems (2)
PATCH 1/1 drm/i915: Fix using BIT_ULL() vs. BIT() for power domain masks
The power domain masks are 64 bit wide, so we need BIT_ULL() when setting bits in them, these ones were missed during converting from 32 to 64 bit masks. All 3 enums are <32 atm, so this didn't cause a real problem.
--- drivers/gpu/drm/i915/intel_display.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/intel_display.c +3 -3
@@ -5661,8 +5661,8 @@ static u64 get_crtc_power_domains(struct drm_crtc *crtc,if (!crtc_state->base.active)return 0 ; - mask =BIT (POWER_DOMAIN_PIPE (pipe)); - mask |=BIT (POWER_DOMAIN_TRANSCODER (transcoder)); + mask =BIT_ULL (POWER_DOMAIN_PIPE (pipe)); + mask |=BIT_ULL (POWER_DOMAIN_TRANSCODER (transcoder));if (crtc_state->pch_pfit.enabled || crtc_state->pch_pfit.force_thru) mask |=BIT_ULL (POWER_DOMAIN_PIPE_PANEL_FITTER (pipe));
@@ -5674,7 +5674,7 @@ static u64 get_crtc_power_domains(struct drm_crtc *crtc, }if (HAS_DDI (dev_priv) && crtc_state->has_audio) - mask |=BIT (POWER_DOMAIN_AUDIO ); + mask |=BIT_ULL (POWER_DOMAIN_AUDIO );if (crtc_state->shared_dpll) mask |=BIT_ULL (POWER_DOMAIN_PLLS );
Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: Fix using BIT_ULL() vs. BIT() for power domain masks
== Series Details ==
== Series Details ==
Series: drm/i915: Fix using BIT_ULL() vs. BIT() for power domain masks
URL : https://patchwork.freedesktop.org/series/36188/
State : success
== Summary ==
Series 36188v1 drm/i915: Fix using BIT_ULL() vs. BIT() for power domain masks
https://patchwork.freedesktop.org/api/1.0/series/36188/revisions/1/mbox/
Test gem_ringfill:
Subgroup basic-default:
skip -> PASS (fi-bsw-n3050)
Test kms_chamelium:
Subgroup hdmi-hpd-fast:
fail -> SKIP (fi-kbl-7500u)fi-bdw-5557u total:288 pass:267 dwarn:0 dfail:0 fail:0 skip:21 time:428s fi-bdw-gvtdvm total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:428s fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:370s fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:487s fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:280s fi-bxt-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:483s fi-bxt-j4205 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:495s fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:467s fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:459s fi-elk-e7500 total:224 pass:168 dwarn:10 dfail:0 fail:0 skip:45 fi-gdg-551 total:288 pass:179 dwarn:0 dfail:0 fail:1 skip:108 time:278s fi-glk-1 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:512s fi-hsw-4770 total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:392s fi-hsw-4770r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:402s fi-ilk-650 total:288 pass:228 dwarn:0 dfail:0 fail:0 skip:60 time:410s fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:463s fi-ivb-3770 total:288 pass:255 dwarn:0 dfail:0 fail:0 skip:33 time:412s fi-kbl-7500u total:288 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:462s fi-kbl-7560u total:288 pass:269 dwarn:0 dfail:0 fail:0 skip:19 time:495s fi-kbl-7567u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:459s fi-kbl-r total:288 pass:260 dwarn:1 dfail:0 fail:0 skip:27 time:506s fi-pnv-d510 total:288 pass:222 dwarn:1 dfail:0 fail:0 skip:65 time:576s fi-skl-6260u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:436s fi-skl-6600u total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:508s fi-skl-6700hq total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:525s fi-skl-6700k2 total:288 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:496s fi-skl-6770hq total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:478s fi-skl-gvtdvm total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:430s fi-snb-2520m total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:532s fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:395s Blacklisted hosts: fi-cfl-s2 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:563s fi-cnl-y2 total:288 pass:258 dwarn:3 dfail:0 fail:0 skip:27 time:534s fi-glk-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:474s
9213555074f6e599ebcd863a90dd675d38bc28d7 drm-tip: 2018y-01m-09d-12h-52m-52s UTC integration manifest bff337643344 drm/i915: Fix using BIT_ULL() vs. BIT() for power domain masks
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7630/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: ✓ Fi.CI.BAT: success for drm/i915: Fix using BIT_ULL() vs. BIT() for power domain masks
Quoted 5 lines · Patchwork
== Series Details ==
Series: drm/i915: Fix using
BIT_ULL()vs.BIT()for power domain masks
URL : https://patchwork.freedesktop.org/series/36188/
State : success
Thanks for the reviews, pushed to -dinq.
Quoted 48 lines
== Summary ==
Series 36188v1 drm/i915: Fix using
BIT_ULL()vs.BIT()for power domain masks
https://patchwork.freedesktop.org/api/1.0/series/36188/revisions/1/mbox/Test
gem_ringfill:Subgroup basic-default: skip -> PASS (fi-bsw-n3050) Test kms_chamelium: Subgroup hdmi-hpd-fast: fail -> SKIP (fi-kbl-7500u)fi-bdw-5557u total:288 pass:267 dwarn:0 dfail:0 fail:0 skip:21 time:428s fi-bdw-gvtdvm total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:428s fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:370s fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:487s fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:280s fi-bxt-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:483s fi-bxt-j4205 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:495s fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:467s fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:459s fi-elk-e7500 total:224 pass:168 dwarn:10 dfail:0 fail:0 skip:45 fi-gdg-551 total:288 pass:179 dwarn:0 dfail:0 fail:1 skip:108 time:278s fi-glk-1 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:512s fi-hsw-4770 total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:392s fi-hsw-4770r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:402s fi-ilk-650 total:288 pass:228 dwarn:0 dfail:0 fail:0 skip:60 time:410s fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:463s fi-ivb-3770 total:288 pass:255 dwarn:0 dfail:0 fail:0 skip:33 time:412s fi-kbl-7500u total:288 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:462s fi-kbl-7560u total:288 pass:269 dwarn:0 dfail:0 fail:0 skip:19 time:495s fi-kbl-7567u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:459s fi-kbl-r total:288 pass:260 dwarn:1 dfail:0 fail:0 skip:27 time:506s fi-pnv-d510 total:288 pass:222 dwarn:1 dfail:0 fail:0 skip:65 time:576s fi-skl-6260u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:436s fi-skl-6600u total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:508s fi-skl-6700hq total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:525s fi-skl-6700k2 total:288 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:496s fi-skl-6770hq total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:478s fi-skl-gvtdvm total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:430s fi-snb-2520m total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:532s fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:395s Blacklisted hosts: fi-cfl-s2 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:563s fi-cnl-y2 total:288 pass:258 dwarn:3 dfail:0 fail:0 skip:27 time:534s fi-glk-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:474s
Quoted 6 lines
9213555074f6e599ebcd863a90dd675d38bc28d7drm-tip: 2018y-01m-09d-12h-52m-52s UTC integration manifestbff337643344drm/i915: Fix usingBIT_ULL()vs.BIT()for power domain masks== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7630/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Imre Deak (2018-01-09 12:20:40)
Quoted 9 lines
The power domain masks are 64 bit wide, so we need
BIT_ULL()when setting bits in them, these ones were missed during converting from 32 to 64 bit masks. All 3 enums are <32 atm, so this didn't cause a real problem.Fixes d8fc70b7367b ("drm/i915: Make power domain masks 64 bit long")Cc Joonas Lahtinen <[email protected]>Reported-by Fengguang Wu <[email protected]>Signed-off-by Imre Deak <[email protected]>
And they are the only 3.
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 9 lines · Imre Deak
The power domain masks are 64 bit wide, so we need
BIT_ULL()when setting bits in them, these ones were missed during converting from 32 to 64 bit masks. All 3 enums are <32 atm, so this didn't cause a real problem.Fixes d8fc70b7367b ("drm/i915: Make power domain masks 64 bit long")Cc Joonas Lahtinen <[email protected]>Reported-by Fengguang Wu <[email protected]>Signed-off-by Imre Deak <[email protected]>
Those are some strange misses, surrounded by code that was touched.
Regards, Joonas
Signature · 7 lines
Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.IGT: failure for drm/i915: Fix using BIT_ULL() vs. BIT() for power domain masks
In reply to Imre Deak== Series Details ==
== Series Details ==
Series: drm/i915: Fix using BIT_ULL() vs. BIT() for power domain masks
URL : https://patchwork.freedesktop.org/series/36188/
State : failure
== Summary ==
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-primscrn-pri-indfb-draw-blt:
fail -> PASS (shard-snb) fdo#101623 +2
Test kms_universal_plane:
Subgroup universal-plane-pipe-c-functional:
pass -> INCOMPLETE (shard-hsw)
Test perf:
Subgroup polling:
fail -> PASS (shard-hsw) fdo#102252
Test kms_busy:
Subgroup basic-modeset-b:
pass -> SKIP (shard-hsw)
Test drv_suspend:
Subgroup fence-restore-tiled2untiled:
skip -> PASS (shard-snb) fdo#104218 +1
Test gem_exec_suspend:
Subgroup basic-s3-devices:
pass -> INCOMPLETE (shard-hsw) fdo#103990fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#104218 https://bugs.freedesktop.org/show_bug.cgi?id=104218
fdo#103990 https://bugs.freedesktop.org/show_bug.cgi?id=103990
shard-hsw total:2631 pass:1493 dwarn:1 dfail:0 fail:10 skip:1125 time:8525s shard-snb total:2713 pass:1311 dwarn:1 dfail:0 fail:10 skip:1391 time:7912s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7630/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx