xfs: don't leak perag metadata reservation on finobt block free

PATCH In review Brian Foster 2 participants 6 messages Jan 9, 2018 – Jan 10, 2018 XFS filesystem

Share & tools

Brian Foster

author

2018-01-09 18:35 UTC #0 lore raw

PATCH 1/1 xfs: don't leak perag metadata reservation on finobt block free

We started using the perag metadata reservation for free inode btree blocks in commit 76d771b4cbe33 ("xfs: use per-AG reservations for the finobt"). While this change consumes metadata res. for finobt block allocations, we still don't replenish the res. pool when finobt blocks are freed. This leads to leaking reservation as finobt blocks are allocated and freed over time, which in turn can lead to overruse of blocks that should be protected by the reservation.

Update the finobt free block path to specify the metadata reservation type as done in the allocation path.

Signed-off-by Brian Foster <[email protected]>

---
 fs/xfs/libxfs/xfs_ialloc_btree.c | 25 +++++++++++++++++++++----
 1 file changed, 21 insertions(+), 4 deletions(-)

fs/xfs/libxfs/xfs_ialloc_btree.c +21 -4

index 47f44d624cb1..18fe6b3a7802 100644
@@ -146,16 +146,33 @@ xfs_finobt_alloc_block(
 }
 
 STATIC int
-xfs_inobt_free_block(
+__xfs_inobt_free_block(
 	struct xfs_btree_cur	*cur,
-	struct xfs_buf		*bp)
+	struct xfs_buf		*bp,
+	enum xfs_ag_resv_type	resv)
 {
 	struct xfs_owner_info	oinfo;
 
 	xfs_rmap_ag_owner(&oinfo, XFS_RMAP_OWN_INOBT);
 	return xfs_free_extent(cur->bc_tp,
 			XFS_DADDR_TO_FSB(cur->bc_mp, XFS_BUF_ADDR(bp)), 1,
-			&oinfo, XFS_AG_RESV_NONE);
+			&oinfo, resv);
+}
+
+STATIC int
+xfs_inobt_free_block(
+	struct xfs_btree_cur	*cur,
+	struct xfs_buf		*bp)
+{
+	return __xfs_inobt_free_block(cur, bp, XFS_AG_RESV_NONE);
+}
+
+STATIC int
+xfs_finobt_free_block(
+	struct xfs_btree_cur	*cur,
+	struct xfs_buf		*bp)
+{
+	return __xfs_inobt_free_block(cur, bp, XFS_AG_RESV_METADATA);
 }
 
 STATIC int

@@ -380,7 +397,7 @@ static const struct xfs_btree_ops xfs_finobt_ops = {
 	.dup_cursor		= xfs_inobt_dup_cursor,
 	.set_root		= xfs_finobt_set_root,
 	.alloc_block		= xfs_finobt_alloc_block,
-	.free_block		= xfs_inobt_free_block,
+	.free_block		= xfs_finobt_free_block,
 	.get_minrecs		= xfs_inobt_get_minrecs,
 	.get_maxrecs		= xfs_inobt_get_maxrecs,
 	.init_key_from_rec	= xfs_inobt_init_key_from_rec,

Signature · 1 line

2.13.6

Darrick J. Wong

2018-01-09 20:16 UTC #1 lore raw

Quoted 44 lines · Brian Foster

We started using the perag metadata reservation for free inode btree blocks in commit 76d771b4cbe33 ("xfs: use per-AG reservations for the finobt"). While this change consumes metadata res. for finobt block allocations, we still don't replenish the res. pool when finobt blocks are freed. This leads to leaking reservation as finobt blocks are allocated and freed over time, which in turn can lead to overruse of blocks that should be protected by the reservation.
Update the finobt free block path to specify the metadata reservation type as done in the allocation path.
Signed-off-by Brian Foster <[email protected]>
---
 fs/xfs/libxfs/xfs_ialloc_btree.c | 25 +++++++++++++++++++++----
 1 file changed, 21 insertions(+), 4 deletions(-)
fs/xfs/libxfs/xfs_ialloc_btree.c +10 -3
index 47f44d624cb1..18fe6b3a7802 100644
@@ -146,16 +146,33 @@ xfs_finobt_alloc_block(
 }
 
 STATIC int
-xfs_inobt_free_block(
+__xfs_inobt_free_block(
 	struct xfs_btree_cur	*cur,
-	struct xfs_buf		*bp)
+	struct xfs_buf		*bp,
+	enum xfs_ag_resv_type	resv)
 {
 	struct xfs_owner_info	oinfo;
 
 	xfs_rmap_ag_owner(&oinfo, XFS_RMAP_OWN_INOBT);
 	return xfs_free_extent(cur->bc_tp,
 			XFS_DADDR_TO_FSB(cur->bc_mp, XFS_BUF_ADDR(bp)), 1,
-			&oinfo, XFS_AG_RESV_NONE);
+			&oinfo, resv);
+}
+
+STATIC int
+xfs_inobt_free_block(
+	struct xfs_btree_cur	*cur,
+	struct xfs_buf		*bp)

fs/xfs/libxfs/xfs_ialloc_btree.c xfs_finobt_alloc_block( · line 175

Quoted 10 lines

fs/xfs/libxfs/xfs_ialloc_btree.c +10 -0

+{
+	return __xfs_inobt_free_block(cur, bp, XFS_AG_RESV_NONE);
+}
+
+STATIC int
+xfs_finobt_free_block(
+	struct xfs_btree_cur	*cur,
+	struct xfs_buf		*bp)
+{
+	return __xfs_inobt_free_block(cur, bp, XFS_AG_RESV_METADATA);

cur->bc_mp->m_inotbt_nores ? XFS_AG_RESV_NONE : XFS_AG_RESV_METADATA

Since we don't use the finobt reservation if there wasn't room.

--D

Quoted 19 lines

fs/xfs/libxfs/xfs_ialloc_btree.c +1 -1

 }
 
 STATIC int

@@ -380,7 +397,7 @@ static const struct xfs_btree_ops xfs_finobt_ops = {
 	.dup_cursor		= xfs_inobt_dup_cursor,
 	.set_root		= xfs_finobt_set_root,
 	.alloc_block		= xfs_finobt_alloc_block,
-	.free_block		= xfs_inobt_free_block,
+	.free_block		= xfs_finobt_free_block,
 	.get_minrecs		= xfs_inobt_get_minrecs,
 	.get_maxrecs		= xfs_inobt_get_maxrecs,
 	.init_key_from_rec	= xfs_inobt_init_key_from_rec,

Signature · 6 lines

2.13.6

--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Brian Foster

author

2018-01-09 21:42 UTC #2 lore raw

Quoted 58 lines · Darrick J. Wong

Quoted 44 lines · Brian Foster
We started using the perag metadata reservation for free inode btree blocks in commit 76d771b4cbe33 ("xfs: use per-AG reservations for the finobt"). While this change consumes metadata res. for finobt block allocations, we still don't replenish the res. pool when finobt blocks are freed. This leads to leaking reservation as finobt blocks are allocated and freed over time, which in turn can lead to overruse of blocks that should be protected by the reservation.
Update the finobt free block path to specify the metadata reservation type as done in the allocation path.
Signed-off-by Brian Foster <[email protected]>
---
 fs/xfs/libxfs/xfs_ialloc_btree.c | 25 +++++++++++++++++++++----
 1 file changed, 21 insertions(+), 4 deletions(-)
fs/xfs/libxfs/xfs_ialloc_btree.c +10 -3
index 47f44d624cb1..18fe6b3a7802 100644
@@ -146,16 +146,33 @@ xfs_finobt_alloc_block(
 }
 
 STATIC int
-xfs_inobt_free_block(
+__xfs_inobt_free_block(
 	struct xfs_btree_cur	*cur,
-	struct xfs_buf		*bp)
+	struct xfs_buf		*bp,
+	enum xfs_ag_resv_type	resv)
 {
 	struct xfs_owner_info	oinfo;
 
 	xfs_rmap_ag_owner(&oinfo, XFS_RMAP_OWN_INOBT);
 	return xfs_free_extent(cur->bc_tp,
 			XFS_DADDR_TO_FSB(cur->bc_mp, XFS_BUF_ADDR(bp)), 1,
-			&oinfo, XFS_AG_RESV_NONE);
+			&oinfo, resv);
+}
+
+STATIC int
+xfs_inobt_free_block(
+	struct xfs_btree_cur	*cur,
+	struct xfs_buf		*bp)
fs/xfs/libxfs/xfs_ialloc_btree.c xfs_finobt_alloc_block( · line 175
Quoted 10 lines
fs/xfs/libxfs/xfs_ialloc_btree.c +10 -0
+{
+	return __xfs_inobt_free_block(cur, bp, XFS_AG_RESV_NONE);
+}
+
+STATIC int
+xfs_finobt_free_block(
+	struct xfs_btree_cur	*cur,
+	struct xfs_buf		*bp)
+{
+	return __xfs_inobt_free_block(cur, bp, XFS_AG_RESV_METADATA);
cur->bc_mp->m_inotbt_nores ? XFS_AG_RESV_NONE : XFS_AG_RESV_METADATA

Quoted 2 lines

Since we don't use the finobt reservation if there wasn't room.

Yep.. will send a v2. Thanks!

Brian

Quoted 21 lines

--D

Quoted 19 lines

fs/xfs/libxfs/xfs_ialloc_btree.c +1 -1

 }
 
 STATIC int

@@ -380,7 +397,7 @@ static const struct xfs_btree_ops xfs_finobt_ops = {
 	.dup_cursor		= xfs_inobt_dup_cursor,
 	.set_root		= xfs_finobt_set_root,
 	.alloc_block		= xfs_finobt_alloc_block,
-	.free_block		= xfs_inobt_free_block,
+	.free_block		= xfs_finobt_free_block,
 	.get_minrecs		= xfs_inobt_get_minrecs,
 	.get_maxrecs		= xfs_inobt_get_maxrecs,
 	.init_key_from_rec	= xfs_inobt_init_key_from_rec,

Signature · 6 lines

2.13.6

--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Brian Foster

author

2018-01-10 12:06 UTC #3 lore raw

Quoted 59 lines · Brian Foster

Quoted 58 lines · Darrick J. Wong
Quoted 44 lines · Brian Foster
We started using the perag metadata reservation for free inode btree blocks in commit 76d771b4cbe33 ("xfs: use per-AG reservations for the finobt"). While this change consumes metadata res. for finobt block allocations, we still don't replenish the res. pool when finobt blocks are freed. This leads to leaking reservation as finobt blocks are allocated and freed over time, which in turn can lead to overruse of blocks that should be protected by the reservation.
Update the finobt free block path to specify the metadata reservation type as done in the allocation path.
Signed-off-by Brian Foster <[email protected]>
---
 fs/xfs/libxfs/xfs_ialloc_btree.c | 25 +++++++++++++++++++++----
 1 file changed, 21 insertions(+), 4 deletions(-)
fs/xfs/libxfs/xfs_ialloc_btree.c +10 -3
index 47f44d624cb1..18fe6b3a7802 100644
@@ -146,16 +146,33 @@ xfs_finobt_alloc_block(
 }
 
 STATIC int
-xfs_inobt_free_block(
+__xfs_inobt_free_block(
 	struct xfs_btree_cur	*cur,
-	struct xfs_buf		*bp)
+	struct xfs_buf		*bp,
+	enum xfs_ag_resv_type	resv)
 {
 	struct xfs_owner_info	oinfo;
 
 	xfs_rmap_ag_owner(&oinfo, XFS_RMAP_OWN_INOBT);
 	return xfs_free_extent(cur->bc_tp,
 			XFS_DADDR_TO_FSB(cur->bc_mp, XFS_BUF_ADDR(bp)), 1,
-			&oinfo, XFS_AG_RESV_NONE);
+			&oinfo, resv);
+}
+
+STATIC int
+xfs_inobt_free_block(
+	struct xfs_btree_cur	*cur,
+	struct xfs_buf		*bp)
fs/xfs/libxfs/xfs_ialloc_btree.c xfs_finobt_alloc_block( · line 175
Quoted 10 lines
fs/xfs/libxfs/xfs_ialloc_btree.c +10 -0
+{
+	return __xfs_inobt_free_block(cur, bp, XFS_AG_RESV_NONE);
+}
+
+STATIC int
+xfs_finobt_free_block(
+	struct xfs_btree_cur	*cur,
+	struct xfs_buf		*bp)
+{
+	return __xfs_inobt_free_block(cur, bp, XFS_AG_RESV_METADATA);
cur->bc_mp->m_inotbt_nores ? XFS_AG_RESV_NONE : XFS_AG_RESV_METADATA

Quoted 5 lines

Quoted 2 lines
Since we don't use the finobt reservation if there wasn't room.
Yep.. will send a v2. Thanks!

Wait, I don't think that is right.. ->m_inotbt_nores is set at perag init time based on whether the reservation is fulfilled or not. If not, the xfs_ag_resv fields are initialized to zero to indicate there is no reservation. From there, the xfs_ag_resv_[alloc|free]_extent() functions effectively no-op the accounting for such block allocations. Since there is no reservation in this case, xfs_inactive_ifree() reverts to the older behavior of reserving a block in the transaction (which starts to smell like this is a bit of a hack to avoid tx res failures in this particular context, since the inode allocation side of things still always reserves blocks for finobt operations despite the reservation :/).

So anyways, shouldn't ->alloc_block()/->free_block() be consistent in unconditionally tagging the allocation as RESV_METADATA? Am I missing something?

Brian

Quoted 27 lines

Brian
Quoted 17 lines
--D
Quoted 15 lines
fs/xfs/libxfs/xfs_ialloc_btree.c +1 -1
 }
 
 STATIC int
@@ -380,7 +397,7 @@ static const struct xfs_btree_ops xfs_finobt_ops = {
 	.dup_cursor		= xfs_inobt_dup_cursor,
 	.set_root		= xfs_finobt_set_root,
 	.alloc_block		= xfs_finobt_alloc_block,
-	.free_block		= xfs_inobt_free_block,
+	.free_block		= xfs_finobt_free_block,
 	.get_minrecs		= xfs_inobt_get_minrecs,
 	.get_maxrecs		= xfs_inobt_get_maxrecs,
 	.init_key_from_rec	= xfs_inobt_init_key_from_rec,
Signature · 1 line
2.13.6
Quoted 4 lines
Quoted 4 lines
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Darrick J. Wong

2018-01-10 19:27 UTC #4 lore raw

Quoted 63 lines · Brian Foster

Quoted 62 lines · Brian Foster
Quoted 60 lines · Darrick J. Wong
Quoted 44 lines · Brian Foster
We started using the perag metadata reservation for free inode btree blocks in commit 76d771b4cbe33 ("xfs: use per-AG reservations for the finobt"). While this change consumes metadata res. for finobt block allocations, we still don't replenish the res. pool when finobt blocks are freed. This leads to leaking reservation as finobt blocks are allocated and freed over time, which in turn can lead to overruse of blocks that should be protected by the reservation.
Update the finobt free block path to specify the metadata reservation type as done in the allocation path.
Signed-off-by Brian Foster <[email protected]>
---
 fs/xfs/libxfs/xfs_ialloc_btree.c | 25 +++++++++++++++++++++----
 1 file changed, 21 insertions(+), 4 deletions(-)
fs/xfs/libxfs/xfs_ialloc_btree.c +10 -3
index 47f44d624cb1..18fe6b3a7802 100644
@@ -146,16 +146,33 @@ xfs_finobt_alloc_block(
 }
 
 STATIC int
-xfs_inobt_free_block(
+__xfs_inobt_free_block(
 	struct xfs_btree_cur	*cur,
-	struct xfs_buf		*bp)
+	struct xfs_buf		*bp,
+	enum xfs_ag_resv_type	resv)
 {
 	struct xfs_owner_info	oinfo;
 
 	xfs_rmap_ag_owner(&oinfo, XFS_RMAP_OWN_INOBT);
 	return xfs_free_extent(cur->bc_tp,
 			XFS_DADDR_TO_FSB(cur->bc_mp, XFS_BUF_ADDR(bp)), 1,
-			&oinfo, XFS_AG_RESV_NONE);
+			&oinfo, resv);
+}
+
+STATIC int
+xfs_inobt_free_block(
+	struct xfs_btree_cur	*cur,
+	struct xfs_buf		*bp)
fs/xfs/libxfs/xfs_ialloc_btree.c xfs_finobt_alloc_block( · line 175
Quoted 10 lines
fs/xfs/libxfs/xfs_ialloc_btree.c +10 -0
+{
+	return __xfs_inobt_free_block(cur, bp, XFS_AG_RESV_NONE);
+}
+
+STATIC int
+xfs_finobt_free_block(
+	struct xfs_btree_cur	*cur,
+	struct xfs_buf		*bp)
+{
+	return __xfs_inobt_free_block(cur, bp, XFS_AG_RESV_METADATA);
cur->bc_mp->m_inotbt_nores ? XFS_AG_RESV_NONE : XFS_AG_RESV_METADATA
Since we don't use the finobt reservation if there wasn't room.

Quoted 7 lines

Quoted 2 lines
Yep.. will send a v2. Thanks!
Wait, I don't think that is right.. ->m_inotbt_nores is set at perag init time based on whether the reservation is fulfilled or not. If not, the xfs_ag_resv fields are initialized to zero to indicate there is no reservation.

ARGH... finobt allocations always pass RESV_METADATA, even if !m_inotbt_nores, which means that we always draw from that perag reservation, even if we didn't actually make one for the finobt, but someone else did!

This can happen on a reflink+finobt filesystem where there's enough space to grant the refcountbt's reservation request but not enough to grant the finobt's request (i.e. the !m_inotbt_nores case). So the alloc case is broken too.

Quoted 8 lines

From there, the xfs_ag_resv_[alloc|free]_extent() functions effectively no-op the accounting for such block allocations. Since there is no reservation in this case, xfs_inactive_ifree() reverts to the older behavior of reserving a block in the transaction (which starts to smell like this is a bit of a hack to avoid tx res failures in this particular context, since the inode allocation side of things still always reserves blocks for finobt operations despite the reservation :/).

Yeah. Smelly. Sorry about this whole mess. :/

Quoted 37 lines

So anyways, shouldn't ->alloc_block()/->free_block() be consistent in unconditionally tagging the allocation as RESV_METADATA? Am I missing something?
Brian
Quoted 19 lines
Brian
Quoted 17 lines
--D
Quoted 15 lines
fs/xfs/libxfs/xfs_ialloc_btree.c +1 -1
 }
 
 STATIC int
@@ -380,7 +397,7 @@ static const struct xfs_btree_ops xfs_finobt_ops = {
 	.dup_cursor		= xfs_inobt_dup_cursor,
 	.set_root		= xfs_finobt_set_root,
 	.alloc_block		= xfs_finobt_alloc_block,
-	.free_block		= xfs_inobt_free_block,
+	.free_block		= xfs_finobt_free_block,
 	.get_minrecs		= xfs_inobt_get_minrecs,
 	.get_maxrecs		= xfs_inobt_get_maxrecs,
 	.init_key_from_rec	= xfs_inobt_init_key_from_rec,
Signature · 1 line
2.13.6
Quoted 8 lines
Quoted 4 lines
Quoted 4 lines
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Brian Foster

author

2018-01-10 20:43 UTC #5 lore raw

Quoted 77 lines · Darrick J. Wong

Quoted 63 lines · Brian Foster
Quoted 62 lines · Brian Foster
Quoted 60 lines · Darrick J. Wong
Quoted 44 lines · Brian Foster
We started using the perag metadata reservation for free inode btree blocks in commit 76d771b4cbe33 ("xfs: use per-AG reservations for the finobt"). While this change consumes metadata res. for finobt block allocations, we still don't replenish the res. pool when finobt blocks are freed. This leads to leaking reservation as finobt blocks are allocated and freed over time, which in turn can lead to overruse of blocks that should be protected by the reservation.
Update the finobt free block path to specify the metadata reservation type as done in the allocation path.
Signed-off-by Brian Foster <[email protected]>
---
 fs/xfs/libxfs/xfs_ialloc_btree.c | 25 +++++++++++++++++++++----
 1 file changed, 21 insertions(+), 4 deletions(-)
fs/xfs/libxfs/xfs_ialloc_btree.c +10 -3
index 47f44d624cb1..18fe6b3a7802 100644
@@ -146,16 +146,33 @@ xfs_finobt_alloc_block(
 }
 
 STATIC int
-xfs_inobt_free_block(
+__xfs_inobt_free_block(
 	struct xfs_btree_cur	*cur,
-	struct xfs_buf		*bp)
+	struct xfs_buf		*bp,
+	enum xfs_ag_resv_type	resv)
 {
 	struct xfs_owner_info	oinfo;
 
 	xfs_rmap_ag_owner(&oinfo, XFS_RMAP_OWN_INOBT);
 	return xfs_free_extent(cur->bc_tp,
 			XFS_DADDR_TO_FSB(cur->bc_mp, XFS_BUF_ADDR(bp)), 1,
-			&oinfo, XFS_AG_RESV_NONE);
+			&oinfo, resv);
+}
+
+STATIC int
+xfs_inobt_free_block(
+	struct xfs_btree_cur	*cur,
+	struct xfs_buf		*bp)
fs/xfs/libxfs/xfs_ialloc_btree.c xfs_finobt_alloc_block( · line 175
Quoted 10 lines
fs/xfs/libxfs/xfs_ialloc_btree.c +10 -0
+{
+	return __xfs_inobt_free_block(cur, bp, XFS_AG_RESV_NONE);
+}
+
+STATIC int
+xfs_finobt_free_block(
+	struct xfs_btree_cur	*cur,
+	struct xfs_buf		*bp)
+{
+	return __xfs_inobt_free_block(cur, bp, XFS_AG_RESV_METADATA);
cur->bc_mp->m_inotbt_nores ? XFS_AG_RESV_NONE : XFS_AG_RESV_METADATA
Since we don't use the finobt reservation if there wasn't room.
Quoted 7 lines
Quoted 2 lines
Yep.. will send a v2. Thanks!
Wait, I don't think that is right.. ->m_inotbt_nores is set at perag init time based on whether the reservation is fulfilled or not. If not, the xfs_ag_resv fields are initialized to zero to indicate there is no reservation.
ARGH... finobt allocations always pass RESV_METADATA, even if !m_inotbt_nores, which means that we always draw from that perag reservation, even if we didn't actually make one for the finobt, but someone else did!

Quoted 5 lines

This can happen on a reflink+finobt filesystem where there's enough space to grant the refcountbt's reservation request but not enough to grant the finobt's request (i.e. the !m_inotbt_nores case). So the alloc case is broken too.

Got it. So rather than both using RESV_METADATA, both of those callers need to consider ->m_inotbt_nores and pass NONE/METADATA appropriately, essentially because the metadata pool is shared between the finobt and refcountbt. I'll give that a shot and post a patch after some testing.

Brian

Quoted 48 lines

Quoted 8 lines
From there, the xfs_ag_resv_[alloc|free]_extent() functions effectively no-op the accounting for such block allocations. Since there is no reservation in this case, xfs_inactive_ifree() reverts to the older behavior of reserving a block in the transaction (which starts to smell like this is a bit of a hack to avoid tx res failures in this particular context, since the inode allocation side of things still always reserves blocks for finobt operations despite the reservation :/).
Yeah. Smelly. Sorry about this whole mess. :/
Quoted 37 lines
So anyways, shouldn't ->alloc_block()/->free_block() be consistent in unconditionally tagging the allocation as RESV_METADATA? Am I missing something?
Brian
Quoted 19 lines
Brian
Quoted 17 lines
--D
Quoted 15 lines
fs/xfs/libxfs/xfs_ialloc_btree.c +1 -1
 }
 
 STATIC int
@@ -380,7 +397,7 @@ static const struct xfs_btree_ops xfs_finobt_ops = {
 	.dup_cursor		= xfs_inobt_dup_cursor,
 	.set_root		= xfs_finobt_set_root,
 	.alloc_block		= xfs_finobt_alloc_block,
-	.free_block		= xfs_inobt_free_block,
+	.free_block		= xfs_finobt_free_block,
 	.get_minrecs		= xfs_inobt_get_minrecs,
 	.get_maxrecs		= xfs_inobt_get_maxrecs,
 	.init_key_from_rec	= xfs_inobt_init_key_from_rec,
Signature · 1 line
2.13.6
Quoted 8 lines
Quoted 4 lines
Quoted 4 lines
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html