Skip to contentSkip to conversation

syscalls/request_key04: new test for request_key() permission check bug

PATCH In review Eric Biggers 2 participants 2 messages Jan 9, 2018 – Jan 10, 2018 Keys/keyrings

lore
Share & tools
lore
#0 lore raw

PATCH v2 2/2 syscalls/request_key04: new test for request_key() permission check bug

From: Eric Biggers <[email protected]>

Add a test for a bug that allowed the request_key() system call to be used to add a key to a keyring using only Search permission. This bug was assigned CVE-2017-17807.

---

No changes since v1, just added a patch preceding this one.

 include/lapi/keyctl.h                              |  4 +
 runtest/cve                                        |  1 +
 runtest/syscalls                                   |  1 +
 .../kernel/syscalls/request_key/request_key04.c    | 87 ++++++++++++++++++++++
 4 files changed, 93 insertions(+)
 create mode 100644 testcases/kernel/syscalls/request_key/request_key04.c
include/lapi/keyctl.h +4 -0
index 5f6ddaae3..8ad8db64f 100644
@@ -99,6 +99,10 @@ static inline key_serial_t keyctl_join_session_keyring(const char *name) {
 # define KEY_REQKEY_DEFL_THREAD_KEYRING 1
 #endif
 
+#ifndef KEY_REQKEY_DEFL_SESSION_KEYRING
+# define KEY_REQKEY_DEFL_SESSION_KEYRING 3
+#endif
+
 #ifndef KEY_REQKEY_DEFL_DEFAULT
 # define KEY_REQKEY_DEFL_DEFAULT	0
 #endif
runtest/cve +1 -0
index 5d124083e..b69f40c65 100644
@@ -25,5 +25,6 @@ cve-2017-15274 add_key02
 cve-2017-15299 request_key03 -b cve-2017-15299
 cve-2017-15537 ptrace07
 cve-2017-15951 request_key03 -b cve-2017-15951
+cve-2017-17807 request_key04
 cve-2017-1000364 stack_clash
 cve-2017-5754 meltdown
runtest/syscalls +1 -0
index 97fc64300..94efd2305 100644
@@ -935,6 +935,7 @@ request_key01 request_key01
 request_key02 request_key02
 request_key03 request_key03
 cve-2017-6951 cve-2017-6951
+request_key04 request_key04
 
 rmdir01 rmdir01
 rmdir02 rmdir02
testcases/kernel/syscalls/request_key/request_key04.c new file +87 -0

87 lines not on this page · raw message

Signature · 1 line
2.16.0.rc1.238.g530d649a79-goog