Skip to contentSkip to conversation

support/config-fragments: linaro-arm: remove default option

PATCH New Romain Naour 2 participants 5 messages Jan 9, 2018 – Jan 12, 2018

lore
Share & tools
lore

Romain Naour

author
#0 lore raw

PATCH 1/1 support/config-fragments: linaro-arm: remove default option

Remove BR2_ARM_EABIHF and BR2_TOOLCHAIN_EXTERNAL_LINARO_ARM which are used by default when a cortex-A8 CPU is used.

Signed-off-by Romain Naour <[email protected]>
---
 support/config-fragments/autobuild/linaro-arm.config | 2 --
 1 file changed, 2 deletions(-)
support/config-fragments/autobuild/linaro-arm.config +0 -2
index d72e19b3ad..0f9b687d7a 100644
@@ -1,5 +1,3 @@
 BR2_arm=y
 BR2_cortex_a8=y
-BR2_ARM_EABIHF=y
 BR2_TOOLCHAIN_EXTERNAL=y
-BR2_TOOLCHAIN_EXTERNAL_LINARO_ARM=y
Signature · 1 line
2.14.3
author
#1 lore raw

PATCH 1/1 support/config-fragments: linaro-aarch64: remove default option

Remove BR2_TOOLCHAIN_EXTERNAL_LINARO_AARCH64 which is used by default when a aarch64 CPU is used.

Signed-off-by Romain Naour <[email protected]>
---
 support/config-fragments/autobuild/linaro-aarch64.config | 1 -
 1 file changed, 1 deletion(-)
support/config-fragments/autobuild/linaro-aarch64.config +0 -1
index f65f78a39b..bb466f384b 100644
@@ -1,3 +1,2 @@
 BR2_aarch64=y
 BR2_TOOLCHAIN_EXTERNAL=y
-BR2_TOOLCHAIN_EXTERNAL_LINARO_AARCH64=y
Signature · 1 line
2.14.3
author
#2 lore raw

PATCH 1/1 support/config-fragments: br-powerpc-internal-full: remove old option

In reply to Romain Naour

BR2_TOOLCHAIN_BUILDROOT_INET_IPV6 has been removed with the commit [1].

Since this option is still in br-powerpc-internal-full config-fragment, the powerpc configuration is droped by autobuild-run script:

WARN: toolchain can't be used
Missing: BR2_TOOLCHAIN_BUILDROOT_INET_IPV6=y
[Sat, 06 Jan 2018 03:03:43] WARN: failed to generate configuration

[1] 4bcacfd2c05f45171c011d4af7731c6f848819a4

Signed-off-by Romain Naour <[email protected]>
Cc Thomas Petazzoni <[email protected]>
---
 support/config-fragments/autobuild/br-powerpc-internal-full.config | 1 -
 1 file changed, 1 deletion(-)
support/config-fragments/autobuild/br-powerpc-internal-full.config +0 -1
index 2621e9fb41..61b3e7a966 100644
@@ -1,5 +1,4 @@
 BR2_powerpc=y
-BR2_TOOLCHAIN_BUILDROOT_INET_IPV6=y
 BR2_TOOLCHAIN_BUILDROOT_LOCALE=y
 BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
 BR2_TOOLCHAIN_BUILDROOT_CXX=y
Signature · 1 line
2.14.3
Applied
#3 lore raw

PATCH 1/1 support/config-fragments: br-powerpc-internal-full: remove old option

Hello,

Quoted 9 lines · Romain Naour

BR2_TOOLCHAIN_BUILDROOT_INET_IPV6 has been removed with the commit [1].

Since this option is still in br-powerpc-internal-full config-fragment, the powerpc configuration is droped by autobuild-run script:

WARN: toolchain can't be used
Missing: BR2_TOOLCHAIN_BUILDROOT_INET_IPV6=y
[Sat, 06 Jan 2018 03:03:43] WARN: failed to generate configuration

Quoted 7 lines

[1] 4bcacfd2c05f45171c011d4af7731c6f848819a4

Signed-off-by Romain Naour <[email protected]>
Cc Thomas Petazzoni <[email protected]>
---
 support/config-fragments/autobuild/br-powerpc-internal-full.config | 1 -
 1 file changed, 1 deletion(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#4 lore raw

PATCH 1/1 support/config-fragments: linaro-arm: remove default option

In reply to Romain Naour

Hello,

Quoted 13 lines · Romain Naour

Remove BR2_ARM_EABIHF and BR2_TOOLCHAIN_EXTERNAL_LINARO_ARM which are used by default when a cortex-A8 CPU is used.

Signed-off-by Romain Naour <[email protected]>
---
 support/config-fragments/autobuild/linaro-arm.config | 2 --
 1 file changed, 2 deletions(-)
support/config-fragments/autobuild/linaro-arm.config +0 -0
index d72e19b3ad..0f9b687d7a 100644

support/config-fragments/autobuild/linaro-arm.config line 5

Quoted 5 lines
support/config-fragments/autobuild/linaro-arm.config +0 -2
@@ -1,5 +1,3 @@
 BR2_arm=y
 BR2_cortex_a8=y
-BR2_ARM_EABIHF=y
 BR2_TOOLCHAIN_EXTERNAL=y
-BR2_TOOLCHAIN_EXTERNAL_LINARO_ARM=y

I am not convinced about removing BR2_TOOLCHAIN_EXTERNAL_LINARO_ARM. Indeed, we may very well add another external toolchain in the future for ARM EABIhf. But since this defconfig is named linaro-arm, it really should test the Linaro ARM toolchain, so it makes sense to have this explicit option.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com