Skip to contentSkip to conversation

debugger: Convert to current intel_register_access_init()

PATCH In review Rhys Kidd 3 participants 6 messages Jan 10, 2018 – Jan 16, 2018

lore
Share & tools
lore

Rhys Kidd

author
#0 lore raw

PATCH 1/3 debugger: Convert to current intel_register_access_init()

Fixes 301ad44c ("lib: Open debugfs files for the given DRM device")
Signed-off-by Rhys Kidd <[email protected]>
---
 debugger/debug_rdata.c | 2 +-
 debugger/eudb.c        | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
debugger/debug_rdata.c +1 -1
index 61d82d9e..45084b8e 100644
@@ -135,7 +135,7 @@ int main(int argc, char *argv[]) {
 	struct pci_device *pci_dev;
 	pci_dev = intel_get_pci_device();
 
-	intel_register_access_init(pci_dev, 1);
+	intel_register_access_init(pci_dev, 0, 1);
 	find_stuck_threads();
 //	collect_rdata(atoi(argv[1]), atoi(argv[2]));
 	return 0;
debugger/eudb.c +1 -1
index 866d4b52..8384950a 100644
@@ -540,7 +540,7 @@ int main(int argc, char* argv[]) {
 		abort();
 	}
 
-	assert(intel_register_access_init(pci_dev, 1) == 0);
+	assert(intel_register_access_init(pci_dev, 0, 1) == 0);
 
 	memset(bits, -1, sizeof(bits));
 	/*
Signature · 6 lines
2.14.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
author
#1 lore raw

PATCH 2/3 debugger: Clean up register access helper in debug_rdata

Clean up the register access helper initialized with intel_register_access_init() by debug_rdata

Signed-off-by Rhys Kidd <[email protected]>
---
 debugger/debug_rdata.c | 1 +
 1 file changed, 1 insertion(+)
debugger/debug_rdata.c +1 -0
index 45084b8e..4db7cbcd 100644
@@ -138,5 +138,6 @@ int main(int argc, char *argv[]) {
 	intel_register_access_init(pci_dev, 0, 1);
 	find_stuck_threads();
 //	collect_rdata(atoi(argv[1]), atoi(argv[2]));
+	intel_register_access_fini();
 	return 0;
 }
Signature · 6 lines
2.14.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
author
#2 lore raw

PATCH 3/3 debugger: No longer rely on compatability define in intel_bufmgr.h

In reply to Rhys Kidd

Symbol rename from dri_* to drm_intel_* introduced a number of compatability defines within intel_bufmgr.h.

Replace the old function with the new function, consistent with the balance of this file.

Signed-off-by Rhys Kidd <[email protected]>
---
 debugger/eudb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
debugger/eudb.c +1 -1
index 8384950a..de37be52 100644
@@ -562,7 +562,7 @@ int main(int argc, char* argv[]) {
 			if (fscanf(stdin, "%1d", &dh_handle) == 0)
 				exit(1);
 		}
-		scratch_bo = intel_bo_gem_create_from_name(bufmgr, "scratch", dh_handle);
+		scratch_bo = drm_intel_bo_gem_create_from_name(bufmgr, "scratch", dh_handle);
 		if (scratch_bo == NULL) {
 			fprintf(stderr, "Couldn't flink buffer\n");
 			abort();
Signature · 6 lines
2.14.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v1 3/3
#3 lore raw

Re: [PATCH i-g-t 3/3] debugger: No longer rely on compatability define in intel_bufmgr.h

Quoted 16 lines · Rhys Kidd

Symbol rename from dri_* to drm_intel_* introduced a number of compatability defines within intel_bufmgr.h.

Replace the old function with the new function, consistent with the balance of this file.

Signed-off-by Rhys Kidd <[email protected]>

---
debugger/eudb.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
debugger/eudb.c +0 -0
index 8384950a..de37be52 100644

debugger/eudb.c int main(int argc, char* argv[]) { · line 568

Quoted 8 lines
debugger/eudb.c +1 -1
@@ -562,7 +562,7 @@ int main(int argc, char* argv[]) {
 			if (fscanf(stdin, "%1d", &dh_handle) == 0)
 				exit(1);
 		}
-		scratch_bo = intel_bo_gem_create_from_name(bufmgr, "scratch", dh_handle);
+		scratch_bo = drm_intel_bo_gem_create_from_name(bufmgr, "scratch", dh_handle);
 		if (scratch_bo == NULL) {
 			fprintf(stderr, "Couldn't flink buffer\n");
 			abort();

The series looks good to me, but keep in mind that we never actually made this work after Sandybridge, and even there, nobody ever ran it but me :-)

Reviewed-by Ben Widawsky <[email protected]>
Signature · 5 lines
Ben Widawsky, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
CI
#4 lore raw

✓ Fi.CI.BAT: success for series starting with [1/3] debugger: Convert to current intel_register_access_init()

In reply to Rhys Kidd
== Series Details ==

== Series Details ==

Series: series starting with [1/3] debugger: Convert to current intel_register_access_init()
URL : https://patchwork.freedesktop.org/series/36242/
State : success

== Summary ==

IGT patchset tested on top of latest successful build 834321a5d76a16783000441a02d7e79e72be9cc9 tools: Cannonlake port clock programming

with latest DRM-Tip kernel build CI_DRM_3617
c6410238e3c4 drm-tip: 2018y-01m-09d-18h-59m-27s UTC integration manifest

No testlist changes.

Test debugfs_test:

        Subgroup read_all_entries:
                pass       -> INCOMPLETE (fi-snb-2520m) fdo#103713
Test gem_mmap_gtt:
        Subgroup basic-small-bo-tiledx:
                fail       -> PASS       (fi-gdg-551) fdo#102575
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-c:
                fail       -> PASS       (fi-skl-6700k2) fdo#104108

fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108

fi-bdw-5557u     total:288  pass:267  dwarn:0   dfail:0   fail:0   skip:21  time:424s
fi-bdw-gvtdvm    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:424s
fi-blb-e6850     total:288  pass:223  dwarn:1   dfail:0   fail:0   skip:64  time:372s
fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:488s
fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:282s
fi-bxt-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:486s
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:490s
fi-byt-j1900     total:288  pass:253  dwarn:0   dfail:0   fail:0   skip:35  time:475s
fi-byt-n2820     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:464s
fi-elk-e7500     total:224  pass:168  dwarn:9   dfail:1   fail:0   skip:45 
fi-gdg-551       total:288  pass:180  dwarn:0   dfail:0   fail:0   skip:108 time:278s
fi-glk-1         total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:524s
fi-hsw-4770      total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:394s
fi-hsw-4770r     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:403s
fi-ilk-650       total:288  pass:228  dwarn:0   dfail:0   fail:0   skip:60  time:412s
fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:450s
fi-ivb-3770      total:288  pass:255  dwarn:0   dfail:0   fail:0   skip:33  time:416s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:467s
fi-kbl-7560u     total:288  pass:269  dwarn:0   dfail:0   fail:0   skip:19  time:505s
fi-kbl-7567u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:456s
fi-kbl-r         total:288  pass:260  dwarn:1   dfail:0   fail:0   skip:27  time:503s
fi-pnv-d510      total:288  pass:222  dwarn:1   dfail:0   fail:0   skip:65  time:580s
fi-skl-6260u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:439s
fi-skl-6600u     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:511s
fi-skl-6700hq    total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:532s
fi-skl-6700k2    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:495s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:494s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:432s
fi-snb-2520m     total:3    pass:2    dwarn:0   dfail:0   fail:0   skip:0  
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:401s
Blacklisted hosts:
fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:573s
fi-cnl-y2        total:288  pass:258  dwarn:3   dfail:0   fail:0   skip:27  time:545s
fi-glk-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:480s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_762/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

CI
#5 lore raw

✗ Fi.CI.IGT: failure for series starting with [1/3] debugger: Convert to current intel_register_access_init()

In reply to Rhys Kidd
== Series Details ==

== Series Details ==

Series: series starting with [1/3] debugger: Convert to current intel_register_access_init()
URL : https://patchwork.freedesktop.org/series/36242/
State : failure

== Summary ==

Test kms_frontbuffer_tracking:

        Subgroup fbc-1p-offscren-pri-shrfb-draw-render:
                fail       -> PASS       (shard-snb) fdo#101623
        Subgroup fbc-1p-pri-indfb-multidraw:
                pass       -> SKIP       (shard-hsw) fdo#103167
Test kms_flip:
        Subgroup flip-vs-absolute-wf_vblank-interruptible:
                fail       -> PASS       (shard-hsw) fdo#100368
Test kms_rotation_crc:
        Subgroup primary-rotation-180-flip:
                pass       -> SKIP       (shard-hsw)
Test kms_busy:
        Subgroup extended-pageflip-hang-oldfb-render-a:
                pass       -> SKIP       (shard-hsw)
Test kms_draw_crc:
        Subgroup fill-fb:
                pass       -> SKIP       (shard-hsw)
Test syncobj_wait:
        Subgroup wait-any-interrupted:
                pass       -> INCOMPLETE (shard-hsw)
Test kms_cursor_legacy:
        Subgroup flip-vs-cursor-toggle:
                pass       -> SKIP       (shard-hsw) fdo#102670
Test kms_properties:
        Subgroup crtc-properties-legacy:
                pass       -> SKIP       (shard-hsw)

fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102670 https://bugs.freedesktop.org/show_bug.cgi?id=102670

shard-hsw        total:2574 pass:1448 dwarn:1   dfail:0   fail:10  skip:1112 time:8246s
shard-snb        total:2578 pass:1241 dwarn:2   dfail:0   fail:11  skip:1322 time:7386s
Blacklisted hosts:
shard-apl        total:2578 pass:1596 dwarn:1   dfail:0   fail:27  skip:952 time:12844s
shard-kbl        total:2566 pass:1693 dwarn:1   dfail:0   fail:29  skip:840 time:9577s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_762/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx