phy: qcom-ufs: add MODULE_LICENSE tag
Subsystems (2)
PATCH 1/1 phy: qcom-ufs: add MODULE_LICENSE tag
While the specific UFS PHY drivers (14nm and 20nm) have a module license, the common base module does not, leading to a Kbuild failure:
WARNING: modpost: missing MODULE_LICENSE() in drivers/phy/qualcomm/phy-qcom-ufs.o
FATAL: modpost: GPL-incompatible module phy-qcom-ufs.ko uses GPL-only symbol 'clk_enable'
This adds a module description and license tag to fix the build. I added both Yaniv and Vivek as authors here, as Yaniv sent the initial submission, while Vivek did most of the work since.
--- drivers/phy/qualcomm/phy-qcom-ufs.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/phy/qualcomm/phy-qcom-ufs.c +5 -0
@@ -675,3 +675,8 @@ int ufs_qcom_phy_power_off(struct phy *generic_phy)return 0 ; }EXPORT_SYMBOL_GPL (ufs_qcom_phy_power_off); + +MODULE_AUTHOR ("Yaniv Gardi <[email protected]>" ); +MODULE_AUTHOR ("Vivek Gautam <[email protected]>" ); +MODULE_DESCRIPTION ("Universal Flash Storage (UFS) QCOM PHY" ); +MODULE_LICENSE ("GPL v2" );
Signature · 1 line
2.9.0
Quoted 4 lines · Arnd Bergmann
While the specific UFS PHY drivers (14nm and 20nm) have a module license, the common base module does not, leading to a
Kbuildfailure:
Quoted 8 lines
WARNING: modpost: missing
MODULE_LICENSE()indrivers/phy/qualcomm/phy-qcom-ufs.o
FATAL: modpost: GPL-incompatible module phy-qcom-ufs.ko uses GPL-only symbol 'clk_enable'This adds a module description and license tag to fix the build. I added both Yaniv and Vivek as authors here, as Yaniv sent the initial submission, while Vivek did most of the work since.
Signed-off-by Arnd Bergmann <[email protected]>
I think this is now the last such warning we get in linux-next. Kishon, can you pick up my patch for 4.16 so we get a clean build again?
Thanks,
Arnd
Quoted 4 lines · Arnd Bergmann
While the specific UFS PHY drivers (14nm and 20nm) have a module license, the common base module does not, leading to a
Kbuildfailure:
Quoted 8 lines
WARNING: modpost: missing
MODULE_LICENSE()indrivers/phy/qualcomm/phy-qcom-ufs.o
FATAL: modpost: GPL-incompatible module phy-qcom-ufs.ko uses GPL-only symbol 'clk_enable'This adds a module description and license tag to fix the build. I added both Yaniv and Vivek as authors here, as Yaniv sent the initial submission, while Vivek did most of the work since.
Signed-off-by Arnd Bergmann <[email protected]>
Regards,
Bjorn
Quoted 20 lines
--- drivers/phy/qualcomm/phy-qcom-ufs.c | 5 +++++ 1 file changed, 5 insertions(+)drivers/phy/qualcomm/phy-qcom-ufs.c +5
-0@@ -675,3 +675,8 @@ int ufs_qcom_phy_power_off(struct phy *generic_phy)return 0 ; }EXPORT_SYMBOL_GPL (ufs_qcom_phy_power_off); + +MODULE_AUTHOR ("Yaniv Gardi <[email protected]>" ); +MODULE_AUTHOR ("Vivek Gautam <[email protected]>" ); +MODULE_DESCRIPTION ("Universal Flash Storage (UFS) QCOM PHY" ); +MODULE_LICENSE ("GPL v2" );Signature · 1 line
2.9.0