Skip to contentSkip to conversation

include inttypes.h for PRI defines

PATCH Superseded Mike Frysinger 3 participants 8 messages Jan 10, 2018 – Jan 11, 2018 Library code

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 include inttypes.h for PRI defines

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96620

---
 lib/igt_fb.c | 1 +
 1 file changed, 1 insertion(+)
lib/igt_fb.c +1 -0
index dcae07dff021..ded639e833f1 100644
@@ -27,6 +27,7 @@
 
 #include <stdio.h>
 #include <math.h>
+#include <inttypes.h>
 
 #include "drmtest.h"
 #include "igt_fb.h"
Signature · 6 lines
2.15.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

✓ Fi.CI.BAT: success for include inttypes.h for PRI defines (rev2)

== Series Details ==

== Series Details ==

Series: include inttypes.h for PRI defines (rev2)
URL : https://patchwork.freedesktop.org/series/9041/
State : success

== Summary ==

IGT patchset tested on top of latest successful build 834321a5d76a16783000441a02d7e79e72be9cc9 tools: Cannonlake port clock programming

with latest DRM-Tip kernel build CI_DRM_3617
c6410238e3c4 drm-tip: 2018y-01m-09d-18h-59m-27s UTC integration manifest

No testlist changes.

Test debugfs_test:

        Subgroup read_all_entries:
                dmesg-fail -> DMESG-WARN (fi-elk-e7500) fdo#103989
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-c:
                fail       -> PASS       (fi-skl-6700k2) fdo#104108

fdo#103989 https://bugs.freedesktop.org/show_bug.cgi?id=103989
fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108

fi-bdw-5557u     total:288  pass:267  dwarn:0   dfail:0   fail:0   skip:21  time:429s
fi-bdw-gvtdvm    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:428s
fi-blb-e6850     total:288  pass:223  dwarn:1   dfail:0   fail:0   skip:64  time:372s
fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:492s
fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:281s
fi-bxt-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:485s
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:492s
fi-byt-j1900     total:288  pass:253  dwarn:0   dfail:0   fail:0   skip:35  time:472s
fi-byt-n2820     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:460s
fi-elk-e7500     total:224  pass:168  dwarn:10  dfail:0   fail:0   skip:45 
fi-gdg-551       total:288  pass:179  dwarn:0   dfail:0   fail:1   skip:108 time:274s
fi-glk-1         total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:514s
fi-hsw-4770      total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:394s
fi-hsw-4770r     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:401s
fi-ilk-650       total:288  pass:228  dwarn:0   dfail:0   fail:0   skip:60  time:415s
fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:461s
fi-ivb-3770      total:288  pass:255  dwarn:0   dfail:0   fail:0   skip:33  time:415s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:466s
fi-kbl-7560u     total:288  pass:269  dwarn:0   dfail:0   fail:0   skip:19  time:497s
fi-kbl-7567u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:456s
fi-kbl-r         total:288  pass:260  dwarn:1   dfail:0   fail:0   skip:27  time:505s
fi-pnv-d510      total:288  pass:222  dwarn:1   dfail:0   fail:0   skip:65  time:581s
fi-skl-6260u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:430s
fi-skl-6600u     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:508s
fi-skl-6700hq    total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:527s
fi-skl-6700k2    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:492s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:483s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:431s
fi-snb-2520m     total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:536s
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:401s
Blacklisted hosts:
fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:568s
fi-cnl-y2        total:288  pass:258  dwarn:3   dfail:0   fail:0   skip:27  time:537s
fi-glk-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:483s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_759/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw

✗ Fi.CI.IGT: failure for include inttypes.h for PRI defines (rev2)

In reply to Mike Frysinger
== Series Details ==

== Series Details ==

Series: include inttypes.h for PRI defines (rev2)
URL : https://patchwork.freedesktop.org/series/9041/
State : failure

== Summary ==

Test gem_shrink:

        Subgroup reclaim:
                pass       -> DMESG-FAIL (shard-hsw)
Test kms_frontbuffer_tracking:
        Subgroup fbc-1p-offscren-pri-shrfb-draw-render:
                fail       -> PASS       (shard-snb) fdo#101623 +1
Test gem_tiled_swapping:
        Subgroup non-threaded:
                pass       -> INCOMPLETE (shard-snb) fdo#104218
Test kms_flip:
        Subgroup flip-vs-absolute-wf_vblank-interruptible:
                fail       -> PASS       (shard-hsw) fdo#100368
Test pm_rpm:
        Subgroup system-suspend-modeset:
                pass       -> SKIP       (shard-hsw)

fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#104218 https://bugs.freedesktop.org/show_bug.cgi?id=104218
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368

shard-hsw        total:2592 pass:1464 dwarn:1   dfail:1   fail:10  skip:1113 time:8022s
shard-snb        total:2451 pass:1177 dwarn:1   dfail:0   fail:10  skip:1260 time:6718s
Blacklisted hosts:
shard-apl        total:2600 pass:1603 dwarn:1   dfail:0   fail:29  skip:964 time:12574s
shard-kbl        total:2590 pass:1716 dwarn:1   dfail:0   fail:29  skip:841 time:9351s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_759/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw
In reply to Mike Frysinger
Quoted 5 lines · Mike Frysinger

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96620

---
 lib/igt_fb.c | 1 +
 1 file changed, 1 insertion(+)

Files matching "PRI[diuoxX]" but not "inttypes.h":

lib/igt_fb.c
lib/igt_kms.c
lib/intel_os.c
tests/prime_nv_pcopy.c
tools/hsw_compute_wrpll.c
tools/intel_gpu_top.c
tools/intel_opregion_decode.c
tools/intel_residency.c
tools/intel_watermark.c

Looks like they get inttypes.h here via

igt.h and pals -> intel_chipset.h -> pciaccess.h -> inttypes.h

The mystery is why the other files haven't slapped you with the same issue. Regardless, same change should be done in all of those. Can you expand this patch?

Signature · 1 line
Petri Latvala
Quoted 20 lines
lib/igt_fb.c +1 -0
index dcae07dff021..ded639e833f1 100644
@@ -27,6 +27,7 @@
 
 #include <stdio.h>
 #include <math.h>
+#include <inttypes.h>
 
 #include "drmtest.h"
 #include "igt_fb.h"
Signature · 6 lines
2.15.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw
Quoted 20 lines · Petri Latvala
Quoted 5 lines · Mike Frysinger

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96620

---
 lib/igt_fb.c | 1 +
 1 file changed, 1 insertion(+)

Files matching "PRI[diuoxX]" but not "inttypes.h":

lib/igt_fb.c
lib/igt_kms.c
lib/intel_os.c
tests/prime_nv_pcopy.c
tools/hsw_compute_wrpll.c
tools/intel_gpu_top.c
tools/intel_opregion_decode.c
tools/intel_residency.c
tools/intel_watermark.c

Quoted 7 lines

Looks like they get inttypes.h here via

igt.h and pals -> intel_chipset.h -> pciaccess.h -> inttypes.h

The mystery is why the other files haven't slapped you with the same issue. Regardless, same change should be done in all of those. Can you expand this patch?

yeah i patched the one that was failing rather than looking deeper. i can update them all.
-mike

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw

PATCH v2 1/1 include inttypes.h for PRI defines

In reply to Mike Frysinger

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96620

---
 lib/igt_fb.c                  | 1 +
 lib/igt_kms.c                 | 1 +
 lib/intel_os.c                | 1 +
 tests/prime_nv_pcopy.c        | 1 +
 tools/hsw_compute_wrpll.c     | 1 +
 tools/intel_gpu_top.c         | 1 +
 tools/intel_opregion_decode.c | 1 +
 tools/intel_residency.c       | 1 +
 tools/intel_watermark.c       | 1 +
 9 files changed, 9 insertions(+)
lib/igt_fb.c +1 -0
index dcae07dff021..ded639e833f1 100644
@@ -27,6 +27,7 @@
 
 #include <stdio.h>
 #include <math.h>
+#include <inttypes.h>
 
 #include "drmtest.h"
 #include "igt_fb.h"
lib/igt_kms.c +1 -0
index 069752ecf12b..eb57f4a99454 100644
@@ -26,6 +26,7 @@
  */
 
 #include "config.h"
+#include <inttypes.h>
 #include <unistd.h>
 #include <stdio.h>
 #include <stdarg.h>
lib/intel_os.c +1 -0
index a77566c15d9b..bb2c16bf3283 100644
@@ -28,6 +28,7 @@
 
 #include "config.h"
 
+#include <inttypes.h>
 #include <unistd.h>
 #include <stdlib.h>
 #include <stdio.h>
tests/prime_nv_pcopy.c +1 -0
index b5ceabf15cc7..bbcf76807cf6 100644
@@ -15,6 +15,7 @@
 
 
 #include "igt.h"
+#include <inttypes.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <unistd.h>
tools/hsw_compute_wrpll.c +1 -0
index 6c85c07c77c4..b1eeb7c7cd76 100644
@@ -21,6 +21,7 @@
  * DEALINGS IN THE SOFTWARE.
  */
 
+#include <inttypes.h>
 #include <stdio.h>
 #include <stdbool.h>
 #include <stdint.h>
tools/intel_gpu_top.c +1 -0
index 83cf53eaaf0b..098e6ce3ff86 100644
@@ -29,6 +29,7 @@
 
 #include "config.h"
 
+#include <inttypes.h>
 #include <unistd.h>
 #include <stdlib.h>
 #include <stdio.h>
tools/intel_opregion_decode.c +1 -0
index 380e43a8b514..b0a503e1a0c0 100644
@@ -28,6 +28,7 @@
 #include <errno.h>
 #include <fcntl.h>
 #include <getopt.h>
+#include <inttypes.h>
 #include <stdint.h>
 #include <stdio.h>
 #include <stdlib.h>
tools/intel_residency.c +1 -0
index 116215a1ede1..bfab40da42d4 100644
@@ -28,6 +28,7 @@
 #include <sys/types.h>
 #include <sys/stat.h>
 #include <fcntl.h>
+#include <inttypes.h>
 #include <unistd.h>
 #include <signal.h>
 #include <time.h>
tools/intel_watermark.c +1 -0
index 308e351dcd2f..03da68b6ff69 100644
@@ -22,6 +22,7 @@
  *
  */
 
+#include <inttypes.h>
 #include <unistd.h>
 #include <stdlib.h>
 #include <stdio.h>
Signature · 6 lines
2.15.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v2 1/1
#6 lore raw
Quoted 2 lines · Mike Frysinger

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96620

# for file in $(git grep -l 'PRI[diuoxX]'); do grep -q inttypes "$file" || echo $file; done
#

And pushed, thanks.

Signature · 1 line
Petri Latvala
Quoted 127 lines
---
 lib/igt_fb.c                  | 1 +
 lib/igt_kms.c                 | 1 +
 lib/intel_os.c                | 1 +
 tests/prime_nv_pcopy.c        | 1 +
 tools/hsw_compute_wrpll.c     | 1 +
 tools/intel_gpu_top.c         | 1 +
 tools/intel_opregion_decode.c | 1 +
 tools/intel_residency.c       | 1 +
 tools/intel_watermark.c       | 1 +
 9 files changed, 9 insertions(+)
lib/igt_fb.c +1 -0
index dcae07dff021..ded639e833f1 100644
@@ -27,6 +27,7 @@
 
 #include <stdio.h>
 #include <math.h>
+#include <inttypes.h>
 
 #include "drmtest.h"
 #include "igt_fb.h"
lib/igt_kms.c +1 -0
index 069752ecf12b..eb57f4a99454 100644
@@ -26,6 +26,7 @@
  */
 
 #include "config.h"
+#include <inttypes.h>
 #include <unistd.h>
 #include <stdio.h>
 #include <stdarg.h>
lib/intel_os.c +1 -0
index a77566c15d9b..bb2c16bf3283 100644
@@ -28,6 +28,7 @@
 
 #include "config.h"
 
+#include <inttypes.h>
 #include <unistd.h>
 #include <stdlib.h>
 #include <stdio.h>
tests/prime_nv_pcopy.c +1 -0
index b5ceabf15cc7..bbcf76807cf6 100644
@@ -15,6 +15,7 @@
 
 
 #include "igt.h"
+#include <inttypes.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <unistd.h>
tools/hsw_compute_wrpll.c +1 -0
index 6c85c07c77c4..b1eeb7c7cd76 100644
@@ -21,6 +21,7 @@
  * DEALINGS IN THE SOFTWARE.
  */
 
+#include <inttypes.h>
 #include <stdio.h>
 #include <stdbool.h>
 #include <stdint.h>
tools/intel_gpu_top.c +1 -0
index 83cf53eaaf0b..098e6ce3ff86 100644
@@ -29,6 +29,7 @@
 
 #include "config.h"
 
+#include <inttypes.h>
 #include <unistd.h>
 #include <stdlib.h>
 #include <stdio.h>
tools/intel_opregion_decode.c +1 -0
index 380e43a8b514..b0a503e1a0c0 100644
@@ -28,6 +28,7 @@
 #include <errno.h>
 #include <fcntl.h>
 #include <getopt.h>
+#include <inttypes.h>
 #include <stdint.h>
 #include <stdio.h>
 #include <stdlib.h>
tools/intel_residency.c +1 -0
index 116215a1ede1..bfab40da42d4 100644
@@ -28,6 +28,7 @@
 #include <sys/types.h>
 #include <sys/stat.h>
 #include <fcntl.h>
+#include <inttypes.h>
 #include <unistd.h>
 #include <signal.h>
 #include <time.h>
tools/intel_watermark.c +1 -0
index 308e351dcd2f..03da68b6ff69 100644
@@ -22,6 +22,7 @@
  *
  */
 
+#include <inttypes.h>
 #include <unistd.h>
 #include <stdlib.h>
 #include <stdio.h>
Signature · 6 lines
2.15.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#7 lore raw

✓ Fi.CI.BAT: success for include inttypes.h for PRI defines (rev3)

In reply to Mike Frysinger
== Series Details ==

== Series Details ==

Series: include inttypes.h for PRI defines (rev3)
URL : https://patchwork.freedesktop.org/series/9041/
State : success

== Summary ==

IGT patchset tested on top of latest successful build 19c6c040b11d7a7068c66ae918a88c150243279b lib/igt_kms.c: Unconditionally include poll.h

with latest DRM-Tip kernel build CI_DRM_3620
7b72161536aa drm-tip: 2018y-01m-10d-19h-08m-42s UTC integration manifest

No testlist changes.

Test gem_ringfill:

        Subgroup basic-default-hang:
                dmesg-warn -> INCOMPLETE (fi-pnv-d510) fdo#101600
Test kms_frontbuffer_tracking:
        Subgroup basic:
                skip       -> INCOMPLETE (fi-elk-e7500) fdo#103989
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-a:
                pass       -> DMESG-WARN (fi-kbl-r) fdo#104172 +1
        Subgroup suspend-read-crc-pipe-b:
                pass       -> INCOMPLETE (fi-snb-2520m) fdo#103713

fdo#101600 https://bugs.freedesktop.org/show_bug.cgi?id=101600
fdo#103989 https://bugs.freedesktop.org/show_bug.cgi?id=103989
fdo#104172 https://bugs.freedesktop.org/show_bug.cgi?id=104172
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713

fi-bdw-5557u     total:288  pass:267  dwarn:0   dfail:0   fail:0   skip:21  time:423s
fi-bdw-gvtdvm    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:426s
fi-blb-e6850     total:288  pass:223  dwarn:1   dfail:0   fail:0   skip:64  time:378s
fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:489s
fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:282s
fi-bxt-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:487s
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:489s
fi-byt-j1900     total:288  pass:253  dwarn:0   dfail:0   fail:0   skip:35  time:483s
fi-byt-n2820     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:463s
fi-elk-e7500     total:224  pass:168  dwarn:10  dfail:0   fail:0   skip:45 
fi-gdg-551       total:288  pass:179  dwarn:0   dfail:0   fail:1   skip:108 time:287s
fi-glk-1         total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:515s
fi-hsw-4770      total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:392s
fi-hsw-4770r     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:401s
fi-ilk-650       total:288  pass:228  dwarn:0   dfail:0   fail:0   skip:60  time:416s
fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:460s
fi-ivb-3770      total:288  pass:255  dwarn:0   dfail:0   fail:0   skip:33  time:418s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:474s
fi-kbl-7560u     total:288  pass:269  dwarn:0   dfail:0   fail:0   skip:19  time:501s
fi-kbl-7567u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:454s
fi-kbl-r         total:288  pass:260  dwarn:1   dfail:0   fail:0   skip:27  time:504s
fi-pnv-d510      total:146  pass:113  dwarn:0   dfail:0   fail:0   skip:32 
fi-skl-6260u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:436s
fi-skl-6600u     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:510s
fi-skl-6700hq    total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:531s
fi-skl-6700k2    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:498s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:498s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:433s
fi-snb-2520m     total:245  pass:211  dwarn:0   dfail:0   fail:0   skip:33 
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:399s
Blacklisted hosts:
fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:569s
fi-cnl-y2        total:288  pass:258  dwarn:3   dfail:0   fail:0   skip:27  time:547s
fi-glk-dsi       total:288  pass:238  dwarn:1   dfail:4   fail:0   skip:45  time:475s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_766/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx