Skip to contentSkip to conversation

tools/testing: Fix trailing semicolon

PATCH In review Luis de Bethencourt 2 participants 3 messages Jan 11, 2018 Kselftest

lore
Share & tools
lore

Luis de Bethencourt

author
#0 lore raw

PATCH 1/1 tools/testing: Fix trailing semicolon

The trailing semicolon is an empty statement that does no operation. Removing it since it doesn't do anything.

Signed-off-by Luis de Bethencourt <luisbg at kernel.org>

---

Hi Shuah,

After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches suggested I fix it treewide [0].

Best regards :)
Luis

[0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
[1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html

 tools/testing/selftests/nsfs/pidns.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/nsfs/pidns.c +1 -1
index 1182d4e437a2..e0d86e1668c0 100644
@@ -70,7 +70,7 @@ int main(int argc, char *argv[])
 			return pr_err("NS_GET_PARENT returned a wrong namespace");
 
 		if (ioctl(pns, NS_GET_PARENT) >= 0 || errno != EPERM)
-			return pr_err("Don't get EPERM");;
+			return pr_err("Don't get EPERM");
 	}
 
 	kill(pid, SIGKILL);
Signature · 6 lines
2.15.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
maintainer
#1 lore raw
Quoted 27 lines · Luis de Bethencourt

The trailing semicolon is an empty statement that does no operation. Removing it since it doesn't do anything.

Signed-off-by Luis de Bethencourt <luisbg at kernel.org>

---

Hi Shuah,

After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches suggested I fix it treewide [0].

Best regards :)
Luis

[0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
[1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html

 tools/testing/selftests/nsfs/pidns.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/nsfs/pidns.c +0 -0
index 1182d4e437a2..e0d86e1668c0 100644

tools/testing/selftests/nsfs/pidns.c int main(int argc, char *argv[]) · line 76

Quoted 8 lines
tools/testing/selftests/nsfs/pidns.c +1 -1
@@ -70,7 +70,7 @@ int main(int argc, char *argv[])
 			return pr_err("NS_GET_PARENT returned a wrong namespace");
 
 		if (ioctl(pns, NS_GET_PARENT) >= 0 || errno != EPERM)
-			return pr_err("Don't get EPERM");;
+			return pr_err("Don't get EPERM");
 	}
 
 	kill(pid, SIGKILL);

Thanks for the patch. I will take this in for 4.16-rc1.

thanks,
-- Shuah
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

author
#2 lore raw
Quoted 34 lines · Shuah Khan
Quoted 33 lines · Luis de Bethencourt

The trailing semicolon is an empty statement that does no operation. Removing it since it doesn't do anything.

Signed-off-by Luis de Bethencourt <luisbg at kernel.org>

---

Hi Shuah,

After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches suggested I fix it treewide [0].

Best regards :)
Luis

[0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
[1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html

 tools/testing/selftests/nsfs/pidns.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/nsfs/pidns.c +1 -1
index 1182d4e437a2..e0d86e1668c0 100644
@@ -70,7 +70,7 @@ int main(int argc, char *argv[])
 			return pr_err("NS_GET_PARENT returned a wrong namespace");
 
 		if (ioctl(pns, NS_GET_PARENT) >= 0 || errno != EPERM)
-			return pr_err("Don't get EPERM");;
+			return pr_err("Don't get EPERM");
 	}
Quoted 8 lines

tools/testing/selftests/nsfs/pidns.c int main(int argc, char *argv[]) · line 76

Quoted 2 lines
tools/testing/selftests/nsfs/pidns.c +0 -0
 	kill(pid, SIGKILL);

Thanks for the patch. I will take this in for 4.16-rc1.

thanks,
-- Shuah

Awesome. Thanks Shuah!
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html