system/Config.in: hide BR2_TARGET_GENERIC_GETTY_{TERM, OPTIONS} with systemd
PATCH 1/1 system/Config.in: hide BR2_TARGET_GENERIC_GETTY_{TERM, OPTIONS} with systemd
When systemd is used as the init system, the BR2_TARGET_GENERIC_GETTY_TERM and BR2_TARGET_GENERIC_GETTY_OPTIONS are completely ignored, which might confuse the user, as reported in bug
For now, let's simply make those options visible only with busybox init and sysv init, as suggested by Yann E. Morin in the discussion of bug #10301.
Fixes #10301.
--- system/Config.in | 4 ++++ 1 file changed, 4 insertions(+)
system/Config.in +4 -0
@@ -355,12 +355,16 @@ config BR2_TARGET_GENERIC_GETTY_BAUDRATE config BR2_TARGET_GENERIC_GETTY_TERM string "TERM environment variable" default "vt100" + # currently not observed by systemd + depends on BR2_INIT_BUSYBOX || BR2_INIT_SYSV help Specify a TERM type. config BR2_TARGET_GENERIC_GETTY_OPTIONS string "other options to pass to getty" default "" + # currently not observed by systemd + depends on BR2_INIT_BUSYBOX || BR2_INIT_SYSV help Any other flags you want to pass to getty, Refer to getty --help for details.
Signature · 1 line
2.14.3
PATCH 1/1 system/Config.in: hide BR2_TARGET_GENERIC_GETTY_{TERM, OPTIONS} with systemd
On 2018-01-10 23:14 +0100, Thomas Petazzoni spake thusly:
Quoted 22 lines
When systemd is used as the init system, the
BR2_TARGET_GENERIC_GETTY_TERMandBR2_TARGET_GENERIC_GETTY_OPTIONSare completely ignored, which might confuse the user, as reported in bugFor now, let's simply make those options visible only with busybox init and sysv init, as suggested by Yann E. Morin in the discussion of bug #10301.
Fixes #10301.
Reported-by Michael Heinemann <[email protected]>Suggested-by "Yann E. MORIN" <[email protected]>Signed-off-by Thomas Petazzoni <[email protected]>--- system/Config.in | 4 ++++ 1 file changed, 4 insertions(+)system/Config.in +0
-0
system/Config.in config BR2_TARGET_GENERIC_GETTY_BAUDRATE · line 359
Quoted 5 lines
system/Config.in +2
-0@@ -355,12 +355,16 @@ config BR2_TARGET_GENERIC_GETTY_BAUDRATE config BR2_TARGET_GENERIC_GETTY_TERM string "TERM environment variable" default "vt100" + # currently not observed by systemd + depends on BR2_INIT_BUSYBOX || BR2_INIT_SYSV
Why not:
depends on !BR2_INIT_SYSTEMD
because this is really want we want to express: this is not compatible with systemd...
system/Config.in config BR2_TARGET_GENERIC_GETTY_BAUDRATE · line 367
Quoted 8 lines
system/Config.in +2
-0help Specify a TERM type. config BR2_TARGET_GENERIC_GETTY_OPTIONS string "other options to pass to getty" default "" + # currently not observed by systemd + depends on BR2_INIT_BUSYBOX || BR2_INIT_SYSV
Ditto...
Regards,
Yann E. MORIN.
Quoted 6 lines
system/Config.in +0
-0help Any other flags you want to pass to getty, Refer to getty --help for details.Signature · 1 line
2.14.3
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/1 system/Config.in: hide BR2_TARGET_GENERIC_GETTY_{TERM, OPTIONS} with systemd
Hello,
Quoted 8 lines · Yann E. MORIN
Review
Quoted 2 lines
(quoted diff) +2
-0+ # currently not observed by systemd + depends on BR2_INIT_BUSYBOX || BR2_INIT_SYSVWhy not:
depends on !BR2_INIT_SYSTEMDbecause this is really want we want to express: this is not compatible with systemd...
No, what we really want to express is that BR2_TARGET_GENERIC_GETTY_{TERM,OPTIONS} are only handled in the busybox code and sysvinit code. It's not so much that they are not compatible with systemd, it is that only busybox and sysvinit observe those options.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
PATCH 1/1 system/Config.in: hide BR2_TARGET_GENERIC_GETTY_{TERM, OPTIONS} with systemd
Thomas, All,
On 2018-01-12 10:02 +0100, Thomas Petazzoni spake thusly:
Quoted 7 lines · Yann E. MORIN
Quoted 6 lines
Review
Quoted 2 lines
(quoted diff) +2
-0+ # currently not observed by systemd + depends on BR2_INIT_BUSYBOX || BR2_INIT_SYSVWhy not:
depends on !BR2_INIT_SYSTEMD
Quoted 8 lines
Quoted 2 lines
because this is really want we want to express: this is not compatible with systemd...
No, what we really want to express is that BR2_TARGET_GENERIC_GETTY_{TERM,OPTIONS} are only handled in the busybox code and sysvinit code. It's not so much that they are not compatible with systemd, it is that only busybox and sysvinit observe those options.
Then change the title and commit to something like:
system: only expose getty option for busybox and sysvinit
Only busybox and sysvinit handle those options; the other init systems do not.
So, protect those options behind appropriate dependencies on busybox or sysvinit.
Fixes #10301.
And then you can add my:
Reviewed-by: "Yann E. MORIN" <[email protected]>
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/1 system/Config.in: hide BR2_TARGET_GENERIC_GETTY_{TERM, OPTIONS} with systemd
Hello,
Quoted 7 lines · Yann E. MORIN
Then change the title and commit to something like:
system: only expose getty option for busybox and sysvinit
Only busybox and sysvinit handle those options; the other init systems do not.
Quoted 8 lines
So, protect those options behind appropriate dependencies on busybox or sysvinit.
Fixes #10301.
And then you can add my:
Reviewed-by: "Yann E. MORIN" <[email protected]>
ACK, thanks for the feedback!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
PATCH 1/1 system/Config.in: hide BR2_TARGET_GENERIC_GETTY_{TERM, OPTIONS} with systemd
In reply to Thomas PetazzoniHello,
Quoted 8 lines · Thomas Petazzoni
When systemd is used as the init system, the
BR2_TARGET_GENERIC_GETTY_TERMandBR2_TARGET_GENERIC_GETTY_OPTIONSare completely ignored, which might confuse the user, as reported in bugFor now, let's simply make those options visible only with busybox init and sysv init, as suggested by Yann E. Morin in the discussion of bug #10301.
Quoted 8 lines
Fixes #10301.
Reported-by Michael Heinemann <[email protected]>Suggested-by "Yann E. MORIN" <[email protected]>Signed-off-by Thomas Petazzoni <[email protected]>--- system/Config.in | 4 ++++ 1 file changed, 4 insertions(+)
I've applied, after taking into account the feedback from Yann about the wording of the commit title and commit log.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com