Skip to contentSkip to conversation

drm/prime: Remove duplicate forward declaration

PATCH In review Thierry Reding 3 participants 3 messages Jan 11, 2018 – Jan 12, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/prime: Remove duplicate forward declaration

From: Thierry Reding <[email protected]>

struct device is forward-declared twice. Remove the second instance.

---
 include/drm/drm_prime.h | 2 --
 1 file changed, 2 deletions(-)
include/drm/drm_prime.h +0 -2
index 9cd9e36f77b5..59ccab402e85 100644
@@ -59,8 +59,6 @@ struct drm_device;
 struct drm_gem_object;
 struct drm_file;
 
-struct device;
-
 struct dma_buf *drm_gem_prime_export(struct drm_device *dev,
 				     struct drm_gem_object *obj,
 				     int flags);
Signature · 6 lines
2.15.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Reviewed-by on v1 1/1
#1 lore raw

Quoting Thierry Reding (2018-01-11 20:17:30)

Quoted 3 lines

From: Thierry Reding <[email protected]>

struct device is forward-declared twice. Remove the second instance.

So good they declared it twice. Also the first one first in with the alphabetical ordering.

Quoted 1 line

-Chris
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reviewed-by on v1 1/1
#2 lore raw
In reply to Thierry Reding

Am 11.01.2018 um 21:17 schrieb Thierry Reding:

Quoted 5 lines

From: Thierry Reding <[email protected]>

struct device is forward-declared twice. Remove the second instance.

Quoted 9 lines
---
  include/drm/drm_prime.h | 2 --
  1 file changed, 2 deletions(-)
include/drm/drm_prime.h +0 -0
index 9cd9e36f77b5..59ccab402e85 100644

include/drm/drm_prime.h struct drm_device; · line 64

Quoted 8 lines
include/drm/drm_prime.h +0 -2
@@ -59,8 +59,6 @@ struct drm_device;
  struct drm_gem_object;
  struct drm_file;
 
-struct device;
-
  struct dma_buf *drm_gem_prime_export(struct drm_device *dev,
  				     struct drm_gem_object *obj,
  				     int flags);

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel