nvme: pci: remove unnecessary initialization of local variable

PATCH New Minwoo Im 2 participants 3 messages Jan 14, 2018 – Jan 17, 2018 NVMe

lore

Share & tools

lore

Minwoo Im

author

2018-01-14 11:40 UTC #0 lore raw

PATCH 2/2 nvme: pci: remove unnecessary initialization of local variable

No functional change with code clean-up.
Remove unnecessary initialization of local variable in HMB code.

Signed-off-by Minwoo Im <minwoo.im.dev at gmail.com>

---
 drivers/nvme/host/pci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/nvme/host/pci.c +2 -2

index fb392c5..3abe12c 100644
@@ -1768,7 +1768,7 @@ static int __nvme_alloc_host_mem(struct nvme_dev *dev, u64 preferred,
 	dma_addr_t descs_dma;
 	int i = 0;
 	void **bufs;
-	u64 size = 0, tmp;
+	u64 size, tmp;
 
 	tmp = (preferred + chunk_size - 1);
 	do_div(tmp, chunk_size);

@@ -1851,7 +1851,7 @@ static int nvme_setup_host_mem(struct nvme_dev *dev)
 	u64 preferred = (u64)dev->ctrl.hmpre * SZ_4K;
 	u64 min = (u64)dev->ctrl.hmmin * SZ_4K;
 	u32 enable_bits = NVME_HOST_MEM_ENABLE;
-	int ret = 0;
+	int ret;
 
 	preferred = min(preferred, max);
 	if (min > max) {

Signature · 1 line

2.7.4

Keith Busch

2018-01-15 02:01 UTC #1 lore raw

PATCH 2/2 nvme: pci: remove unnecessary initialization of local variable

Quoted 2 lines · Minwoo Im

No functional change with code clean-up.
Remove unnecessary initialization of local variable in HMB code.

Looks fine.

Reviewed-by Keith Busch <keith.busch at intel.com>

Minwoo Im

author

2018-01-17 13:08 UTC #2 lore raw

PATCH 2/2 nvme: pci: remove unnecessary initialization of local variable

Quoted 7 lines · Keith Busch

Quoted 2 lines · Minwoo Im
No functional change with code clean-up.
Remove unnecessary initialization of local variable in HMB code.
Looks fine.
Reviewed-by Keith Busch <keith.busch at intel.com>

If don't mind, ping ?