Skip to contentSkip to conversation

usb: chipidea: usbmisc: small clean up

RFC New Peter Chen 1 participant 1 message Jan 15, 2018 USB

lore
Share & tools
lore

Peter Chen

author
#0 lore raw

RFC 3/3 usb: chipidea: usbmisc: small clean up

Quoted 16 lines · Michael Trimarchi

The register write can be done outside the if and else condition

Signed-off-by Michael Trimarchi <[email protected]>
---
 drivers/usb/chipidea/usbmisc_imx.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/usb/chipidea/usbmisc_imx.c +0 -1
index 1f47ef6..34ad5bf 100644
@@ -315,13 +315,12 @@ static int usbmisc_imx6q_set_wakeup
 	val = readl(usbmisc->base + data->index * 4);
 	if (enabled) {
 		val |= wakeup_setting;
-		writel(val, usbmisc->base + data->index * 4);

drivers/usb/chipidea/usbmisc_imx.c static int usbmisc_imx6q_set_wakeup · line 326

Quoted 10 lines
drivers/usb/chipidea/usbmisc_imx.c +1 -1
 	} else {
 		if (val & MX6_BM_WAKEUP_INTR)
 			pr_debug("wakeup int at ci_hdrc.%d\n", data->index);
 		val &= ~wakeup_setting;
-		writel(val, usbmisc->base + data->index * 4);
 	}
+	writel(val, usbmisc->base + data->index * 4);
 	spin_unlock_irqrestore(&usbmisc->lock, flags);
 
 	return ret;
Acked-by Peter Chen <[email protected]>