Skip to contentSkip to conversation

wolfssl: fix build on ARMV8

PATCH New Sergio Prado 2 participants 4 messages Jan 15, 2018

lore
Share & tools
lore

Sergio Prado

author
#0 lore raw

PATCH 1/1 wolfssl: fix build on ARMV8

Build on ARMV8 fails when hardware acceleration is enabled:

/tmp/ccmGP5RI.s: Assembler messages:
/tmp/ccmGP5RI.s:532: Error: invalid addressing mode at operand 2 -- ld1 {v0.2d},[x0,256]' /tmp/ccmGP5RI.s:568: Error: invalid addressing mode at operand 2 -- st1 {v0.2d},[x0,256]' /tmp/ccmGP5RI.s:581: Error: invalid addressing mode at operand 2 -- ld1 {v0.2d},[x0,256]' /tmp/ccmGP5RI.s:621: Error: invalid addressing mode at operand 2 -- st1 {v0.2d},[x0,256]'

So let's disable ARMv8 hardware acceleration for now.

Fixes:
http://autobuild.buildroot.net/results/6080648394d09a0d382087831ee6f063c7638be9

Signed-off-by Sergio Prado <[email protected]>
---
 package/wolfssl/wolfssl.mk | 6 ------
 1 file changed, 6 deletions(-)
package/wolfssl/wolfssl.mk +0 -6
index c8ef50a9bc6e..3e661cd26ef4 100644
@@ -29,10 +29,4 @@ else
 WOLFSSL_CONF_OPTS += --disable-sslv3
 endif
 
-ifeq ($(BR2_ARM_CPU_ARMV8A),y)
-WOLFSSL_CONF_OPTS += --enable-armasm
-else
-WOLFSSL_CONF_OPTS += --disable-armasm
-endif
-
 $(eval $(autotools-package))
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 wolfssl: fix build on ARMV8

Hello,

package/wolfssl/wolfssl.mk else · line 36

Quoted 13 lines · Sergio Prado
package/wolfssl/wolfssl.mk +0 -5
index c8ef50a9bc6e..3e661cd26ef4 100644
@@ -29,10 +29,4 @@ else
 WOLFSSL_CONF_OPTS += --disable-sslv3
 endif
 
-ifeq ($(BR2_ARM_CPU_ARMV8A),y)
-WOLFSSL_CONF_OPTS += --enable-armasm
-else
-WOLFSSL_CONF_OPTS += --disable-armasm
-endif

So perhaps --disable-armasm should be passed unconditionally?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
author
#2 lore raw

PATCH 1/1 wolfssl: fix build on ARMV8

Hello,

2018-01-15 8:32 GMT-02:00 Thomas Petazzoni <thomas.petazzoni@free- electrons.com>:

Quoted 12 lines

Hello,

Quoted 8 lines · Sergio Prado
package/wolfssl/wolfssl.mk +0 -0
index c8ef50a9bc6e..3e661cd26ef4 100644
@@ -29,10 +29,4 @@ else
 WOLFSSL_CONF_OPTS += --disable-sslv3
 endif
Quoted 8 lines

package/wolfssl/wolfssl.mk else · line 36

Quoted 5 lines
package/wolfssl/wolfssl.mk +0 -5
-ifeq ($(BR2_ARM_CPU_ARMV8A),y)
-WOLFSSL_CONF_OPTS += --enable-armasm
-else
-WOLFSSL_CONF_OPTS += --disable-armasm
-endif

So perhaps --disable-armasm should be passed unconditionally?

It's disabled by default. Should we still pass it?

Quoted 7 lines

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180115/cae4db5a/attachment.html>

#3 lore raw

PATCH 1/1 wolfssl: fix build on ARMV8

Hello,

Quoted 4 lines · Sergio Prado
Quoted 2 lines

So perhaps --disable-armasm should be passed unconditionally?

It's disabled by default. Should we still pass it?

Well, it's always good practice to be explicit about config options I believe.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com