Skip to contentSkip to conversation

IIO: ADC: stm32-dfsdm: fix static check warning

PATCH New Arnaud Pouliquen 2 participants 2 messages Jan 15, 2018

Subsystems (2)
IIO Arm STM32
lore
Share & tools
lore

Arnaud Pouliquen

author
#0 lore raw

PATCH 1/1 IIO: ADC: stm32-dfsdm: fix static check warning

iio_priv does not return an error pointer, so check is not valid. Patch suppresses it.

Signed-off-by Arnaud Pouliquen <[email protected]>
---
 drivers/iio/adc/stm32-dfsdm-adc.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/iio/adc/stm32-dfsdm-adc.c +0 -4
index f79a90f..5c67236 100644
@@ -1099,10 +1099,6 @@ static int stm32_dfsdm_adc_probe(struct platform_device *pdev)
 	}
 
 	adc = iio_priv(iio);
-	if (IS_ERR(adc)) {
-		dev_err(dev, "%s: Failed to allocate ADC\n", __func__);
-		return PTR_ERR(adc);
-	}
 	adc->dfsdm = dev_get_drvdata(dev->parent);
 
 	iio->dev.parent = dev;
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 IIO: ADC: stm32-dfsdm: fix static check warning

Quoted 4 lines · On Mon, 15 Jan 2018 10:00:26 +0100 Arnaud Pouliquen <[email protected]>…

iio_priv does not return an error pointer, so check is not valid. Patch suppresses it.

Signed-off-by Arnaud Pouliquen <[email protected]>
Acked-by Jonathan Cameron <[email protected]>

If it doesn't make it into Mark's tree pre merge window I'll pick it up after rc1.

Thanks,

Jonathan

Quoted 19 lines
---
 drivers/iio/adc/stm32-dfsdm-adc.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/iio/adc/stm32-dfsdm-adc.c +0 -4
index f79a90f..5c67236 100644
@@ -1099,10 +1099,6 @@ static int stm32_dfsdm_adc_probe(struct platform_device *pdev)
 	}
 
 	adc = iio_priv(iio);
-	if (IS_ERR(adc)) {
-		dev_err(dev, "%s: Failed to allocate ADC\n", __func__);
-		return PTR_ERR(adc);
-	}
 	adc->dfsdm = dev_get_drvdata(dev->parent);
 
 	iio->dev.parent = dev;