Skip to contentSkip to conversation

linux-firmware: fail build for missing file

PATCH New Ricardo Martincoski 4 participants 13 messages Jan 14, 2018 – Jan 15, 2018

lore
Share & tools
lore

Ricardo Martincoski

author
#0 lore raw

PATCH 1/3 linux-firmware: fail build for missing file

When a file is listed to be installed but is missing from the package source currently the first tar command exits with error code but it is ignored and the build succeeds.
This issue by itself is minor because those listed files that are present in the package source get installed to the target. But the code is currently error prone, e.g. to a typo in the file list.

Fix this by first creating a tarball in the build directory and then installing it, instead of using a pipe between the two tar invocations. Also use && between the commands, so the first command that exits with error code fails the build.
Since the two tar invocations remain in use, the desired behavior remains the same:
- list of files can contain *;
- list of files can contain file inside path, and the path is then replicated in the target;
- symlinks are not followed but are installed.

Signed-off-by Ricardo Martincoski <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc Peter Korsgaard <[email protected]>
Cc Peter Seiderer <[email protected]>
Cc Yann E. MORIN <[email protected]>
Cc Yegor Yefremov <[email protected]>

---
Should it go to 2017.11.x and 2017.08.x too? See next patch

---
 package/linux-firmware/linux-firmware.mk | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
package/linux-firmware/linux-firmware.mk +3 -3
index cf79e56..03704d8 100644
@@ -443,9 +443,9 @@ endif
 
 ifneq ($(LINUX_FIRMWARE_FILES),)
 define LINUX_FIRMWARE_INSTALL_FILES
-	cd $(@D) ; \
-	$(TAR) c $(sort $(LINUX_FIRMWARE_FILES)) | \
-		$(TAR) x -C $(TARGET_DIR)/lib/firmware
+	cd $(@D) && \
+		$(TAR) cf install.tar $(sort $(LINUX_FIRMWARE_FILES)) && \
+		$(TAR) xf install.tar -C $(TARGET_DIR)/lib/firmware
 endef
 endif
Signature · 1 line
2.7.4
author
#1 lore raw

PATCH 2/3 linux-firmware: fix install for Chelsio T[45]

It's broken for the last 3 version bumps, since 1c9846ecc9 "linux-firmware: Bump to the latest version"

Fix it by updating the name of the file to install.
Do not use * since it would install also old versions that would take 1MB extra space in the target.

A comment to remember to update the file name when bumping the package is not needed because a previous patch in the series makes the build to fail for missing file.

Signed-off-by Ricardo Martincoski <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc Peter Korsgaard <[email protected]>
Cc Peter Seiderer <[email protected]>
Cc Yann E. MORIN <[email protected]>
Cc Yegor Yefremov <[email protected]>

---
I don't have hardware to run-test the firmware itself.

2017.11.x and 2017.08.x should use t[45]fw-1.16.45.0.bin instead 2017.05.x is OK

---
 package/linux-firmware/linux-firmware.mk | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
package/linux-firmware/linux-firmware.mk +4 -4
index 03704d8..45483a3 100644
@@ -337,14 +337,14 @@ LINUX_FIRMWARE_FILES += bnx2x/*
 endif
 
 ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_CXGB4_T4),y)
-# cxgb4/t4fw.bin is a symlink to cxgb4/t4fw-1.16.26.0.bin
-LINUX_FIRMWARE_FILES += cxgb4/t4fw-1.16.26.0.bin cxgb4/t4fw.bin
+# cxgb4/t4fw.bin is a symlink to cxgb4/t4fw-1.16.63.0.bin
+LINUX_FIRMWARE_FILES += cxgb4/t4fw-1.16.63.0.bin cxgb4/t4fw.bin
 LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENCE.chelsio_firmware
 endif
 
 ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_CXGB4_T5),y)
-# cxgb4/t5fw.bin is a symlink to cxgb4/t5fw-1.16.26.0.bin
-LINUX_FIRMWARE_FILES += cxgb4/t5fw-1.16.26.0.bin cxgb4/t5fw.bin
+# cxgb4/t5fw.bin is a symlink to cxgb4/t5fw-1.16.63.0.bin
+LINUX_FIRMWARE_FILES += cxgb4/t5fw-1.16.63.0.bin cxgb4/t5fw.bin
 LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENCE.chelsio_firmware
 endif
Signature · 1 line
2.7.4
#2 lore raw

PATCH 2/3 linux-firmware: fix install for Chelsio T[45]

Ricardo, All,

On 2018-01-14 21:41 -0200, Ricardo Martincoski spake thusly:

Quoted 6 lines

It's broken for the last 3 version bumps, since 1c9846ecc9 "linux-firmware: Bump to the latest version"

Fix it by updating the name of the file to install.
Do not use * since it would install also old versions that would take 1MB extra space in the target.

I would prefer if we were to keep installing the older version, because presumably older kernel versions (even if they request the unversionned t4fw.bin) would probably have been working with earlier versions of the firmware, so I'd prefer we leave to the user the option to redirect the symlink to the correct version they want to use.

(of course, they'd have to provide a post-build script for that.)

Quoted 10 lines

A comment to remember to update the file name when bumping the package is not needed because a previous patch in the series makes the build to fail for missing file.

Signed-off-by Ricardo Martincoski <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc Peter Korsgaard <[email protected]>
Cc Peter Seiderer <[email protected]>
Cc Yann E. MORIN <[email protected]>
Cc Yegor Yefremov <[email protected]>

But still, this change is technically OK, so:

Reviewed-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 35 lines

---
I don't have hardware to run-test the firmware itself.

2017.11.x and 2017.08.x should use t[45]fw-1.16.45.0.bin instead 2017.05.x is OK

---
 package/linux-firmware/linux-firmware.mk | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
package/linux-firmware/linux-firmware.mk +4 -4
index 03704d8..45483a3 100644
@@ -337,14 +337,14 @@ LINUX_FIRMWARE_FILES += bnx2x/*
 endif
 
 ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_CXGB4_T4),y)
-# cxgb4/t4fw.bin is a symlink to cxgb4/t4fw-1.16.26.0.bin
-LINUX_FIRMWARE_FILES += cxgb4/t4fw-1.16.26.0.bin cxgb4/t4fw.bin
+# cxgb4/t4fw.bin is a symlink to cxgb4/t4fw-1.16.63.0.bin
+LINUX_FIRMWARE_FILES += cxgb4/t4fw-1.16.63.0.bin cxgb4/t4fw.bin
 LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENCE.chelsio_firmware
 endif
 
 ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_CXGB4_T5),y)
-# cxgb4/t5fw.bin is a symlink to cxgb4/t5fw-1.16.26.0.bin
-LINUX_FIRMWARE_FILES += cxgb4/t5fw-1.16.26.0.bin cxgb4/t5fw.bin
+# cxgb4/t5fw.bin is a symlink to cxgb4/t5fw-1.16.63.0.bin
+LINUX_FIRMWARE_FILES += cxgb4/t5fw-1.16.63.0.bin cxgb4/t5fw.bin
 LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENCE.chelsio_firmware
 endif
Signature · 1 line
2.7.4
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#3 lore raw

PATCH 2/3 linux-firmware: fix install for Chelsio T[45]

Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Ricardo, All,
On 2018-01-14 21:41 -0200, Ricardo Martincoski spake thusly:

Quoted 6 lines

It's broken for the last 3 version bumps, since 1c9846ecc9 "linux-firmware: Bump to the latest version"

Fix it by updating the name of the file to install.
Do not use * since it would install also old versions that would take 1MB extra space in the target.

Quoted 5 lines

I would prefer if we were to keep installing the older version, because presumably older kernel versions (even if they request the unversionned t4fw.bin) would probably have been working with earlier versions of the firmware, so I'd prefer we leave to the user the option to redirect the symlink to the correct version they want to use.

That might indeed be nice, but should be done as a separate patch. A nice thing about install t4fw*bin would be that this kind of problems wouldn't happen again.

Will you send a patch?

Signature · 1 line
Bye, Peter Korsgaard
#4 lore raw

PATCH 2/3 linux-firmware: fix install for Chelsio T[45]

Peter, All,

On 2018-01-15 21:10 +0100, Peter Korsgaard spake thusly:

Quoted 17 lines
Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Ricardo, All,
On 2018-01-14 21:41 -0200, Ricardo Martincoski spake thusly:

Quoted 6 lines

It's broken for the last 3 version bumps, since 1c9846ecc9 "linux-firmware: Bump to the latest version"

Fix it by updating the name of the file to install.
Do not use * since it would install also old versions that would take 1MB extra space in the target.

Quoted 5 lines

I would prefer if we were to keep installing the older version, because presumably older kernel versions (even if they request the unversionned t4fw.bin) would probably have been working with earlier versions of the firmware, so I'd prefer we leave to the user the option to redirect the symlink to the correct version they want to use.

Quoted 3 lines

That might indeed be nice, but should be done as a separate patch. A nice thing about install t4fw*bin would be that this kind of problems wouldn't happen again.

Good idea.

Quoted 1 line

Will you send a patch?

In the making now...

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#5 lore raw

PATCH 2/3 linux-firmware: fix install for Chelsio T[45]

In reply to Ricardo Martincoski
Quoted 13 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Ricardo" == Ricardo Martincoski <[email protected]> writes:

It's broken for the last 3 version bumps, since 1c9846ecc9 "linux-firmware: Bump to the latest version"

Fix it by updating the name of the file to install.
Do not use * since it would install also old versions that would take 1MB extra space in the target.

A comment to remember to update the file name when bumping the package is not needed because a previous patch in the series makes the build to fail for missing file.

Quoted 8 lines
Signed-off-by Ricardo Martincoski <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc Peter Korsgaard <[email protected]>
Cc Peter Seiderer <[email protected]>
Cc Yann E. MORIN <[email protected]>
Cc Yegor Yefremov <[email protected]>

---
I don't have hardware to run-test the firmware itself.

Committed, thanks.

Quoted 2 lines

2017.11.x and 2017.08.x should use t[45]fw-1.16.45.0.bin instead 2017.05.x is OK

Thanks. Will you send a patch for 2017.11.x?

Signature · 1 line
Bye, Peter Korsgaard
author
#6 lore raw

PATCH 3/3 armbian-firmware: fail build for missing file

In reply to Ricardo Martincoski

When a file is listed to be installed but is missing from the package source currently the first tar command exits with error code but it is ignored and the build succeeds.
This issue by itself is minor because those listed files that are present in the package source get installed to the target. But the code is currently error prone, e.g. to a typo in the file list.

Fix this by first creating a tarball in the build directory and then installing it, instead of using a pipe between the two tar invocations. Also use && between the commands, so the first command that exits with error code fails the build.
Since the two tar invocations remain in use, the desired behavior remains the same:
- list of files can contain *;
- list of files can contain file inside path, and the path is then replicated in the target;
- symlinks are not followed but are installed.

Signed-off-by Ricardo Martincoski <[email protected]>
Cc Sergey Matyukevich <[email protected]>

---
This package copied the install commands from linux-firmware. So let's copy the fix and also the commit log.

---
 package/armbian-firmware/armbian-firmware.mk | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
package/armbian-firmware/armbian-firmware.mk +3 -3
index 48b0372..77e5185 100644
@@ -23,9 +23,9 @@ endif
 
 ifneq ($(ARMBIAN_FIRMWARE_FILES),)
 define ARMBIAN_FIRMWARE_INSTALL_FILES
-	cd $(@D) ; \
-	$(TAR) c $(sort $(ARMBIAN_FIRMWARE_FILES)) | \
-		$(TAR) x -C $(TARGET_DIR)/lib/firmware
+	cd $(@D) && \
+		$(TAR) cf install.tar $(sort $(ARMBIAN_FIRMWARE_FILES)) && \
+		$(TAR) xf install.tar -C $(TARGET_DIR)/lib/firmware
 endef
 endif
Signature · 1 line
2.7.4
#7 lore raw

PATCH 3/3 armbian-firmware: fail build for missing file

Ricardo, All,

I gues you wanted to Cc me on the first patch in the series, related to linux-firmware, not armbian-firmware, right? ;-)

On 2018-01-14 21:41 -0200, Ricardo Martincoski spake thusly:

Quoted 18 lines

When a file is listed to be installed but is missing from the package source currently the first tar command exits with error code but it is ignored and the build succeeds.
This issue by itself is minor because those listed files that are present in the package source get installed to the target. But the code is currently error prone, e.g. to a typo in the file list.

Fix this by first creating a tarball in the build directory and then installing it, instead of using a pipe between the two tar invocations. Also use && between the commands, so the first command that exits with error code fails the build.
Since the two tar invocations remain in use, the desired behavior remains the same:
- list of files can contain *;
- list of files can contain file inside path, and the path is then replicated in the target;
- symlinks are not followed but are installed.

Quoted 2 lines
Signed-off-by Ricardo Martincoski <[email protected]>
Cc Sergey Matyukevich <[email protected]>
Acked-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 27 lines

---
This package copied the install commands from linux-firmware. So let's copy the fix and also the commit log.

---
 package/armbian-firmware/armbian-firmware.mk | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
package/armbian-firmware/armbian-firmware.mk +3 -3
index 48b0372..77e5185 100644
@@ -23,9 +23,9 @@ endif
 
 ifneq ($(ARMBIAN_FIRMWARE_FILES),)
 define ARMBIAN_FIRMWARE_INSTALL_FILES
-	cd $(@D) ; \
-	$(TAR) c $(sort $(ARMBIAN_FIRMWARE_FILES)) | \
-		$(TAR) x -C $(TARGET_DIR)/lib/firmware
+	cd $(@D) && \
+		$(TAR) cf install.tar $(sort $(ARMBIAN_FIRMWARE_FILES)) && \
+		$(TAR) xf install.tar -C $(TARGET_DIR)/lib/firmware
 endef
 endif
Signature · 1 line
2.7.4
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#8 lore raw

PATCH 3/3 armbian-firmware: fail build for missing file

----- Original Message -----
From: "Yann E. MORIN" <[email protected]>
To: "ricardo martincoski" <[email protected]>
Cc: "Sergey Matyukevich" <[email protected]>, buildroot at buildroot.org
Sent: Monday, January 15, 2018 2:53:37 PM
Subject: Re: [Buildroot] [PATCH 3/3] armbian-firmware: fail build for missing file

Ricardo, All,

I gues you wanted to Cc me on the first patch in the series, related to linux-firmware, not armbian-firmware, right? ;-)

Sure.
I first added you explicitly only for patches 1 and 2. Then I ran get-developers again for all patches, copy&paste and send using git.?

On 2018-01-14 21:41 -0200, Ricardo Martincoski spake thusly:

Quoted 18 lines

When a file is listed to be installed but is missing from the package source currently the first tar command exits with error code but it is ignored and the build succeeds.
This issue by itself is minor because those listed files that are present in the package source get installed to the target. But the code is currently error prone, e.g. to a typo in the file list.

Fix this by first creating a tarball in the build directory and then installing it, instead of using a pipe between the two tar invocations. Also use && between the commands, so the first command that exits with error code fails the build.
Since the two tar invocations remain in use, the desired behavior remains the same:
- list of files can contain *;
- list of files can contain file inside path, and the path is then replicated in the target;
- symlinks are not followed but are installed.

Quoted 2 lines
Signed-off-by Ricardo Martincoski <[email protected]>
Cc Sergey Matyukevich <[email protected]>
Acked-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 27 lines

---
This package copied the install commands from linux-firmware. So let's copy the fix and also the commit log.

---
 package/armbian-firmware/armbian-firmware.mk | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
package/armbian-firmware/armbian-firmware.mk +3 -3
index 48b0372..77e5185 100644
@@ -23,9 +23,9 @@ endif
 
 ifneq ($(ARMBIAN_FIRMWARE_FILES),)
 define ARMBIAN_FIRMWARE_INSTALL_FILES
-	cd $(@D) ; \
-	$(TAR) c $(sort $(ARMBIAN_FIRMWARE_FILES)) | \
-		$(TAR) x -C $(TARGET_DIR)/lib/firmware
+	cd $(@D) && \
+		$(TAR) cf install.tar $(sort $(ARMBIAN_FIRMWARE_FILES)) && \
+		$(TAR) xf install.tar -C $(TARGET_DIR)/lib/firmware
 endef
 endif
Signature · 1 line
2.7.4
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
#9 lore raw

PATCH 3/3 armbian-firmware: fail build for missing file

Hello,

Here is the response properly formatted. I clicked a few wrong buttons.

Quoted 4 lines

Ricardo, All,

I gues you wanted to Cc me on the first patch in the series, related to linux-firmware, not armbian-firmware, right? ;-)

Sure. I first added you explicitly only for patches 1 and 2. Then I ran get-developers again for all patches, copy&paste and sent using git sendmail. So I end up adding up you for all patches. Sorry.

Regards,
Ricardo

#10 lore raw

PATCH 3/3 armbian-firmware: fail build for missing file

In reply to Ricardo Martincoski
Quoted 20 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Ricardo" == Ricardo Martincoski <[email protected]> writes:

When a file is listed to be installed but is missing from the package source currently the first tar command exits with error code but it is ignored and the build succeeds.
This issue by itself is minor because those listed files that are present in the package source get installed to the target. But the code is currently error prone, e.g. to a typo in the file list.

Fix this by first creating a tarball in the build directory and then installing it, instead of using a pipe between the two tar invocations. Also use && between the commands, so the first command that exits with error code fails the build.
Since the two tar invocations remain in use, the desired behavior remains the same:
- list of files can contain *;
- list of files can contain file inside path, and the path is then replicated in the target;
- symlinks are not followed but are installed.

Quoted 5 lines
Signed-off-by Ricardo Martincoski <[email protected]>
Cc Sergey Matyukevich <[email protected]>

---
This package copied the install commands from linux-firmware. So let's copy the fix and also the commit log.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#11 lore raw

PATCH 1/3 linux-firmware: fail build for missing file

In reply to Ricardo Martincoski

Ricardo, all,

On 2018-01-14 21:41 -0200, Ricardo Martincoski spake thusly:

Quoted 18 lines

When a file is listed to be installed but is missing from the package source currently the first tar command exits with error code but it is ignored and the build succeeds.
This issue by itself is minor because those listed files that are present in the package source get installed to the target. But the code is currently error prone, e.g. to a typo in the file list.

Fix this by first creating a tarball in the build directory and then installing it, instead of using a pipe between the two tar invocations. Also use && between the commands, so the first command that exits with error code fails the build.
Since the two tar invocations remain in use, the desired behavior remains the same:
- list of files can contain *;
- list of files can contain file inside path, and the path is then replicated in the target;
- symlinks are not followed but are installed.

Quoted 6 lines
Signed-off-by Ricardo Martincoski <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc Peter Korsgaard <[email protected]>
Cc Peter Seiderer <[email protected]>
Cc Yann E. MORIN <[email protected]>
Cc Yegor Yefremov <[email protected]>

Bizarely enough I am in Cc of this patch, but I did not receive it directly... Anyway...

I was about to do a very similar change, so let's go with yours:

Acked-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 30 lines

---
Should it go to 2017.11.x and 2017.08.x too? See next patch

---
 package/linux-firmware/linux-firmware.mk | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
package/linux-firmware/linux-firmware.mk +3 -3
index cf79e56..03704d8 100644
@@ -443,9 +443,9 @@ endif
 
 ifneq ($(LINUX_FIRMWARE_FILES),)
 define LINUX_FIRMWARE_INSTALL_FILES
-	cd $(@D) ; \
-	$(TAR) c $(sort $(LINUX_FIRMWARE_FILES)) | \
-		$(TAR) x -C $(TARGET_DIR)/lib/firmware
+	cd $(@D) && \
+		$(TAR) cf install.tar $(sort $(LINUX_FIRMWARE_FILES)) && \
+		$(TAR) xf install.tar -C $(TARGET_DIR)/lib/firmware
 endef
 endif
Signature · 6 lines
2.7.4

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#12 lore raw

PATCH 1/3 linux-firmware: fail build for missing file

In reply to Ricardo Martincoski
Quoted 20 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Ricardo" == Ricardo Martincoski <[email protected]> writes:

When a file is listed to be installed but is missing from the package source currently the first tar command exits with error code but it is ignored and the build succeeds.
This issue by itself is minor because those listed files that are present in the package source get installed to the target. But the code is currently error prone, e.g. to a typo in the file list.

Fix this by first creating a tarball in the build directory and then installing it, instead of using a pipe between the two tar invocations. Also use && between the commands, so the first command that exits with error code fails the build.
Since the two tar invocations remain in use, the desired behavior remains the same:
- list of files can contain *;
- list of files can contain file inside path, and the path is then replicated in the target;
- symlinks are not followed but are installed.

Quoted 8 lines
Signed-off-by Ricardo Martincoski <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc Peter Korsgaard <[email protected]>
Cc Peter Seiderer <[email protected]>
Cc Yann E. MORIN <[email protected]>
Cc Yegor Yefremov <[email protected]>

---
Should it go to 2017.11.x and 2017.08.x too? See next patch

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard