Skip to contentSkip to conversation

video: udlfb: Constify read only data

PATCH In review Ladislav Michl 2 participants 2 messages Jan 15, 2018 – Jan 16, 2018

Subsystems (2)
Framebuffer layer Displaylink USB 2.0 framebuffer driver (udlfb)
lore
Share & tools
lore

Ladislav Michl

author
#0 lore raw

PATCH 1/2 video: udlfb: Constify read only data

Both dlfb_fix and fb_device_attrs are never written to, so it is safe to make them const.

Signed-off-by Ladislav Michl <[email protected]>
---
 drivers/video/fbdev/udlfb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/video/fbdev/udlfb.c +2 -2
index 47e31668f316..f0118c10b4ab 100644
@@ -32,7 +32,7 @@
 #include <video/udlfb.h>
 #include "edid.h"
 
-static struct fb_fix_screeninfo dlfb_fix = {
+static const struct fb_fix_screeninfo dlfb_fix = {
 	.id =           "udlfb",
 	.type =         FB_TYPE_PACKED_PIXELS,
 	.visual =       FB_VISUAL_TRUECOLOR,

@@ -1455,7 +1455,7 @@ static const struct bin_attribute edid_attr = {
 	.write = edid_store
 };
 
-static struct device_attribute fb_device_attrs[] = {
+static const struct device_attribute fb_device_attrs[] = {
 	__ATTR_RO(metrics_bytes_rendered),
 	__ATTR_RO(metrics_bytes_identical),
 	__ATTR_RO(metrics_bytes_sent),
Signature · 1 line
2.15.1
#1 lore raw
Quoted 4 lines · Ladislav Michl

Both dlfb_fix and fb_device_attrs are never written to, so it is safe to make them const.

Signed-off-by Ladislav Michl <[email protected]>

Patch queued for 4.16, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics