Skip to contentSkip to conversation

ALSA: pcm: Fix trailing semicolon

PATCH Superseded Luis de Bethencourt 2 participants 3 messages Jan 15, 2018 – Jan 16, 2018 Sound

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: pcm: Fix trailing semicolon

From: Ubuntu <[email protected]>

The trailing semicolon is an empty statement that does no operation. Removing it since it doesn't do anything.

---

Hi,

After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches suggested I fix it treewide [0].

Best regards
Luis

[0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
[1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html

 sound/core/pcm_native.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/core/pcm_native.c +1 -1
index 3f13e8da0812..51104df924e1 100644
@@ -3446,7 +3446,7 @@ EXPORT_SYMBOL_GPL(snd_pcm_lib_default_mmap);
 int snd_pcm_lib_mmap_iomem(struct snd_pcm_substream *substream,
 			   struct vm_area_struct *area)
 {
-	struct snd_pcm_runtime *runtime = substream->runtime;;
+	struct snd_pcm_runtime *runtime = substream->runtime;
 
 	area->vm_page_prot = pgprot_noncached(area->vm_page_prot);
 	return vm_iomap_memory(area, runtime->dma_addr, runtime->dma_bytes);
Signature · 1 line
2.15.1
#1 lore raw
Quoted 2 lines · Luis de Bethencourt

From: Ubuntu <[email protected]>

Is this from address intentional? It'd be taken as is via git-am.

thanks,

Takashi

Quoted 39 lines

The trailing semicolon is an empty statement that does no operation. Removing it since it doesn't do anything.

---

Hi,

After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches suggested I fix it treewide [0].

Best regards
Luis

[0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
[1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html

 sound/core/pcm_native.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/core/pcm_native.c +1 -1
index 3f13e8da0812..51104df924e1 100644
@@ -3446,7 +3446,7 @@ EXPORT_SYMBOL_GPL(snd_pcm_lib_default_mmap);
 int snd_pcm_lib_mmap_iomem(struct snd_pcm_substream *substream,
 			   struct vm_area_struct *area)
 {
-	struct snd_pcm_runtime *runtime = substream->runtime;;
+	struct snd_pcm_runtime *runtime = substream->runtime;
 
 	area->vm_page_prot = pgprot_noncached(area->vm_page_prot);
 	return vm_iomap_memory(area, runtime->dma_addr, runtime->dma_bytes);
Signature · 1 line
2.15.1
#2 lore raw
Quoted 45 lines · Takashi Iwai
Quoted 2 lines · Luis de Bethencourt

From: Ubuntu <[email protected]>

Is this from address intentional? It'd be taken as is via git-am.

thanks,

Takashi

Quoted 33 lines

The trailing semicolon is an empty statement that does no operation. Removing it since it doesn't do anything.

---

Hi,

After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches suggested I fix it treewide [0].

Best regards
Luis

[0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
[1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html

 sound/core/pcm_native.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/core/pcm_native.c +1 -1
index 3f13e8da0812..51104df924e1 100644
@@ -3446,7 +3446,7 @@ EXPORT_SYMBOL_GPL(snd_pcm_lib_default_mmap);
 int snd_pcm_lib_mmap_iomem(struct snd_pcm_substream *substream,
 			   struct vm_area_struct *area)
 {
-	struct snd_pcm_runtime *runtime = substream->runtime;;
+	struct snd_pcm_runtime *runtime = substream->runtime;
 
Quoted 6 lines
Quoted 6 lines
sound/core/pcm_native.c +0 -0
 	area->vm_page_prot = pgprot_noncached(area->vm_page_prot);
 	return vm_iomap_memory(area, runtime->dma_addr, runtime->dma_bytes);
Signature · 1 line
2.15.1

Hi Takashi,

Sorry. Not sure how git send-email added that line to the commit message. I have sent a v2 correcting it.

Thanks,
Luis