soc: xilinx: xlnx_vcu: Use bitwise & rather than logical && on clkoutdiv
PATCH 1/1 soc: xilinx: xlnx_vcu: Use bitwise & rather than logical && on clkoutdiv
Currently clkoutdiv is being operated on by a logical && operator rather than a bitwise & operator. This looks incorrect as these should be bit flag operations.
Addresses-Coverity-ID: 1463959 ("Logical vs. bitwise operator")
--- drivers/soc/xilinx/xlnx_vcu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/soc/xilinx/xlnx_vcu.c +1 -1
@@ -334,7 +334,7 @@ static int xvcu_set_vcu_pll_info(struct xvcu_device *xvcu)*/ vcu_pll_ctrl =xvcu_read (xvcu->vcu_slcr_ba,VCU_PLL_CTRL ); clkoutdiv = vcu_pll_ctrl >>VCU_PLL_CTRL_CLKOUTDIV_SHIFT ; - clkoutdiv = clkoutdiv &&VCU_PLL_CTRL_CLKOUTDIV_MASK ; + clkoutdiv = clkoutdiv &VCU_PLL_CTRL_CLKOUTDIV_MASK ;if (clkoutdiv !=1 ) {dev_err (xvcu->dev,"clkoutdiv value is invalid\n" );return -EINVAL ;
Signature · 1 line
2.7.4
Hi,
Quoted 34 lines
-----Original Message-----
From: Gustavo A. R. Silva [mailto:[email protected]]
Sent: Monday, January 15, 2018 11:15 AM
To: Michal Simek <[email protected]>; Dhaval Rajeshbhai Shah <[email protected]>
Cc: [email protected]; [email protected]; Gustavo A. R. Silva <[email protected]>
Subject: [PATCH] soc: xilinx:xlnx_vcu: Use bitwise & rather than logical && on clkoutdivCurrently clkoutdiv is being operated on by a logical && operator rather than a bitwise & operator. This looks incorrect as these should be bit flag operations.
Addresses-Coverity-ID: 1463959 ("Logical vs. bitwise operator")
Fixes cee8113a295a ("soc: xilinx: xlnx_vcu: Add Xilinx ZYNQMP VCU logicoreIPinit driver")
Signed-off-by Gustavo A. R. Silva <[email protected]>--- drivers/soc/xilinx/xlnx_vcu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/soc/xilinx/xlnx_vcu.c index renamed from drivers/soc/xilinx/xlnx_vcu.c +0
-0c1d6f1b..a840c02 100644
drivers/soc/xilinx/xlnx_vcu.c +1
-1@@ -334,7 +334,7 @@ static int xvcu_set_vcu_pll_info(struct xvcu_device*xvcu) */ vcu_pll_ctrl =xvcu_read (xvcu->vcu_slcr_ba,VCU_PLL_CTRL ); clkoutdiv = vcu_pll_ctrl >>VCU_PLL_CTRL_CLKOUTDIV_SHIFT ; - clkoutdiv = clkoutdiv &&VCU_PLL_CTRL_CLKOUTDIV_MASK ; + clkoutdiv = clkoutdiv &VCU_PLL_CTRL_CLKOUTDIV_MASK ;if (clkoutdiv !=1 ) {dev_err (xvcu->dev,"clkoutdiv value is invalid\n" );
Quoted 3 lines
return
-EINVAL;
--
2.7.4
Thanks & Regards,
Dhaval
Michal Simek
AppliedQuoted 33 lines · Dhaval Rajeshbhai Shah
Hi,
Quoted 31 lines
-----Original Message-----
From: Gustavo A. R. Silva [mailto:[email protected]]
Sent: Monday, January 15, 2018 11:15 AM
To: Michal Simek <[email protected]>; Dhaval Rajeshbhai Shah <[email protected]>
Cc: [email protected]; [email protected]; Gustavo A. R. Silva <[email protected]>
Subject: [PATCH] soc: xilinx:xlnx_vcu: Use bitwise & rather than logical && on clkoutdivCurrently clkoutdiv is being operated on by a logical && operator rather than a bitwise & operator. This looks incorrect as these should be bit flag operations.
Addresses-Coverity-ID: 1463959 ("Logical vs. bitwise operator")
Fixes cee8113a295a ("soc: xilinx: xlnx_vcu: Add Xilinx ZYNQMP VCU logicoreIPinit driver")
Signed-off-by Gustavo A. R. Silva <[email protected]>--- drivers/soc/xilinx/xlnx_vcu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/soc/xilinx/xlnx_vcu.c index renamed from drivers/soc/xilinx/xlnx_vcu.c +0
-0c1d6f1b..a840c02 100644
drivers/soc/xilinx/xlnx_vcu.c +0
-1@@ -334,7 +334,7 @@ static int xvcu_set_vcu_pll_info(struct xvcu_device*xvcu) */ vcu_pll_ctrl =xvcu_read (xvcu->vcu_slcr_ba,VCU_PLL_CTRL ); clkoutdiv = vcu_pll_ctrl >>VCU_PLL_CTRL_CLKOUTDIV_SHIFT ; -clkoutdiv = clkoutdiv &&VCU_PLL_CTRL_CLKOUTDIV_MASK ;
Quoted 8 lines
Quoted 6 lines
drivers/soc/xilinx/xlnx_vcu.c +1
-0+clkoutdiv = clkoutdiv &VCU_PLL_CTRL_CLKOUTDIV_MASK ;if (clkoutdiv !=1 ) {dev_err (xvcu->dev,"clkoutdiv value is invalid\n" );return
-EINVAL;
--
2.7.4Acked-by Dhaval Shah <[email protected]>
Applied.
Thanks,
Michal
Quoting Michal Simek <[email protected]>:
Quoted 43 lines · Dhaval Rajeshbhai Shah
Quoted 33 lines
Hi,
Quoted 31 lines
-----Original Message-----
From: Gustavo A. R. Silva [mailto:[email protected]]
Sent: Monday, January 15, 2018 11:15 AM
To: Michal Simek <[email protected]>; Dhaval Rajeshbhai Shah <[email protected]>
Cc: [email protected]; [email protected]; Gustavo A. R. Silva <[email protected]>
Subject: [PATCH] soc: xilinx:xlnx_vcu: Use bitwise & rather than logical && on clkoutdivCurrently clkoutdiv is being operated on by a logical && operator rather than a bitwise & operator. This looks incorrect as these should be bit flag operations.
Addresses-Coverity-ID: 1463959 ("Logical vs. bitwise operator")
Fixes cee8113a295a ("soc: xilinx: xlnx_vcu: Add Xilinx ZYNQMP VCU logicoreIPinit driver")
Signed-off-by Gustavo A. R. Silva <[email protected]>--- drivers/soc/xilinx/xlnx_vcu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/soc/xilinx/xlnx_vcu.c index renamed from drivers/soc/xilinx/xlnx_vcu.c +0
-0c1d6f1b..a840c02 100644
drivers/soc/xilinx/xlnx_vcu.c +0
-1@@ -334,7 +334,7 @@ static int xvcu_set_vcu_pll_info(struct xvcu_device*xvcu) */ vcu_pll_ctrl =xvcu_read (xvcu->vcu_slcr_ba,VCU_PLL_CTRL ); clkoutdiv = vcu_pll_ctrl >>VCU_PLL_CTRL_CLKOUTDIV_SHIFT ; -clkoutdiv = clkoutdiv &&VCU_PLL_CTRL_CLKOUTDIV_MASK ;Quoted 8 lines
Quoted 6 lines
drivers/soc/xilinx/xlnx_vcu.c +1
-0+clkoutdiv = clkoutdiv &VCU_PLL_CTRL_CLKOUTDIV_MASK ;if (clkoutdiv !=1 ) {dev_err (xvcu->dev,"clkoutdiv value is invalid\n" );return
-EINVAL;
--
2.7.4Acked-by Dhaval Shah <[email protected]>
Quoted 4 lines
Applied.
Thanks,
Michal
Thank you guys.
--
Gustavo