aoetools: new package
PATCH 1/1 aoetools: new package
The aoetools are programs for users of the ATA over Ethernet (AoE) network storage protocol, a simple protocol for using storage over an ethernet LAN.
Tested on Beaglebone Black.
Build tested with test-pkg.
--- DEVELOPERS | 1 + package/Config.in | 1 + package/aoetools/Config.in | 12 ++++++++++++ package/aoetools/aoetools.hash | 5 +++++ package/aoetools/aoetools.mk | 22 ++++++++++++++++++++++ 5 files changed, 41 insertions(+) create mode 100644 package/aoetools/Config.in create mode 100644 package/aoetools/aoetools.hash create mode 100644 package/aoetools/aoetools.mk
DEVELOPERS +1 -0
@@ -1583,6 +1583,7 @@ F: package/rtl8189fs/ F: package/xr819-xradio/ N: Sergio Prado <[email protected]> +F: package/aoetools/ F: package/curlpp/ F: package/daq/ F: package/libgdiplus/
package/Config.in +1 -0
@@ -1615,6 +1615,7 @@ endmenu menu "Networking applications" source "package/aircrack-ng/Config.in" + source "package/aoetools/Config.in" source "package/apache/Config.in" source "package/argus/Config.in" source "package/arp-scan/Config.in"
package/aoetools/Config.in new file +12 -0
@@ -0,0 +1,12 @@ +config BR2_PACKAGE_AOETOOLS + depends on BR2_TOOLCHAIN_HAS_THREADS + bool "aoetools" + help + The aoetools are programs for users of the ATA over Ethernet (AoE) + network storage protocol, a simple protocol for using storage over + an ethernet LAN. + + http://aoetools.sourceforge.net/ + +comment "aoetools needs a toolchain w/ threads" + depends on !BR2_TOOLCHAIN_HAS_THREADS
package/aoetools/aoetools.hash new file +5 -0
@@ -0,0 +1,5 @@ +# Locally computed: +sha256 477e796f5c18e8c0e61b5d88e1759c68249e8e0210c2f3de2b98680e2cc63e32 aoetools-37.tar.gz + +# Hash for license files: +sha256 32b1062f7da84967e7019d01ab805935caa7ab7321a7ced0e30ebe75e5df1670 COPYING
package/aoetools/aoetools.mk new file +22 -0
@@ -0,0 +1,22 @@ +################################################################################ +# +# aoetools +# +################################################################################ + +AOETOOLS_VERSION = 37 +AOETOOLS_SITE = https://github.com/OpenAoE/aoetools/archive + +AOETOOLS_LICENSE = GPLv2 +AOETOOLS_LICENSE_FILES = COPYING + +define AOETOOLS_BUILD_CMDS + $(TARGET_MAKE_ENV) $(MAKE) CC=$(TARGET_CC) -C $(@D) +endef + +define AOETOOLS_INSTALL_TARGET_CMDS + $(TARGET_MAKE_ENV) $(MAKE) DESTDIR=$(TARGET_DIR) \ + -C $(@D) install +endef + +$(eval $(generic-package))
Signature · 1 line
1.9.1
PATCH 1/1 aoetools: new package
Hello,
Quoted 9 lines · Sergio Prado
The aoetools are programs for users of the ATA over Ethernet (AoE) network storage protocol, a simple protocol for using storage over an ethernet LAN.
Tested on Beaglebone Black.
Build tested with test-pkg.
Signed-off-by Sergio Prado <[email protected]>
I've applied, but after fixing a number of issues, see below.
package/aoetools/Config.in line 3
Quoted 9 lines
package/aoetools/Config.in new file +3
-0@@ -0,0 +1,12 @@ +config BR2_PACKAGE_AOETOOLS + depends on BR2_TOOLCHAIN_HAS_THREADS + bool "aoetools"
The bool property goes before the depends on. This is reported by check-package.
package/aoetools/Config.in line 7
Quoted 4 lines
package/aoetools/Config.in new file +4
-0+ help + The aoetools are programs for users of the ATA over Ethernet (AoE) + network storage protocol, a simple protocol for using storage over + an ethernet LAN.
The lines here are too long. This is also reported by check-package.
Quoted 6 lines
package/aoetools/aoetools.mk new file +0
-0
package/aoetools/aoetools.mk line 8
Quoted 8 lines
package/aoetools/aoetools.mk new file +8
-0@@ -0,0 +1,22 @@ +################################################################################ +# +# aoetools +# +################################################################################ + +AOETOOLS_VERSION = 37 +AOETOOLS_SITE = https://github.com/OpenAoE/aoetools/archive
You should have used the github helper here, since there is no tarball uploaded by the maintainer.
package/aoetools/aoetools.mk line 10
Quoted 1 line
package/aoetools/aoetools.mk new file +1
-0+AOETOOLS_LICENSE = GPLv2
This should have been GPL-2.0, which is the SPDX license code for the GPLv2.
package/aoetools/aoetools.mk line 14
Quoted 4 lines
package/aoetools/aoetools.mk new file +4
-0+AOETOOLS_LICENSE_FILES = COPYING + +define AOETOOLS_BUILD_CMDS + $(TARGET_MAKE_ENV) $(MAKE) CC=$(TARGET_CC) -C $(@D)
And here, I've changed to use $(TARGET_CONFIGURE_OPTS) instead of just CC, so that the CFLAGS are properly passed/used.
One thing I didn't fix is that the aoe-stat script installed by this package uses /bin/bash in its shebang, so it won't work because this package doesn't depend on bash. Does this script really needs bash? Should we remove it in a post-install target hook? Something else?
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
PATCH 1/1 aoetools: new package
Hi Thomas,
Thanks for reviewing/applying the patch.
Quoted 6 lines
package/aoetools/Config.in line 3
Quoted 3 lines
package/aoetools/Config.in new file +3
-0+config BR2_PACKAGE_AOETOOLS + depends on BR2_TOOLCHAIN_HAS_THREADS + bool "aoetools"The bool property goes before the depends on. This is reported by check-package.
My mistake. I should definitely have run check-package.
Quoted 2 lines
Review
Quoted 2 lines
(quoted diff) +2
-0+ help + The aoetools are programs for users of the ATA over Ethernet
(AoE)
Quoted 1 line
Quoted 1 line
+ network storage protocol, a simple protocol for using storage
over
Quoted 3 lines
Quoted 1 line
+ an ethernet LAN.
The lines here are too long. This is also reported by check-package.
Yep. I'll make sure to always run check-package in the next contributions.
Quoted 5 lines
package/aoetools/aoetools.mk line 8
Quoted 2 lines
package/aoetools/aoetools.mk new file +2
-0+AOETOOLS_VERSION = 37 +AOETOOLS_SITE = https://github.com/OpenAoE/aoetools/archiveYou should have used the github helper here, since there is no tarball uploaded by the maintainer.
So the tarballs in https://github.com/OpenAoE/aoetools/releases was not uploaded by the developer? It was generated automatically by GitHub? How to know that?
Quoted 4 lines
Quoted 1 line
+AOETOOLS_LICENSE = GPLv2
This should have been GPL-2.0, which is the SPDX license code for the GPLv2.
Right.
Quoted 7 lines
package/aoetools/aoetools.mk line 14
Quoted 4 lines
package/aoetools/aoetools.mk new file +4
-0+AOETOOLS_LICENSE_FILES = COPYING + +define AOETOOLS_BUILD_CMDS + $(TARGET_MAKE_ENV) $(MAKE) CC=$(TARGET_CC) -C $(@D)And here, I've changed to use $(TARGET_CONFIGURE_OPTS) instead of just CC, so that the CFLAGS are properly passed/used.
OK.
Quoted 4 lines
One thing I didn't fix is that the aoe-stat script installed by this package uses
/bin/bashin its shebang, so it won't work because this package doesn't depend on bash. Does this script really needs bash? Should we remove it in a post-install target hook? Something else?
It does not seem to need specifically /bin/bash. I'll propose a change to /bin/sh to the developer. If I did not get any response in the next weeks, I'll remove it with a post-install target hook.
Best regards,
Sergio Prado
Embedded Labworks
Quoted 8 lines
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180116/718c12a8/attachment.html>