Add a new package udftools, third time is the charm
PATCH 1/1 Add a new package udftools, third time is the charm
---
Try 2: fix stupid copy paste error in Config.in
Try 3: remove duplicate/misplaced addition to master Config.in I wish I could see these issues when I first look the patch over - sigh
package/Config.in | 1 +
package/udftools/Config.in | 13 +++++++++++++ package/udftools/udftools.hash | 2 ++ package/udftools/udftools.mk | 13 +++++++++++++ 4 files changed, 29 insertions(+) create mode 100644 package/udftools/Config.in create mode 100644 package/udftools/udftools.hash create mode 100644 package/udftools/udftools.mk
package/Config.in +1 -0
@@ -196,6 +196,7 @@ menu "Filesystem and flash utilities" source "package/squashfs/Config.in" source "package/sshfs/Config.in" source "package/sunxi-tools/Config.in" + source "package/udftools/Config.in" source "package/unionfs/Config.in" source "package/xfsprogs/Config.in" endmenu
package/udftools/Config.in new file +13 -0
@@ -0,0 +1,13 @@ +config BR2_PACKAGE_UDFTOOLS + bool "udftools" + depends on BR2_PACKAGE_READLINE + help + Tools for creating UDF filesystems + Maintained fork of the 2004 Sourcforge package + + https://github.com/pali/udftools/releases/tag/2.0 + +comment "udftools needs a toolchain w/ wchar" + depends on !BR2_USE_WCHAR + +
package/udftools/udftools.hash new file +2 -0
@@ -0,0 +1,2 @@ +# Locally computed +sha256 67fe428d452901215cfad8049d250540c97114b1a20dd63277b91c2c4fae8292 udftools-2.0.tar.gz
package/udftools/udftools.mk new file +13 -0
@@ -0,0 +1,13 @@ +################################################################################ +# +# udftools +# +################################################################################ + +UDFTOOLS_VERSION = 2.0 +UDFTOOLS_SITE = https://github.com/pali/udftools/releases/download/$(UDFTOOLS_VERSION) +UDFTOOLS_LICENSE = GPL-2.0 +UDFTOOLS_LICENSE_FILES = COPYING + +$(eval $(autotools-package)) +
Signature · 1 line
2.9.0.137.gcf4c2cf
PATCH 1/1 Add a new package udftools, third time is the charm
Hello,
Thanks for your contribution! There are a few issues in your submission that need to be fixed however.
First, the commit title should be just "udftools: new package". We don't want your "third time is the charm" message to become part of Buildroot Git history forever :-)
Quoted 5 lines · Steve Kenton
Signed-off-by Steve Kenton <[email protected]>---
Try 2: fix stupid copy paste error in Config.in
Try 3: remove duplicate/misplaced addition to master Config.in I wish I could see these issues when I first look the patch over - sigh
This changelog is good, and is the right place for such information.
Quoted 5 lines
package/Config.in | 1 +
package/udftools/Config.in | 13 +++++++++++++ package/udftools/udftools.hash | 2 ++ package/udftools/udftools.mk | 13 +++++++++++++
Please add an entry to the DEVELOPERS file for this package.
package/udftools/Config.in line 3
Quoted 9 lines
package/udftools/Config.in new file +3
-0@@ -0,0 +1,13 @@ +config BR2_PACKAGE_UDFTOOLS + bool "udftools" + depends on BR2_PACKAGE_READLINE
Should be a select, not a depends on.
package/udftools/Config.in line 8
Quoted 5 lines
package/udftools/Config.in new file +5
-0+ help + Tools for creating UDF filesystems + Maintained fork of the 2004 Sourcforge package + + https://github.com/pali/udftools/releases/tag/2.0
Please use the main site, not the specific 2.0 page.
package/udftools/Config.in line 11
Quoted 3 lines
package/udftools/Config.in new file +3
-0+ +comment "udftools needs a toolchain w/ wchar" + depends on !BR2_USE_WCHAR
If it depends on wchar, then you should have a "depends on BR2_USE_WCHAR" for the main BR2_PACKAGE_UDFTOOLS option.
package/udftools/Config.in line 2
Quoted 3 lines
package/udftools/Config.in new file +2
-0@@ -0,0 +1,2 @@ +# Locally computed +sha256 67fe428d452901215cfad8049d250540c97114b1a20dd63277b91c2c4fae8292 udftools-2.0.tar.gz
Adding the hash for the license file would be good.
Quoted 6 lines
package/udftools/udftools.mk new file +0
-0
package/udftools/udftools.mk line 9
Quoted 9 lines
package/udftools/udftools.mk new file +9
-0@@ -0,0 +1,13 @@ +################################################################################ +# +# udftools +# +################################################################################ + +UDFTOOLS_VERSION = 2.0 +UDFTOOLS_SITE = https://github.com/pali/udftools/releases/download/$(UDFTOOLS_VERSION) +UDFTOOLS_LICENSE = GPL-2.0
The license is GPL-2.0+. Indeed, all source files I checked have the "or later" statement.
package/udftools/udftools.mk line 12
Quoted 3 lines
package/udftools/udftools.mk new file +3
-0+UDFTOOLS_LICENSE_FILES = COPYING + +$(eval $(autotools-package))
Could you fix those issues and send an updated version ?
Also, it would be nice to make sure that:
- Your package does not have any warnings reported by ./utils/check-package package/udftools/*
- Your package builds properly with the different toolchain configurations tested by ./utils/test-pkg.
Thanks a lot!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com