Skip to contentSkip to conversation

bnxt_en: uninitialized variable in bnxt_rx_pkt()

PATCH In review Dan Carpenter 1 participant 2 messages Jan 16, 2018

Subsystems (4)
Networking Network drivers Kernel janitors Broadcom bnxt_en 50 gigabit Ethernet driver
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 bnxt_en: uninitialized variable in bnxt_rx_pkt()

There are a couple failure paths where "len" is used uninitialized. It means we record the number of rx_packets incorrectly.

Fixes 6a8788f25625 ("bnxt_en: add support for software dynamic interrupt moderation")
Signed-off-by Dan Carpenter <[email protected]>
drivers/net/ethernet/broadcom/bnxt/bnxt.c +1 -1
index cf6ebf1e324b..5b5c4f266f1b 100644
@@ -1482,7 +1482,7 @@ static int bnxt_rx_pkt(struct bnxt *bp, struct bnxt_napi *bnapi, u32 *raw_cons,
 	u32 tmp_raw_cons = *raw_cons;
 	u16 cfa_code, cons, prod, cp_cons = RING_CMP(tmp_raw_cons);
 	struct bnxt_sw_rx_bd *rx_buf;
-	unsigned int len;
+	unsigned int len = 0;
 	u8 *data_ptr, agg_bufs, cmp_type;
 	dma_addr_t dma_addr;
 	struct sk_buff *skb;
author
#1 lore raw

Never mind. Colin already sent this one.

regards,
dan carpenter