Skip to contentSkip to conversation

modpost: Remove trailing semicolon

PATCH Applied Luis de Bethencourt 3 participants 3 messages Jan 16, 2018 Kbuild

lore
Share & tools
lore

Luis de Bethencourt

author
#0 lore raw

PATCH 1/1 modpost: Remove trailing semicolon

The trailing semicolon is an empty statement that does no operation. Removing it since it doesn't do anything.

Signed-off-by Luis de Bethencourt <[email protected]>

---

Hi,

After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches suggested I fix it treewide [0].

Best regards
Luis

[0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
[1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html

 scripts/mod/modpost.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/mod/modpost.c +1 -1
index f51cf977c65b..49dfcd556c78 100644
@@ -1685,7 +1685,7 @@ static void extable_mismatch_handler(const char* modname, struct elf_info *elf,
 static void check_section_mismatch(const char *modname, struct elf_info *elf,
 				   Elf_Rela *r, Elf_Sym *sym, const char *fromsec)
 {
-	const char *tosec = sec_name(elf, get_secindex(elf, sym));;
+	const char *tosec = sec_name(elf, get_secindex(elf, sym));
 	const struct sectioncheck *mismatch = section_mismatch(fromsec, tosec);
 
 	if (mismatch) {
Signature · 1 line
2.15.1
#1 lore raw
Quoted 4 lines · Luis de Bethencourt

The trailing semicolon is an empty statement that does no operation. Removing it since it doesn't do anything.

Signed-off-by Luis de Bethencourt <[email protected]>

Yup, good.

Signed-off-by Kees Cook <[email protected]>

-Kees

Quoted 33 lines

---

Hi,

After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches suggested I fix it treewide [0].

Best regards
Luis

[0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
[1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html

 scripts/mod/modpost.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/mod/modpost.c +1 -2
index f51cf977c65b..49dfcd556c78 100644
@@ -1685,7 +1685,7 @@ static void extable_mismatch_handler(const char* modname, struct elf_info *elf,
 static void check_section_mismatch(const char *modname, struct elf_info *elf,
                                   Elf_Rela *r, Elf_Sym *sym, const char *fromsec)
 {
-       const char *tosec = sec_name(elf, get_secindex(elf, sym));;
+       const char *tosec = sec_name(elf, get_secindex(elf, sym));
        const struct sectioncheck *mismatch = section_mismatch(fromsec, tosec);
 
        if (mismatch) {
--

2.15.1

Signature · 2 lines
Kees Cook
Pixel Security