Skip to contentSkip to conversation

staging: fanotify: remove prohibited space

PATCH In review Sidong Yang 2 participants 2 messages Jan 17, 2018

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: fanotify: remove prohibited space

Fix error reported by checkpatch.pl about space prohibited before that close parenthesis ')'.

---
 fs/notify/fanotify/fanotify_user.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/notify/fanotify/fanotify_user.c +1 -1
index d0d4bc4c4b70..291fe6800bce 100644
@@ -38,7 +38,7 @@
 #define	FANOTIFY_INIT_ALL_EVENT_F_BITS				( \
 		O_ACCMODE	| O_APPEND	| O_NONBLOCK	| \
 		__O_SYNC	| O_DSYNC	| O_CLOEXEC     | \
-		O_LARGEFILE	| O_NOATIME	)
+		O_LARGEFILE	| O_NOATIME)
 
 extern const struct fsnotify_ops fanotify_fsnotify_ops;
 
Signature · 1 line
2.11.0
maintainer
#1 lore raw
Quoted 4 lines · Sidong Yang

Fix error reported by checkpatch.pl about space prohibited before that close parenthesis ')'.

Sorry, but this is just making checkpatch happy without looking too much at the result. The indentation of FANOTIFY_INIT_ALL_EVENT_F_BITS definition is such that braces are aligned with | operators. And, although it is somewhat non-standard, it looks nice and better to me than the alternative suggested by checkpatch. So won't apply this patch.

Honza

Quoted 20 lines
---
 fs/notify/fanotify/fanotify_user.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/notify/fanotify/fanotify_user.c +1 -1
index d0d4bc4c4b70..291fe6800bce 100644
@@ -38,7 +38,7 @@
 #define	FANOTIFY_INIT_ALL_EVENT_F_BITS				( \
 		O_ACCMODE	| O_APPEND	| O_NONBLOCK	| \
 		__O_SYNC	| O_DSYNC	| O_CLOEXEC     | \
-		O_LARGEFILE	| O_NOATIME	)
+		O_LARGEFILE	| O_NOATIME)
 
 extern const struct fsnotify_ops fanotify_fsnotify_ops;
 
Signature · 1 line
2.11.0
Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR