Skip to contentSkip to conversation

PCI / PM: Fix trailing semicolon

PATCH In review Luis de Bethencourt 3 participants 3 messages Jan 17, 2018 – Jan 18, 2018 PCI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 PCI / PM: Fix trailing semicolon

The trailing semicolon is an empty statement that does no operation. Removing it since it doesn't do anything.

---

Hi,

After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches suggested I fix it treewide [0].

Best regards
Luis

[0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
[1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html

 drivers/pci/pci-driver.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/pci-driver.c +1 -1
index d79dbc377b9c..5958c8dda4e3 100644
@@ -968,7 +968,7 @@ static int pci_pm_freeze_late(struct device *dev)
 	if (dev_pm_smart_suspend_and_suspended(dev))
 		return 0;
 
-	return pm_generic_freeze_late(dev);;
+	return pm_generic_freeze_late(dev);
 }
 
 static int pci_pm_freeze_noirq(struct device *dev)
Signature · 1 line
2.15.1
Acked-by on v1 1/1
#1 lore raw

[+cc Rafael]

Quoted 4 lines · Luis de Bethencourt

The trailing semicolon is an empty statement that does no operation. Removing it since it doesn't do anything.

Rafael, I have nothing queued for pci-driver.c, and you've merged most of the recent changes there. If you have any pending changes to it, feel free to merge this one. Otherwise, I'll be happy to pick it up.

I would change the subject to:

PCI / PM: Remove spurious semicolon

Quoted 33 lines

---

Hi,

After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches suggested I fix it treewide [0].

Best regards
Luis

[0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
[1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html

 drivers/pci/pci-driver.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/pci-driver.c +1 -1
index d79dbc377b9c..5958c8dda4e3 100644
@@ -968,7 +968,7 @@ static int pci_pm_freeze_late(struct device *dev)
 	if (dev_pm_smart_suspend_and_suspended(dev))
 		return 0;
 
-	return pm_generic_freeze_late(dev);;
+	return pm_generic_freeze_late(dev);
 }
 
 static int pci_pm_freeze_noirq(struct device *dev)
Signature · 1 line
2.15.1
#2 lore raw
Quoted 10 lines · CET Bjorn Helgaas

[+cc Rafael]

Quoted 4 lines · Luis de Bethencourt

The trailing semicolon is an empty statement that does no operation. Removing it since it doesn't do anything.

Quoted 7 lines

Rafael, I have nothing queued for pci-driver.c, and you've merged most of the recent changes there. If you have any pending changes to it, feel free to merge this one. Otherwise, I'll be happy to pick it up.

I would change the subject to:

PCI / PM: Remove spurious semicolon

OK, I'll take this one.

Thanks,
Rafael

Quoted 31 lines
Quoted 30 lines

---

Hi,

After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches suggested I fix it treewide [0].

Best regards
Luis

[0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
[1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html

 drivers/pci/pci-driver.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/pci-driver.c +1 -1
index d79dbc377b9c..5958c8dda4e3 100644
@@ -968,7 +968,7 @@ static int pci_pm_freeze_late(struct device *dev)
 	if (dev_pm_smart_suspend_and_suspended(dev))
 		return 0;
 
-	return pm_generic_freeze_late(dev);;
+	return pm_generic_freeze_late(dev);
 }
 
 static int pci_pm_freeze_noirq(struct device *dev)