Skip to contentSkip to conversation

xfs: fix non-debug build compiler warnings

PATCH In review Darrick J. Wong 2 participants 2 messages Jan 17, 2018 – Jan 18, 2018 XFS filesystem

lore
Share & tools
lore

Darrick J. Wong

author
#0 lore raw

PATCH 1/1 xfs: fix non-debug build compiler warnings

From: Darrick J. Wong <[email protected]>

Fix compiler warning on non-debug build

Signed-off-by Darrick J. Wong <[email protected]>
---
 fs/xfs/xfs_dquot_item.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
fs/xfs/xfs_dquot_item.c +1 -4
index e564f11..51ee848 100644
@@ -150,10 +150,7 @@ xfs_dquot_item_error(
 	struct xfs_log_item	*lip,
 	struct xfs_buf		*bp)
 {
-	struct xfs_dquot	*dqp;
-
-	dqp = DQUOT_ITEM(lip)->qli_dquot;
-	ASSERT(!completion_done(&dqp->q_flush));
+	ASSERT(!completion_done(&DQUOT_ITEM(lip)->qli_dquot->q_flush));
 	xfs_set_li_failed(lip, bp);
 }
Reviewed-by on v1 1/1
#1 lore raw
Quoted 14 lines · Darrick J. Wong

From: Darrick J. Wong <[email protected]>

Fix compiler warning on non-debug build

Signed-off-by Darrick J. Wong <[email protected]>
---
 fs/xfs/xfs_dquot_item.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
fs/xfs/xfs_dquot_item.c +0 -0
index e564f11..51ee848 100644

fs/xfs/xfs_dquot_item.c xfs_dquot_item_error( · line 154

Quoted 9 lines
fs/xfs/xfs_dquot_item.c +1 -4
@@ -150,10 +150,7 @@ xfs_dquot_item_error(
 	struct xfs_log_item	*lip,
 	struct xfs_buf		*bp)
 {
-	struct xfs_dquot	*dqp;
-
-	dqp = DQUOT_ITEM(lip)->qli_dquot;
-	ASSERT(!completion_done(&dqp->q_flush));
+	ASSERT(!completion_done(&DQUOT_ITEM(lip)->qli_dquot->q_flush));
 	xfs_set_li_failed(lip, bp);

Looks fine.

Reviewed-by Dave Chinner <[email protected]>
Signature · 2 lines
Dave Chinner
[email protected]