RDMA/mlx5; Remove redundant allocation warning print
Subsystems (2)
PATCH 1/1 RDMA/mlx5; Remove redundant allocation warning print
From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/[email protected]>
The kmalloc() failure to allocate memory generates enough information and doesn't need to be accompanied by another driver print.
--- drivers/infiniband/hw/mlx5/main.c | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-)
drivers/infiniband/hw/mlx5/main.c +9 -11
@@ -3345,19 +3345,17 @@ static void mlx5_ib_event(struct mlx5_core_dev *dev, void *context,struct mlx5_ib_event_work *work; work =kmalloc (sizeof (*work),GFP_ATOMIC ); -if (work) { -INIT_WORK (&work->work, mlx5_ib_handle_event); - work->dev = dev; - work->param = param; - work->context = context; - work->event = event; - -queue_work (mlx5_ib_event_wq, &work->work); +if (!work)return ; - } -dev_warn (&dev->pdev->dev,"%s: mlx5_dev_event: %d, with param: %lu dropped, couldn't allocate memory.\n" , - __func__, event, param); +INIT_WORK (&work->work, mlx5_ib_handle_event); + work->dev = dev; + work->param = param; + work->context = context; + work->event = event; + +queue_work (mlx5_ib_event_wq, &work->work); +return ; }static int set_has_smi_cap (struct mlx5_ib_dev *dev)
--
2.15.1
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): 20180118123424.21062-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Quoted 6 lines · Leon Romanovsky
From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/[email protected]>
The
kmalloc()failure to allocate memory generates enough information and doesn't need to be accompanied by another driver print.Fixes d69a24e03659 ("IB/mlx5: Move IB event processing onto a workqueue")
Didn't found it in:
https://kernel.googlesource.com/pub/scm/linux/kernel/git/leon/linux-rdma/
branch rdma-next and didn't find it.
Where should i look?
Quoted 25 lines
--- drivers/infiniband/hw/mlx5/main.c | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-)drivers/infiniband/hw/mlx5/main.c +1
-9@@ -3345,19 +3345,17 @@ static void mlx5_ib_event(struct mlx5_core_dev *dev, void *context,struct mlx5_ib_event_work *work; work =kmalloc (sizeof (*work),GFP_ATOMIC ); -if (work) { -INIT_WORK (&work->work, mlx5_ib_handle_event); - work->dev = dev; - work->param = param; - work->context = context; - work->event = event; - -queue_work (mlx5_ib_event_wq, &work->work); +if (!work)return ; - }
drivers/infiniband/hw/mlx5/main.c static void mlx5_ib_event(struct mlx5_core_dev *dev, void *context, · line 3358
Quoted 10 lines
drivers/infiniband/hw/mlx5/main.c +8
-2-dev_warn (&dev->pdev->dev,"%s: mlx5_dev_event: %d, with param: %lu dropped, couldn't allocate memory.\n" , - __func__, event, param); +INIT_WORK (&work->work, mlx5_ib_handle_event); + work->dev = dev; + work->param = param; + work->context = context; + work->event = event; + +queue_work (mlx5_ib_event_wq, &work->work); +return ;
We don't really need this last "return", right?
Quoted 10 lines
drivers/infiniband/hw/mlx5/main.c +0
-1}static int set_has_smi_cap (struct mlx5_ib_dev *dev) --2.15.1
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 6 lines · Yuval Shaia
Quoted 5 lines · Leon Romanovsky
From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/[email protected]>
The
kmalloc()failure to allocate memory generates enough information and doesn't need to be accompanied by another driver print.
Quoted 6 lines
Quoted 1 line
Fixes d69a24e03659 ("IB/mlx5: Move IB event processing onto a workqueue")Didn't found it in:
https://kernel.googlesource.com/pub/scm/linux/kernel/git/leon/linux-rdma/
branch rdma-next and didn't find it.
Where should i look?
In official place:
https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/commit/?h=for-next&id=d69a24e036596877ce08c25ab8e63a202412fd9e
Quoted 26 lines
Quoted 26 lines
--- drivers/infiniband/hw/mlx5/main.c | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-)drivers/infiniband/hw/mlx5/main.c +1
-9@@ -3345,19 +3345,17 @@ static void mlx5_ib_event(struct mlx5_core_dev *dev, void *context,struct mlx5_ib_event_work *work; work =kmalloc (sizeof (*work),GFP_ATOMIC ); -if (work) { -INIT_WORK (&work->work, mlx5_ib_handle_event); - work->dev = dev; - work->param = param; - work->context = context; - work->event = event; - -queue_work (mlx5_ib_event_wq, &work->work); +if (!work)return ; - }
Quoted 12 lines
drivers/infiniband/hw/mlx5/main.c static void mlx5_ib_event(struct mlx5_core_dev *dev, void *context, · line 3358
Quoted 10 lines
drivers/infiniband/hw/mlx5/main.c +8
-2-dev_warn (&dev->pdev->dev,"%s: mlx5_dev_event: %d, with param: %lu dropped, couldn't allocate memory.\n" , - __func__, event, param); +INIT_WORK (&work->work, mlx5_ib_handle_event); + work->dev = dev; + work->param = param; + work->context = context; + work->event = event; + +queue_work (mlx5_ib_event_wq, &work->work); +return ;We don't really need this last "return", right?
Right, I'll remove it now.
Thanks
Quoted 11 lines
Quoted 11 lines
drivers/infiniband/hw/mlx5/main.c +0
-1}static int set_has_smi_cap (struct mlx5_ib_dev *dev) --2.15.1
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): 20180119105840.GA1393-U/[email protected]
Quoted 10 lines
Quoted 7 lines
Quoted 2 lines
Fixes d69a24e03659 ("IB/mlx5: Move IB event processing onto a workqueue")Didn't found it in:
https://kernel.googlesource.com/pub/scm/linux/kernel/git/leon/linux-rdma/
branch rdma-next and didn't find it.
Where should i look?In official place:
https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/commit/?h=for-next&id=d69a24e036596877ce08c25ab8e63a202412fd9e
I see,
I thought that "rdma-next" in subject stands for branch name, apparently not. So saying rdma-next you actually refer to for-next, right?
Quoted 2 lines
Quoted 2 lines
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 8 lines · Yuval Shaia
Quoted 8 lines
Quoted 7 lines
Quoted 2 lines
Fixes d69a24e03659 ("IB/mlx5: Move IB event processing onto a workqueue")Didn't found it in:
https://kernel.googlesource.com/pub/scm/linux/kernel/git/leon/linux-rdma/
branch rdma-next and didn't find it.
Where should i look?
Quoted 6 lines
Quoted 2 lines
In official place:
https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/commit/?h=for-next&id=d69a24e036596877ce08c25ab8e63a202412fd9eI see,
I thought that "rdma-next" in subject stands for branch name, apparently not. So saying rdma-next you actually refer to for-next, right?
By writing "rdma-next", I mean "target", there is a need to distinguish between different submissions (net/net-next/iproute2/iproute2-next/rdma-rc/rdma-next/rdma-core).
Thanks
Quoted 4 lines
Quoted 3 lines
Quoted 3 lines