Skip to contentSkip to conversation

phy: brcm-sata: remove unused variable

PATCH Applied Arnd Bergmann 3 participants 3 messages Jan 18, 2018 Generic PHY framework

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 phy: brcm-sata: remove unused variable

The newly introduced calibrate function has a variable that has never been used and needs to be removed to avoid this harmless warning:

drivers/phy/broadcom/phy-brcm-sata.c: In function 'brcm_stb_sata_calibrate':
drivers/phy/broadcom/phy-brcm-sata.c:514:24: error: unused variable 'priv' [-Werror=unused-variable]

Fixes 3e507769d15e ("phy: brcm-sata: Implement calibrate callback")
---
 drivers/phy/broadcom/phy-brcm-sata.c | 1 -
 1 file changed, 1 deletion(-)
drivers/phy/broadcom/phy-brcm-sata.c +0 -1
index 5dd9ebeac750..8708ea3b4d6d 100644
@@ -511,7 +511,6 @@ static int brcm_sata_phy_init(struct phy *phy)
 static void brcm_stb_sata_calibrate(struct brcm_sata_port *port)
 {
 	void __iomem *base = brcm_sata_pcb_base(port);
-	struct brcm_sata_phy *priv = port->phy_priv;
 	u32 tmp = BIT(8);
 
 	brcm_sata_phy_wr(base, RXPMD_REG_BANK, RXPMD_RX_FREQ_MON_CONTROL1,
Signature · 1 line
2.9.0
Applied
#1 lore raw
Quoted 9 lines · Arnd Bergmann

The newly introduced calibrate function has a variable that has never been used and needs to be removed to avoid this harmless warning:

drivers/phy/broadcom/phy-brcm-sata.c: In function 'brcm_stb_sata_calibrate':
drivers/phy/broadcom/phy-brcm-sata.c:514:24: error: unused variable 'priv' [-Werror=unused-variable]

Fixes 3e507769d15e ("phy: brcm-sata: Implement calibrate callback")

Applied to libata/for-4.16.

Thanks.

Signature · 1 line
tejun
#2 lore raw
In reply to Arnd Bergmann
Quoted 9 lines · Arnd Bergmann

The newly introduced calibrate function has a variable that has never been used and needs to be removed to avoid this harmless warning:

drivers/phy/broadcom/phy-brcm-sata.c: In function 'brcm_stb_sata_calibrate':
drivers/phy/broadcom/phy-brcm-sata.c:514:24: error: unused variable 'priv' [-Werror=unused-variable]

Fixes 3e507769d15e ("phy: brcm-sata: Implement calibrate callback")

Sorry, rebased and this was left, thanks Arnd!

Signature · 1 line
Florian