Skip to contentSkip to conversation

auxdisplay: img-ascii-lcd: fix typo on select SYSCON/MFD_SYSCON

PATCH In review Corentin Labbe 2 participants 3 messages Jan 18, 2018 – Feb 12, 2018 Auxiliary display drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 auxdisplay: img-ascii-lcd: fix typo on select SYSCON/MFD_SYSCON

img-ascii-lcd select un-existing SYSCON kconfig name.
This patch fix this error by using the correct MFD_SYSCON kconfig name.

---
 drivers/auxdisplay/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/auxdisplay/Kconfig +1 -1
index 2c2ed9cf8796..d9ab60ed6c9b 100644
@@ -138,7 +138,7 @@ config IMG_ASCII_LCD
 	tristate "Imagination Technologies ASCII LCD Display"
 	depends on HAS_IOMEM
 	default y if MIPS_MALTA || MIPS_SEAD3
-	select SYSCON
+	select MFD_SYSCON
 	help
 	  Enable this to support the simple ASCII LCD displays found on
 	  development boards such as the MIPS Boston, MIPS Malta & MIPS SEAD3
Signature · 1 line
2.13.6
Acked-by on v1 1/1
#1 lore raw
Quoted 3 lines · Corentin Labbe

img-ascii-lcd select un-existing SYSCON kconfig name.
This patch fix this error by using the correct MFD_SYSCON kconfig name.

CC'ing Paul & Ralf in case they want to ack.

The mistake seems to be in the tree since the addition of the driver in 0cad855fbd08 ("auxdisplay: img-ascii-lcd: driver for simple ASCII LCD displays").

Thanks,
Miguel

Quoted 21 lines
---
 drivers/auxdisplay/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/auxdisplay/Kconfig +1 -2
index 2c2ed9cf8796..d9ab60ed6c9b 100644
@@ -138,7 +138,7 @@ config IMG_ASCII_LCD
        tristate "Imagination Technologies ASCII LCD Display"
        depends on HAS_IOMEM
        default y if MIPS_MALTA || MIPS_SEAD3
-       select SYSCON
+       select MFD_SYSCON
        help
          Enable this to support the simple ASCII LCD displays found on
          development boards such as the MIPS Boston, MIPS Malta & MIPS SEAD3
--

2.13.6

#2 lore raw
Quoted 6 lines · Miguel Ojeda
Quoted 3 lines · Corentin Labbe

img-ascii-lcd select un-existing SYSCON kconfig name.
This patch fix this error by using the correct MFD_SYSCON kconfig name.

Quoted 8 lines

CC'ing Paul & Ralf in case they want to ack.

The mistake seems to be in the tree since the addition of the driver in 0cad855fbd08 ("auxdisplay: img-ascii-lcd: driver for simple ASCII LCD displays").

I will pick this one up in my queue.

Quoted 24 lines

Thanks,
Miguel

Quoted 21 lines
---
 drivers/auxdisplay/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/auxdisplay/Kconfig +1 -2
index 2c2ed9cf8796..d9ab60ed6c9b 100644
@@ -138,7 +138,7 @@ config IMG_ASCII_LCD
        tristate "Imagination Technologies ASCII LCD Display"
        depends on HAS_IOMEM
        default y if MIPS_MALTA || MIPS_SEAD3
-       select SYSCON
+       select MFD_SYSCON
        help
          Enable this to support the simple ASCII LCD displays found on
          development boards such as the MIPS Boston, MIPS Malta & MIPS SEAD3
--

2.13.6