Skip to contentSkip to conversation

ssb: return boolean instead of integer in ssb_dma_translation_special_bit

PATCH In review Gustavo A. R. Silva 2 participants 2 messages Jan 18, 2018 – Feb 27, 2018 Sonics silicon backplane driver (ssb)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ssb: return boolean instead of integer in ssb_dma_translation_special_bit

Return statements in functions returning bool should use true/false instead of 1/0.

This issue was detected with the help of Coccinelle.

---
 drivers/ssb/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ssb/main.c +1 -1
index 65420a9..fdb89b6 100644
@@ -1116,7 +1116,7 @@ static bool ssb_dma_translation_special_bit(struct ssb_device *dev)
 			chip_id == 43231 || chip_id == 43222);
 	}
 
-	return 0;
+	return false;
 }
 
 u32 ssb_dma_translation(struct ssb_device *dev)
Signature · 1 line
2.7.4
#1 lore raw
Quoted 6 lines · Gustavo A. R. Silva

Return statements in functions returning bool should use true/false instead of 1/0.

This issue was detected with the help of Coccinelle.

Patch applied to wireless-drivers-next.git, thanks.

bd42cd022e44 ssb: return boolean instead of integer in ssb_dma_translation_special_bit

Signature · 3 lines
https://patchwork.kernel.org/patch/10174387/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches