Skip to contentSkip to conversation

sm501: Add missing break to case

PATCH Applied BALATON Zoltan 2 participants 2 messages Jan 19, 2018

lore
Share & tools
lore

BALATON Zoltan

author
#0 lore raw

PATCH 1/1 sm501: Add missing break to case

Noticed by Coverity, forgotten in 5690d9ece

Reported-by Peter Maydell <[email protected]>
Signed-off-by BALATON Zoltan <[email protected]>
---
 hw/display/sm501.c | 1 +
 1 file changed, 1 insertion(+)
hw/display/sm501.c +1 -0
index 4f7dc59b2..134cbed 100644
@@ -797,6 +797,7 @@ static uint64_t sm501_system_config_read(void *opaque, hwaddr addr,
         break;
     case SM501_COMMAND_LIST_STATUS:
         ret = 0x00180002; /* FIFOs are empty, everything idle */
+        break;
     case SM501_IRQ_MASK:
         ret = s->irq_mask;
         break;
Signature · 1 line
2.7.6
Applied
#1 lore raw
Quoted 4 lines · BALATON Zoltan

Noticed by Coverity, forgotten in 5690d9ece

Reported-by Peter Maydell <[email protected]>
Signed-off-by BALATON Zoltan <[email protected]>

Applied to ppc-for-2.12, thanks.

Quoted 16 lines
---
 hw/display/sm501.c | 1 +
 1 file changed, 1 insertion(+)
hw/display/sm501.c +1 -0
index 4f7dc59b2..134cbed 100644
@@ -797,6 +797,7 @@ static uint64_t sm501_system_config_read(void *opaque, hwaddr addr,
         break;
     case SM501_COMMAND_LIST_STATUS:
         ret = 0x00180002; /* FIFOs are empty, everything idle */
+        break;
     case SM501_IRQ_MASK:
         ret = s->irq_mask;
         break;
Signature · 4 lines
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson