ACPI: sbshc: remove raw pointer from printk message
There's no need to be printing a raw kernel pointer to the kernel log at every boot. So just remove it, and change the whole message to use the correct dev_info() call at the same time.
drivers/acpi/sbshc.c +2 -2
@@ -275,8 +275,8 @@ static int acpi_smbus_hc_add(struct acpi_device *device) device->driver_data = hc;acpi_ec_add_query_handler (hc->ec, hc->query_bit,NULL , smbus_alarm, hc); - printk(KERN_INFO PREFIX "SBS HC: EC = 0x%p, offset = 0x%0x, query_bit = 0x%0x\n", - hc->ec, hc->offset, hc->query_bit); +dev_info (&device->dev,"SBS HC: offset = 0x%0x, query_bit = 0x%0x\n" , + hc->offset, hc->query_bit);return 0 ; }
Quoted 6 lines · Greg Kroah-Hartman
There's no need to be printing a raw kernel pointer to the kernel log at every boot. So just remove it, and change the whole message to use the correct
dev_info()call at the same time.Reported-by Wang Qize <[email protected]>Cc stable <[email protected]>
I will remember this one. ;-)
Quoted 1 line
Signed-off-by Greg Kroah-Hartman <[email protected]>
Quoted 19 lines
drivers/acpi/sbshc.c +2
-3@@ -275,8 +275,8 @@ static int acpi_smbus_hc_add(struct acpi_device *device) device->driver_data = hc;acpi_ec_add_query_handler (hc->ec, hc->query_bit,NULL , smbus_alarm, hc); - printk(KERN_INFO PREFIX "SBS HC: EC = 0x%p, offset = 0x%0x, query_bit = 0x%0x\n", - hc->ec, hc->offset, hc->query_bit); +dev_info (&device->dev,"SBS HC: offset = 0x%0x, query_bit = 0x%0x\n" , + hc->offset, hc->query_bit);return 0 ; } --To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 6 lines · Rafael J. Wysocki
Quoted 4 lines · Greg Kroah-Hartman
There's no need to be printing a raw kernel pointer to the kernel log at every boot. So just remove it, and change the whole message to use the correct
dev_info()call at the same time.
Quoted 8 lines
Quoted 2 lines
Reported-by Wang Qize <[email protected]>Cc stable <[email protected]>I will remember this one. ;-)
Quoted 1 line
Signed-off-by Greg Kroah-Hartman <[email protected]>
Does that mean you want me to take this through my tree? Or is there an acpi tree it will go through?
thanks,
greg k-h
Rafael J. Wysocki
maintainerQuoted 10 lines · Greg Kroah-Hartman
Quoted 9 lines · Rafael J. Wysocki
Quoted 6 lines · Greg Kroah-Hartman
There's no need to be printing a raw kernel pointer to the kernel log at every boot. So just remove it, and change the whole message to use the correct
dev_info()call at the same time.Reported-by Wang Qize <[email protected]>Cc stable <[email protected]>
Quoted 8 lines
Quoted 5 lines
I will remember this one. ;-)
Quoted 1 line
Signed-off-by Greg Kroah-Hartman <[email protected]>Does that mean you want me to take this through my tree? Or is there an acpi tree it will go through?
I thought you'd push it, but I can take it, of course. For 4.16, though.
Quoted 14 lines · Rafael J. Wysocki
Quoted 12 lines · Greg Kroah-Hartman
Quoted 11 lines · Rafael J. Wysocki
Quoted 6 lines · Greg Kroah-Hartman
There's no need to be printing a raw kernel pointer to the kernel log at every boot. So just remove it, and change the whole message to use the correct
dev_info()call at the same time.Reported-by Wang Qize <[email protected]>Cc stable <[email protected]>I will remember this one. ;-)
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Greg Kroah-Hartman <[email protected]>Does that mean you want me to take this through my tree? Or is there an acpi tree it will go through?
I thought you'd push it, but I can take it, of course. For 4.16, though.
4.16 is fine, the issue has been around for a very long time, no rush :)
I has recvied a cve-id from mitre.org for this security bug .
should this cve-id( CVE-2018-5750) be mentioned in kernel change log?
From: Greg Kroah-Hartman
Date: 2018-01-20 16:16
To: Rafael J. Wysocki
CC: Rafael J. Wysocki; Len Brown; ACPI Devel Maling List; Linux Kernel Mailing List; Wang Qize
Subject: Re: ACPI: sbshc: remove raw pointer from printk message
Quoted 14 lines · Rafael J. Wysocki
Quoted 12 lines · Greg Kroah-Hartman
Quoted 11 lines · Rafael J. Wysocki
Quoted 6 lines · Greg Kroah-Hartman
There's no need to be printing a raw kernel pointer to the kernel log at every boot. So just remove it, and change the whole message to use the correct
dev_info()call at the same time.Reported-by Wang Qize <[email protected]>Cc stable <[email protected]>I will remember this one. ;-)
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Greg Kroah-Hartman <[email protected]>Does that mean you want me to take this through my tree? Or is there an acpi tree it will go through?
I thought you'd push it, but I can take it, of course. For 4.16, though.
4.16 is fine, the issue has been around for a very long time, no rush :)
Quoted 3 lines · On Mon, Jan 22, 2018 at 11:19:36AM +0800, [email protected] wrote:
I has recvied a cve-id from mitre.org for this security bug .
should this cve-id( CVE-2018-5750) be mentioned in kernel change log?
Only if Rafael wants to hand-edit the patch, it's not really needed for a kernel log commit message to have CVE items in it, especially as the id was received after the patch was created and submitted.
thanks,
greg k-h