Skip to contentSkip to conversation

sparc: vDSO: remove an extra tab

PATCH Applied Dan Carpenter 3 participants 4 messages Jan 19, 2018 – Jan 22, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sparc: vDSO: remove an extra tab

This statement is indented one tab too far which is confusing and leads to a Smatch warning:

arch/sparc/vdso/vma.c:254 arch_setup_additional_pages()
warn: curly braces intended?

arch/sparc/vdso/vma.c +1 -1
index 0a6f50098e23..f51595f861b8 100644
@@ -251,7 +251,7 @@ int arch_setup_additional_pages(struct linux_binprm *bprm, int uses_interp)
 	else
 		return map_vdso(&vdso_image_32_builtin, &vdso_mapping32);
 #else
-		return map_vdso(&vdso_image_64_builtin, &vdso_mapping64);
+	return map_vdso(&vdso_image_64_builtin, &vdso_mapping64);
 #endif
 
 }
Reviewed-by on v1 1/1
#1 lore raw
Quoted 13 lines · Dan Carpenter

This statement is indented one tab too far which is confusing and leads to a Smatch warning:

arch/sparc/vdso/vma.c:254 arch_setup_additional_pages()
warn: curly braces intended?

arch/sparc/vdso/vma.c +0 -0
index 0a6f50098e23..f51595f861b8 100644

arch/sparc/vdso/vma.c int arch_setup_additional_pages(struct linux_binprm *bprm, int uses_interp) · line 257

Quoted 8 lines
arch/sparc/vdso/vma.c +1 -1
@@ -251,7 +251,7 @@ int arch_setup_additional_pages(struct linux_binprm *bprm, int uses_interp)
  	else
  		return map_vdso(&vdso_image_32_builtin, &vdso_mapping32);
  #else
-		return map_vdso(&vdso_image_64_builtin, &vdso_mapping64);
+	return map_vdso(&vdso_image_64_builtin, &vdso_mapping64);
  #endif
 
  }

Should the subject be sparc instead of spark? Other than that,

Thanks!

#2 lore raw
In reply to Dan Carpenter
Quoted 3 lines · nagarathnam muthusamy

Should the subject be sparc instead of spark? Other than that,

Stupid iphone auto corrects all my emails... Just kidding, I made that typo. Fortunately, that part doesn't get saved to the final git log.

regards,
dan carpenter

maintainer Applied
#3 lore raw
In reply to Dan Carpenter

From: Dan Carpenter <[email protected]>
Date: Fri, 19 Jan 2018 21:19:39 +0300

Quoted 7 lines · nagarathnam muthusamy
Quoted 3 lines

Should the subject be sparc instead of spark? Other than that,

Stupid iphone auto corrects all my emails... Just kidding, I made that typo. Fortunately, that part doesn't get saved to the final git log.

Applied, thanks :)