Skip to contentSkip to conversation

Nokia N9: add support for up/down keys in the dts

PATCH In review Pavel Machek 3 participants 5 messages Jan 2, 2018 – Jan 28, 2018 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Nokia N9: add support for up/down keys in the dts

This adds support for volume up/down keys in the dts.

arch/arm/boot/dts/omap3-n9.dts +7 -0
index 39e35f8..57a6679 100644
@@ -11,9 +11,10 @@
 /dts-v1/;
 
 #include "omap3-n950-n9.dtsi"
+#include <dt-bindings/input/input.h>
 
 / {
 	model = "Nokia N9";
 	compatible = "nokia,omap3-n9", "ti,omap36xx", "ti,omap3";
 };
 
@@ -72,3 +133,9 @@
 	st,max-limit-y = <46>;
 	st,max-limit-z = <46>;
 };
+
+&twl_keypad {
+	linux,keymap = < MATRIX_KEY(6, 8, KEY_VOLUMEUP)
+			 MATRIX_KEY(7, 8, KEY_VOLUMEDOWN)
+			 >;
+};
Signature · 9 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180102/20582dda/attachment.sig>
Reviewed-by on v1 1/1
#1 lore raw

Hi,

Quoted 4 lines · Pavel Machek

This adds support for volume up/down keys in the dts.

-- Sebastian

Quoted 31 lines
arch/arm/boot/dts/omap3-n9.dts +7 -0
index 39e35f8..57a6679 100644
@@ -11,9 +11,10 @@
 /dts-v1/;
 
 #include "omap3-n950-n9.dtsi"
+#include <dt-bindings/input/input.h>
 
 / {
 	model = "Nokia N9";
 	compatible = "nokia,omap3-n9", "ti,omap36xx", "ti,omap3";
 };
 
@@ -72,3 +133,9 @@
 	st,max-limit-y = <46>;
 	st,max-limit-z = <46>;
 };
+
+&twl_keypad {
+	linux,keymap = < MATRIX_KEY(6, 8, KEY_VOLUMEUP)
+			 MATRIX_KEY(7, 8, KEY_VOLUMEDOWN)
+			 >;
+};
Signature · 3 lines
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180102/1fd5da38/attachment.sig>

#2 lore raw
Quoted 9 lines · Sebastian Reichel

Hi,

Quoted 4 lines · Pavel Machek

This adds support for volume up/down keys in the dts.

Tony, ping? Can I get you to apply this one?

[PATCHv2] nokia N9: Add support for magnetometer

should be good to go, too...
Pavel

Quoted 32 lines
Quoted 30 lines
arch/arm/boot/dts/omap3-n9.dts +7 -0
index 39e35f8..57a6679 100644
@@ -11,9 +11,10 @@
 /dts-v1/;
 
 #include "omap3-n950-n9.dtsi"
+#include <dt-bindings/input/input.h>
 
 / {
 	model = "Nokia N9";
 	compatible = "nokia,omap3-n9", "ti,omap36xx", "ti,omap3";
 };
 
@@ -72,3 +133,9 @@
 	st,max-limit-y = <46>;
 	st,max-limit-z = <46>;
 };
+
+&twl_keypad {
+	linux,keymap = < MATRIX_KEY(6, 8, KEY_VOLUMEUP)
+			 MATRIX_KEY(7, 8, KEY_VOLUMEDOWN)
+			 >;
+};
Signature · 3 lines
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Signature · 9 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180118/8963ae25/attachment.sig>
#3 lore raw
Quoted 5 lines · Pavel Machek
Quoted 4 lines · Sebastian Reichel

Hi,

Quoted 1 line · Pavel Machek
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

This adds support for volume up/down keys in the dts.

Tony, ping? Can I get you to apply this one?

OK applying that for v4.16 so we have some kind of control of the device without having to rely on the touch screen :)

Quoted 3 lines

[PATCHv2] nokia N9: Add support for magnetometer

should be good to go, too...

I have that tagged for next after -rc1 thanks.

Regards,

Tony

#4 lore raw

Hi!

Quoted 10 lines
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

This adds support for volume up/down keys in the dts.

Tony, ping? Can I get you to apply this one?

OK applying that for v4.16 so we have some kind of control of the device without having to rely on the touch screen :)

Thanks :-).

Quoted 5 lines
Quoted 3 lines

[PATCHv2] nokia N9: Add support for magnetometer

should be good to go, too...

I have that tagged for next after -rc1 thanks.

Actually, if you could get that one to v4.16, too. There's still lot of work to be done to get N9 into usable state, and delaying here does not do any good.

Best regards,
Pavel

Signature · 9 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180128/8c14a83b/attachment.sig>