clk: Remove redundant selection of RATIONAL
PATCH 1/1 clk: Remove redundant selection of RATIONAL
Since the commit
0777591e715a ("clk: fractional-divider: switch to rational best approximation")
enables rational best approximation to all common based clocks, there is no need to repeat the selection in each of them.
No functional changes intended.
--- drivers/clk/Kconfig | 2 -- 1 file changed, 2 deletions(-)
drivers/clk/Kconfig +0 -2
@@ -76,7 +76,6 @@ config COMMON_CLK_SI5351 tristate "Clock driver for SiLabs 5351A/B/C" depends on I2C select REGMAP_I2C - select RATIONAL ---help--- This driver supports Silicon Labs 5351A/B/C programmable clock generators.
@@ -105,7 +104,6 @@ config COMMON_CLK_CDCE706 tristate "Clock driver for TI CDCE706 clock synthesizer" depends on I2C select REGMAP_I2C - select RATIONAL ---help--- This driver supports TI CDCE706 programmable 3-PLL clock synthesizer.
Signature · 1 line
2.15.1
Quoted 10 lines · Andy Shevchenko
Since the commit
0777591e715a("clk: fractional-divider: switch to rational best
approximation")enables rational best approximation to all common based clocks, there is
no need to repeat the selection in each of them.No functional changes intended.
Any comment on this?
Quoted 28 lines
Signed-off-by Andy Shevchenko <[email protected]>--- drivers/clk/Kconfig | 2 -- 1 file changed, 2 deletions(-)drivers/clk/Kconfig +0
-1@@ -76,7 +76,6 @@ config COMMON_CLK_SI5351 tristate "Clock driver for SiLabs 5351A/B/C" depends on I2C select REGMAP_I2C - select RATIONAL ---help--- This driver supports Silicon Labs 5351A/B/C programmableclock
drivers/clk/Kconfig +0
-1generators.@@ -105,7 +104,6 @@ config COMMON_CLK_CDCE706 tristate "Clock driver for TI CDCE706 clock synthesizer" depends on I2C select REGMAP_I2C - select RATIONAL ---help--- This driver supports TI CDCE706 programmable 3-PLL clocksynthesizer.
Signature · 2 lines
Andy Shevchenko <[email protected]> Intel Finland Oy
Quoted 6 lines · Andy Shevchenko
Quoted 5 lines · Andy Shevchenko
Since the commit
0777591e715a("clk: fractional-divider: switch to rational best
approximation")
Quoted 8 lines
Quoted 6 lines
enables rational best approximation to all common based clocks, there
is
no need to repeat the selection in each of them.No functional changes intended.
Any comment on this?
Do we have any active maintainer for clock related patches? Who is that right now?
Can we somehow keep patches commented?
Quoted 31 lines
Quoted 29 lines
Signed-off-by Andy Shevchenko <[email protected]>--- drivers/clk/Kconfig | 2 -- 1 file changed, 2 deletions(-)drivers/clk/Kconfig +0
-1@@ -76,7 +76,6 @@ config COMMON_CLK_SI5351 tristate "Clock driver for SiLabs 5351A/B/C" depends on I2C select REGMAP_I2C - select RATIONAL ---help--- This driver supports Silicon Labs 5351A/B/C programmableclock
drivers/clk/Kconfig +0
-1generators.@@ -105,7 +104,6 @@ config COMMON_CLK_CDCE706 tristate "Clock driver for TI CDCE706 clock synthesizer" depends on I2C select REGMAP_I2C - select RATIONAL ---help--- This driver supports TI CDCE706 programmable 3-PLL clocksynthesizer.
Signature · 2 lines
Andy Shevchenko <[email protected]> Intel Finland Oy
Stephen Boyd
maintainerQuoting Andy Shevchenko (2018-01-19 09:44:01)
Quoted 4 lines
Since the commit
=
0777591e715a("clk: fractional-divider: switch to rational best approxi=
mation")
Quoted 8 lines
=
enables rational best approximation to all common based clocks, there is no need to repeat the selection in each of them.
=No functional changes intended.
=
I'd prefer we leave it alone. It would be better to push the basic clk types into Kconfig and then have platforms select the ones they want to use.
Quoted 10 lines · Stephen Boyd
Quoting Andy Shevchenko (2018-01-19 09:44:01)
Quoted 9 lines
Since the commit
0777591e715a("clk: fractional-divider: switch to rational best
approximation")enables rational best approximation to all common based clocks, there is
no need to repeat the selection in each of them.
Quoted 7 lines
Quoted 2 lines
No functional changes intended.
I'd prefer we leave it alone. It would be better to push the basic clk types into
Kconfigand then have platforms select the ones they want to
use.
Fair enough.
Signature · 2 lines
Andy Shevchenko <[email protected]> Intel Finland Oy