Skip to contentSkip to conversation

fs/fat: remove distractive message in file_fat_read_at()

PATCH New Heinrich Schuchardt 3 participants 3 messages Jan 1, 2018 – Jan 19, 2018 VFAT/FAT/msdos filesystem

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fs/fat: remove distractive message in file_fat_read_at()

The message "reading %s\n" may be interesting when debugging but otherwise it is superfluous.

Only output the message when debugging.

---
 fs/fat/fat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/fat/fat.c +1 -1
index d16883fa10..1283818761 100644
@@ -1106,7 +1106,7 @@ int file_fat_read_at(const char *filename, loff_t pos, void *buffer,
 	if (ret)
 		goto out_free_both;
 
-	printf("reading %s\n", filename);
+	debug("reading %s\n", filename);
 	ret = get_contents(&fsdata, itr->dent, pos, buffer, maxsize, actread);
 
 out_free_both:
Signature · 1 line
2.14.2
#2 lore raw

PATCH 1/1 fs/fat: remove distractive message in file_fat_read_at()

In reply to Heinrich Schuchardt
Quoted 7 lines · Heinrich Schuchardt

The message "reading %s\n" may be interesting when debugging but otherwise it is superfluous.

Only output the message when debugging.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180119/a174510c/attachment.sig>