tools/mrvl_uart.sh: Tidy script output
PATCH 1/1 tools/mrvl_uart.sh: Tidy script output
Fix a typo in help output (awailable -> available). Tidy the grammar - not the board connects to a port, we do.
While at it, be consistent in upper-casing the comments.
--- tools/mrvl_uart.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
tools/mrvl_uart.sh +3 -3
@@ -46,13 +46,13 @@ then echo -e "\nMarvell recovery image downloader for Armada SoC family." echo -e "Command syntax:" echo -e "\t$(basename $0) <port> <file> [2|4|8]" - echo -e "\tport - serial port the target board connected to" + echo -e "\tport - serial port the target board is connected to" echo -e "\tfile - recovery boot image for target download" echo -e "\t2|4|8 - times to increase the default serial port speed by" echo -e "For example - load the image over ttyUSB0 @ 460800 baud:" echo -e "$(basename $0) /dev/ttyUSB0 /tmp/flash-image.bin 4\n" echo -e "=====WARNING=====" - echo -e "- The speed-up option is not awailable in SoC families prior to A8K+" + echo -e "- The speed-up option is not available in SoC families prior to A8K+" echo -e "- This utility is not compatible with Armada 37xx SoC family\n" fi
@@ -111,7 +111,7 @@ stty -F $port raw ignbrk time 5 $fast_baudrate sx -vv $file > $port < $port #sx-at91 $port $file -# return the port to the default speed +# Return the port to the default speed stty -F $port raw ignbrk time 5 $default_baudrate # Optional - fire up Minicom
Signature · 1 line
2.13.6
PATCH 1/1 tools/mrvl_uart.sh: Tidy script output
Quoted 58 lines
-----Original Message-----
From: Andreas Färber [mailto:afaerber at suse.de]
Sent: Saturday, January 20, 2018 14:19
To: u-boot at lists.denx.de
Cc: Andreas Färber; Kostya Porotchkin; Stefan Roese; Igal Liberman
Subject: [PATCH]tools/mrvl_uart.sh: Tidy script outputFix a typo in help output (awailable -> available). Tidy the grammar - not the board connects to a port, we do.
While at it, be consistent in upper-casing the comments.
Fixes eee4835d22 ("tools: Add Marvell recovery image download script")Cc Konstantin Porotchkin <[email protected]>Cc Stefan Roese <[email protected]>Cc Igal Liberman <[email protected]>Signed-off-by Andreas Färber <[email protected]>--- tools/mrvl_uart.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)tools/mrvl_uart.sh index renamed from tools/mrvl_uart.sh +0
-0500fa117eb..6824208902 100755
tools/mrvl_uart.sh +0
-0@@ -46,13 +46,13 @@ then echo -e "\nMarvell recovery image downloader for Armada SoCfamily."
echo -e "Command syntax:"
echo -e "\t$(basename $0) <port> <file> [2|4|8]"tools/mrvl_uart.sh +1
-1- echo -e "\tport - serial port the target board connected to" + echo -e "\tport - serial port the target board is connected to" echo -e "\tfile - recovery boot image for target download" echo -e "\t2|4|8 - times to increase the default serial port speedby"
echo -e "For example - load the image over ttyUSB0 @ 460800 baud:" echo -e "$(basename $0) /dev/ttyUSB0 /tmp/flash-image.bin 4\n" echo -e "=====WARNING====="- echo -e "- The speed-up option is not awailable in SoC families
prior to A8K+"
+ echo -e "- The speed-up option is not available in SoC families
prior to A8K+"
echo -e "- This utility is not compatible with Armada 37xx SoC
family\n"
fitools/mrvl_uart.sh +0
-0@@ -111,7 +111,7 @@ stty -F $port raw ignbrk time 5 $fast_baudrate sx -vv $file > $port < $port
#sx-at91 $port $filetools/mrvl_uart.sh +1
-2-# return the port to the default speed +# Return the port to the default speed stty -F $port raw ignbrk time 5 $default_baudrate # Optional - fire up Minicom --
Quoted 1 line
2.13.6
PATCH 1/1 tools/mrvl_uart.sh: Tidy script output
In reply to Andreas FärberQuoted 36 lines · Andreas Färber
Fix a typo in help output (awailable -> available). Tidy the grammar - not the board connects to a port, we do.
While at it, be consistent in upper-casing the comments.
Fixes eee4835d22 ("tools: Add Marvell recovery image download script")Cc Konstantin Porotchkin <[email protected]>Cc Stefan Roese <[email protected]>Cc Igal Liberman <[email protected]>Signed-off-by Andreas Färber <[email protected]>--- tools/mrvl_uart.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)tools/mrvl_uart.sh +2
-2@@ -46,13 +46,13 @@ then echo -e "\nMarvell recovery image downloader for Armada SoC family." echo -e "Command syntax:" echo -e "\t$(basename $0) <port> <file> [2|4|8]" - echo -e "\tport - serial port the target board connected to" + echo -e "\tport - serial port the target board is connected to" echo -e "\tfile - recovery boot image for target download" echo -e "\t2|4|8 - times to increase the default serial port speed by" echo -e "For example - load the image over ttyUSB0 @ 460800 baud:" echo -e "$(basename $0) /dev/ttyUSB0 /tmp/flash-image.bin 4\n" echo -e "=====WARNING=====" - echo -e "- The speed-up option is not awailable in SoC families prior to A8K+" + echo -e "- The speed-up option is not available in SoC families prior to A8K+" echo -e "- This utility is not compatible with Armada 37xx SoC family\n" fi
tools/mrvl_uart.sh stty -F $port raw ignbrk time 5 $fast_baudrate · line 117
Quoted 8 lines
tools/mrvl_uart.sh +1
-1@@ -111,7 +111,7 @@ stty -F $port raw ignbrk time 5 $fast_baudrate sx -vv $file > $port < $port #sx-at91 $port $file -# return the port to the default speed +# Return the port to the default speed stty -F $port raw ignbrk time 5 $default_baudrate # Optional - fire up Minicom
Thanks,
Stefan
PATCH 1/1 tools/mrvl_uart.sh: Tidy script output
In reply to Andreas FärberQuoted 36 lines · Andreas Färber
Fix a typo in help output (awailable -> available). Tidy the grammar - not the board connects to a port, we do.
While at it, be consistent in upper-casing the comments.
Fixes eee4835d22 ("tools: Add Marvell recovery image download script")Cc Konstantin Porotchkin <[email protected]>Cc Stefan Roese <[email protected]>Cc Igal Liberman <[email protected]>Signed-off-by Andreas Färber <[email protected]>--- tools/mrvl_uart.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)tools/mrvl_uart.sh +2
-2@@ -46,13 +46,13 @@ then echo -e "\nMarvell recovery image downloader for Armada SoC family." echo -e "Command syntax:" echo -e "\t$(basename $0) <port> <file> [2|4|8]" - echo -e "\tport - serial port the target board connected to" + echo -e "\tport - serial port the target board is connected to" echo -e "\tfile - recovery boot image for target download" echo -e "\t2|4|8 - times to increase the default serial port speed by" echo -e "For example - load the image over ttyUSB0 @ 460800 baud:" echo -e "$(basename $0) /dev/ttyUSB0 /tmp/flash-image.bin 4\n" echo -e "=====WARNING=====" - echo -e "- The speed-up option is not awailable in SoC families prior to A8K+" + echo -e "- The speed-up option is not available in SoC families prior to A8K+" echo -e "- This utility is not compatible with Armada 37xx SoC family\n" fi
tools/mrvl_uart.sh stty -F $port raw ignbrk time 5 $fast_baudrate · line 117
Quoted 8 lines
tools/mrvl_uart.sh +1
-1@@ -111,7 +111,7 @@ stty -F $port raw ignbrk time 5 $fast_baudrate sx -vv $file > $port < $port #sx-at91 $port $file -# return the port to the default speed +# Return the port to the default speed stty -F $port raw ignbrk time 5 $default_baudrate # Optional - fire up Minicom
Applied to u-boot-marvell/master.
Thanks,
Stefan