usb: misc: xapea00x: add driver for Xaptum ENF Access Card
Greg Kroah-Hartman
maintainerPATCH 1/2 usb: misc: xapea00x: add driver for Xaptum ENF Access Card
Quoted 5 lines · David R. Bild
+/**
+ *xapea00x_spi_cleanup
+ *
+ * Context: !in_interrupt()
+ */
No need to have kerneldoc formatting for static functions, nor the whole Context thing, but it's your code to maintain over time, not mine :)
Review
Quoted 4 lines
(quoted diff) +4
-0+static void xapea00x_spi_cleanup(struct spi_device *spi) +{ + dev_dbg(&spi->dev, "%s\n", __func__); +}
Why? Why is this function here at all?
And don't use dev_dbg() for function calls, that's what ftrace is for.
Shouldn't you be actually cleaning up some memory or reference count here?
thanks,
greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html