Skip to contentSkip to conversation

doc: Fix typos in CONTRIBUTING

PATCH In review Rhys Kidd 3 participants 7 messages Jan 23, 2018 Library code

lore
Share & tools
lore

Rhys Kidd

author
#0 lore raw

PATCH v2 1/5 doc: Fix typos in CONTRIBUTING

---
 CONTRIBUTING | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)
CONTRIBUTING +3 -5
index aa555aa1..5600caaf 100644
@@ -29,7 +29,7 @@ A short list of contribution guidelines:
 - Patches need to be reviewed on the mailing list. Exceptions only apply for
   testcases and tooling for drivers with just a single contributor (e.g. vc4).
   In this case patches must still be submitted to the mailing list first.
-  Testcase should preferrably be cross-reviewed by the same people who write and
+  Testcase should preferably be cross-reviewed by the same people who write and
   review the kernel feature itself.
 
 - When patches from new contributors (without commit access) are stuck, for
@@ -38,9 +38,7 @@ A short list of contribution guidelines:
   contact one of the maintainers (listed in the MAINTAINERS file) and cc the
   intel-gfx mailing list.
 
-- Especially changes to the testcase should get tested on relevant platforms
-  before committing. For Intel employees that's best done using PRTS, see the
-  relevant internal howtos. Everyone else can just run piglit with i-g-t tests
-  locally.
+- Changes to the testcases are automatically tested. Take the results into
+  account before merging.
 
 Happy hacking!
Signature · 6 lines
2.14.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
author
#1 lore raw

PATCH v2 2/5 lib/igt.cocci: Fix typo

---
 lib/igt.cocci | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
lib/igt.cocci +2 -2
index 10abd210..6b691862 100644
@@ -1,5 +1,5 @@
-// Semantic patch for common patters and their replacement by igt infrastructure
-// and macros. Please run with
+// Semantic patch for common patterns and their replacement by igt
+// infrastructure and macros. Please run with
 //
 // spatch --sp-file lib/igt.cocci --in-place tests/*.c
 //
Signature · 6 lines
2.14.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
author
#2 lore raw

PATCH v2 3/5 doc: Correct sentence in README

In reply to Rhys Kidd

Usage of 'save for/safe for' here could be confusing for non-native English speakers. Rather than fix the typo, let's use the more commonly understand 'except'.

---
 README | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
README +1 -1
index 807db0e3..7cd78e44 100644
@@ -99,7 +99,7 @@ tools/
 	up the 2D build to ship them.  Instead, here's a separate package for
 	people debugging the driver.
 
-	These tools generally must be run as root, safe for the ones that just
+	These tools generally must be run as root, except for the ones that just
 	decode dumps.
 
 debugger/
Signature · 6 lines
2.14.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
author
#3 lore raw

PATCH v2 4/5 doc: Update CONTRIBUTING for new igt-dev mailing list

In reply to Rhys Kidd

v2: Modify comments for feedback received (Petri Latvala)

---
 CONTRIBUTING | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)
CONTRIBUTING +13 -3
index 5600caaf..0180641b 100644
@@ -6,11 +6,21 @@ improvements for documentation and new tools and testcases.
 A short list of contribution guidelines:
 
 - Please submit patches formatted with git send-email/git format-patch or
-  equivalent to
+  equivalent to:
+
+    Development mailing list for IGT GPU Tools <[email protected]>
+
+  For a transition period patches are accepted on both the igt-dev mailing list
+  and the former intel-gfx mailing list (with the appropriate patch
+  subjectprefix, see below).
+
+  During the transition period, feel free to send patches to both lists if you
+  have a need to do so, as they will get deduplicated so they only appear and
+  are tested in one Patchwork instance.
 
     Intel GFX discussion <[email protected]>
 
-  Please use --subject-prefix="PATCH i-g-t" so that i-g-t patches are easily
+  Please use --subject-prefix="PATCH i-g-t" so IGT patches are easily
   identified in the massive amount mails on intel-gfx. To ensure this is always
   done, meson.sh (and autogen.sh) will run:
 
@@ -36,7 +46,7 @@ A short list of contribution guidelines:
   anything related to the regular releases, issues with packaging and
   integrating platform support or any other intel-gpu-tools issues, please
   contact one of the maintainers (listed in the MAINTAINERS file) and cc the
-  intel-gfx mailing list.
+  igt-dev mailing list.
 
 - Changes to the testcases are automatically tested. Take the results into
   account before merging.
Signature · 6 lines
2.14.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
author
#4 lore raw

PATCH v2 5/5 man: Update for new igt-dev mailing list

In reply to Rhys Kidd

Reflect new mailing list and author in man page documentation. Change made ahead of the eventual project name switch to "IGT GPU Tools".

v2: Also update author (Jani Nikula)

---
 man/intel_aubdump.rst               | 2 +-
 man/intel_audio_dump.rst            | 2 +-
 man/intel_bios_dumper.rst           | 2 +-
 man/intel_error_decode.rst          | 2 +-
 man/intel_gpu_frequency.rst         | 2 +-
 man/intel_gpu_top.rst               | 2 +-
 man/intel_gtt.rst                   | 2 +-
 man/intel_infoframes.rst            | 2 +-
 man/intel_lid.rst                   | 2 +-
 man/intel_panel_fitter.rst          | 2 +-
 man/intel_stepping.rst              | 2 +-
 man/intel_upload_blit_large.rst     | 2 +-
 man/intel_upload_blit_large_gtt.rst | 2 +-
 man/intel_upload_blit_large_map.rst | 2 +-
 man/intel_upload_blit_small.rst     | 2 +-
 man/intel_vbt_decode.rst            | 2 +-
 16 files changed, 16 insertions(+), 16 deletions(-)
man/intel_aubdump.rst +1 -1
index c6a51676..2b5d263e 100644
@@ -6,7 +6,7 @@ intel_aubdump
 Launch an application and capture rendering to an AUB
 -----------------------------------------------------
 .. include:: defs.rst
-:Author: Intel Graphics for Linux <[email protected]>
+:Author: IGT Developers <[email protected]>
 :Date: 2016-03-01
 :Version: |PACKAGE_STRING|
 :Copyright: 2015-2016 Intel Corporation
man/intel_audio_dump.rst +1 -1
index 78bbae44..d4e8423b 100644
@@ -6,7 +6,7 @@ intel_audio_dump
 Dump the Intel GPU registers for HDMI audio setup
 -------------------------------------------------
 .. include:: defs.rst
-:Author: Intel Graphics for Linux <[email protected]>
+:Author: IGT Developers <[email protected]>
 :Date: 2016-03-01
 :Version: |PACKAGE_STRING|
 :Copyright: 2010,2012,2016 Intel Corporation
man/intel_bios_dumper.rst +1 -1
index b271b9b1..b21a24a8 100644
@@ -6,7 +6,7 @@ intel_bios_dumper
 Save the Intel video BIOS contents to a file
 --------------------------------------------
 .. include:: defs.rst
-:Author: Intel Graphics for Linux <[email protected]>
+:Author: IGT Developers <[email protected]>
 :Date: 2016-03-01
 :Version: |PACKAGE_STRING|
 :Copyright: 2010,2012,2016 Intel Corporation
man/intel_error_decode.rst +1 -1
index e7a54a6f..b2495b90 100644
@@ -6,7 +6,7 @@ intel_error_decode
 Decode an Intel GPU dump automatically captured by the kernel at the time of an error
 -------------------------------------------------------------------------------------
 .. include:: defs.rst
-:Author: Intel Graphics for Linux <[email protected]>
+:Author: IGT Developers <[email protected]>
 :Date: 2016-03-01
 :Version: |PACKAGE_STRING|
 :Copyright: 2010,2012,2016 Intel Corporation
man/intel_gpu_frequency.rst +1 -1
index e4de602c..8b7c7860 100644
@@ -6,7 +6,7 @@ intel_gpu_frequency
 Manipulate Intel GPU frequencies
 --------------------------------
 .. include:: defs.rst
-:Author: Intel Graphics for Linux <[email protected]>
+:Author: IGT Developers <[email protected]>
 :Date: 2016-03-01
 :Version: |PACKAGE_STRING|
 :Copyright: 2015-2016 Intel Corporation
man/intel_gpu_top.rst +1 -1
index c9030e1e..a5f7175b 100644
@@ -6,7 +6,7 @@ intel_gpu_top
 Display a top-like summary of Intel GPU usage
 ---------------------------------------------
 .. include:: defs.rst
-:Author: Intel Graphics for Linux <[email protected]>
+:Author: IGT Developers <[email protected]>
 :Date: 2016-03-01
 :Version: |PACKAGE_STRING|
 :Copyright: 2009,2011,2012,2016 Intel Corporation
man/intel_gtt.rst +1 -1
index d14184fa..203fd717 100644
@@ -6,7 +6,7 @@ intel_gtt
 Dump the contents of an Intel GPU's GTT
 ---------------------------------------
 .. include:: defs.rst
-:Author: Intel Graphics for Linux <[email protected]>
+:Author: IGT Developers <[email protected]>
 :Date: 2016-03-01
 :Version: |PACKAGE_STRING|
 :Copyright: 2010,2012,2016 Intel Corporation
man/intel_infoframes.rst +1 -1
index 70372333..bd212480 100644
@@ -6,7 +6,7 @@ intel_infoframes
 View and change HDMI InfoFrames
 -------------------------------
 .. include:: defs.rst
-:Author: Intel Graphics for Linux <[email protected]>
+:Author: IGT Developers <[email protected]>
 :Date: 2016-03-01
 :Version: |PACKAGE_STRING|
 :Copyright: 2012,2016 Intel Corporation
man/intel_lid.rst +1 -1
index 8b7fd3fc..f74c5c26 100644
@@ -6,7 +6,7 @@ intel_lid
 Poll the values of different reports about laptop lid state
 -----------------------------------------------------------
 .. include:: defs.rst
-:Author: Intel Graphics for Linux <[email protected]>
+:Author: IGT Developers <[email protected]>
 :Date: 2016-03-01
 :Version: |PACKAGE_STRING|
 :Copyright: 2010,2012-2013,2016 Intel Corporation
man/intel_panel_fitter.rst +1 -1
index d2af0d87..b1615c9e 100644
@@ -6,7 +6,7 @@ intel_panel_fitter
 Change the panel fitter settings
 --------------------------------
 .. include:: defs.rst
-:Author: Intel Graphics for Linux <[email protected]>
+:Author: IGT Developers <[email protected]>
 :Date: 2016-03-01
 :Version: |PACKAGE_STRING|
 :Copyright: 2012,2016 Intel Corporation
man/intel_stepping.rst +1 -1
index 9ea7c198..8f4d5056 100644
@@ -6,7 +6,7 @@ intel_stepping
 Display the stepping information for an Intel GPU
 -------------------------------------------------
 .. include:: defs.rst
-:Author: Intel Graphics for Linux <[email protected]>
+:Author: IGT Developers <[email protected]>
 :Date: 2016-03-01
 :Version: |PACKAGE_STRING|
 :Copyright: 2009,2012,2016 Intel Corporation
man/intel_upload_blit_large.rst +1 -1
index dc06d701..794fd9b9 100644
@@ -6,7 +6,7 @@ intel_upload_blit_large
 Microbenchmark of Intel GPU performance
 ---------------------------------------
 .. include:: defs.rst
-:Author: Intel Graphics for Linux <[email protected]>
+:Author: IGT Developers <[email protected]>
 :Date: 2016-03-01
 :Version: |PACKAGE_STRING|
 :Copyright: 2009,2012,2016 Intel Corporation
man/intel_upload_blit_large_gtt.rst +1 -1
index 331eb8dd..4a1c5934 100644
@@ -6,7 +6,7 @@ intel_upload_blit_large_gtt
 Microbenchmark of Intel GPU performance
 ---------------------------------------
 .. include:: defs.rst
-:Author: Intel Graphics for Linux <[email protected]>
+:Author: IGT Developers <[email protected]>
 :Date: 2016-03-01
 :Version: |PACKAGE_STRING|
 :Copyright: 2009,2012,2016 Intel Corporation
man/intel_upload_blit_large_map.rst +1 -1
index 32beb414..d818b6d5 100644
@@ -6,7 +6,7 @@ intel_upload_blit_large_map
 Microbenchmark of Intel GPU performance
 ---------------------------------------
 .. include:: defs.rst
-:Author: Intel Graphics for Linux <[email protected]>
+:Author: IGT Developers <[email protected]>
 :Date: 2016-03-01
 :Version: |PACKAGE_STRING|
 :Copyright: 2009,2012,2016 Intel Corporation
man/intel_upload_blit_small.rst +1 -1
index 2a8d80de..bb6239f5 100644
@@ -6,7 +6,7 @@ intel_upload_blit_small
 Microbenchmark of Intel GPU performance
 ---------------------------------------
 .. include:: defs.rst
-:Author: Intel Graphics for Linux <[email protected]>
+:Author: IGT Developers <[email protected]>
 :Date: 2016-03-01
 :Version: |PACKAGE_STRING|
 :Copyright: 2009,2012,2016 Intel Corporation
man/intel_vbt_decode.rst +1 -1
index a8d36d50..496ea3f1 100644
@@ -6,7 +6,7 @@ intel_vbt_decode
 Intel Video BIOS Table parser
 -----------------------------
 .. include:: defs.rst
-:Author: Intel Graphics for Linux <[email protected]>
+:Author: IGT Developers <[email protected]>
 :Date: 2016-03-01
 :Version: |PACKAGE_STRING|
 :Copyright: 2010,2012,2016 Intel Corporation
Signature · 6 lines
2.14.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#5 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v2,1/5] doc: Fix typos in CONTRIBUTING

In reply to Rhys Kidd
== Series Details ==

== Series Details ==

Series: series starting with [i-g-t,v2,1/5] doc: Fix typos in CONTRIBUTING
URL : https://patchwork.freedesktop.org/series/36939/
State : success

== Summary ==

IGT patchset tested on top of latest successful build f1290e3c55ecd3665a5d77cffeaf3562f3b6b700 igt/pm_rps: Include related kernel RPS info

with latest DRM-Tip kernel build CI_DRM_3671
06c8efda323a drm-tip: 2018y-01m-22d-17h-43m-26s UTC integration manifest

No testlist changes.

Test debugfs_test:

        Subgroup read_all_entries:
                dmesg-fail -> DMESG-WARN (fi-elk-e7500) fdo#103989
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-b:
                incomplete -> PASS       (fi-snb-2520m) fdo#103713

fdo#103989 https://bugs.freedesktop.org/show_bug.cgi?id=103989
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713

fi-bdw-5557u     total:288  pass:267  dwarn:0   dfail:0   fail:0   skip:21  time:426s
fi-bdw-gvtdvm    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:428s
fi-blb-e6850     total:288  pass:223  dwarn:1   dfail:0   fail:0   skip:64  time:370s
fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:494s
fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:282s
fi-bxt-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:488s
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:493s
fi-byt-j1900     total:288  pass:253  dwarn:0   dfail:0   fail:0   skip:35  time:472s
fi-byt-n2820     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:459s
fi-elk-e7500     total:224  pass:168  dwarn:10  dfail:0   fail:0   skip:45 
fi-gdg-551       total:288  pass:179  dwarn:0   dfail:0   fail:1   skip:108 time:287s
fi-glk-1         total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:515s
fi-hsw-4770      total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:396s
fi-hsw-4770r     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:401s
fi-ilk-650       total:288  pass:228  dwarn:0   dfail:0   fail:0   skip:60  time:416s
fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:461s
fi-ivb-3770      total:288  pass:255  dwarn:0   dfail:0   fail:0   skip:33  time:416s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:458s
fi-kbl-7560u     total:288  pass:269  dwarn:0   dfail:0   fail:0   skip:19  time:497s
fi-kbl-7567u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:458s
fi-kbl-r         total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:505s
fi-pnv-d510      total:288  pass:222  dwarn:1   dfail:0   fail:0   skip:65  time:580s
fi-skl-6260u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:435s
fi-skl-6600u     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:510s
fi-skl-6700hq    total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:527s
fi-skl-6700k2    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:489s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:489s
fi-skl-guc       total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:422s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:434s
fi-snb-2520m     total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:526s
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:402s
Blacklisted hosts:
fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:565s
fi-glk-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:470s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_811/issues.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev