Skip to contentSkip to conversation

fanotify: the mount fs_type should be given

PATCH New Li Wang 3 participants 4 messages Jan 23, 2018

lore
Share & tools
lore

Li Wang

author
#0 lore raw

PATCH 1/1 fanotify: the mount fs_type should be given

This commmit 28507e514c(safe_mount: Do not try mount() syscall for FUSE fs) involves FUSE fs check in safe_mount(), so we should give the "fs_type" when calling that in case the system kill our program.

cmdline="fanotify06"
contacts=""
analysis=exit
<<<test_output>>>
tst_test.c:980: INFO: Timeout per run is 0h 10m 00s tst_test.c:1025: BROK: Test killed by SIGSEGV!

Signed-off-by Li Wang <[email protected]>
---
 testcases/kernel/syscalls/fanotify/fanotify06.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
testcases/kernel/syscalls/fanotify/fanotify06.c +1 -1
index e63e457..8cbe1ad 100644
@@ -221,7 +221,7 @@ void test01(void)
 static void setup(void)
 {
 	SAFE_MKDIR(MOUNT_NAME, 0755);
-	SAFE_MOUNT(MOUNT_NAME, MOUNT_NAME, NULL, MS_BIND, NULL);
+	SAFE_MOUNT(MOUNT_NAME, MOUNT_NAME, "none", MS_BIND, NULL);
 	mount_created = 1;
 	SAFE_CHDIR(MOUNT_NAME);
Signature · 1 line
2.9.3
#1 lore raw

PATCH 1/1 fanotify: the mount fs_type should be given

----- Original Message -----

Quoted 3 lines

This commmit 28507e514c(safe_mount: Do not try mount() syscall for FUSE fs) involves FUSE fs check in safe_mount(), so we should give the "fs_type" when calling that in case the system kill our program.

Shouldn't we rather change is_fuse() to return 0 if fs_type is NULL?

Quoted 31 lines

cmdline="fanotify06"
contacts=""
analysis=exit
<<<test_output>>>
tst_test.c:980: INFO: Timeout per run is 0h 10m 00s tst_test.c:1025: BROK: Test killed by SIGSEGV!

Signed-off-by Li Wang <[email protected]>
---
 testcases/kernel/syscalls/fanotify/fanotify06.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
testcases/kernel/syscalls/fanotify/fanotify06.c +1 -2
index e63e457..8cbe1ad 100644
@@ -221,7 +221,7 @@ void test01(void)
 static void setup(void)
 {
 	SAFE_MKDIR(MOUNT_NAME, 0755);
-	SAFE_MOUNT(MOUNT_NAME, MOUNT_NAME, NULL, MS_BIND, NULL);
+	SAFE_MOUNT(MOUNT_NAME, MOUNT_NAME, "none", MS_BIND, NULL);
 	mount_created = 1;
 	SAFE_CHDIR(MOUNT_NAME);
 
--

2.9.3

#2 lore raw

PATCH 1/1 fanotify: the mount fs_type should be given

Hi!

Quoted 5 lines
Quoted 3 lines

This commmit 28507e514c(safe_mount: Do not try mount() syscall for FUSE fs) involves FUSE fs check in safe_mount(), so we should give the "fs_type" when calling that in case the system kill our program.

Shouldn't we rather change is_fuse() to return 0 if fs_type is NULL?

Agreed.

Signature · 2 lines
Cyril Hrubis
[email protected]
author
#3 lore raw

PATCH 1/1 fanotify: the mount fs_type should be given

Quoted 9 lines · Cyril Hrubis

Hi!

Quoted 1 line
Quoted 1 line

This commmit 28507e514c(safe_mount: Do not try mount() syscall for

FUSE fs)

Quoted 1 line
Quoted 1 line

involves FUSE fs check in safe_mount(), so we should give the

"fs_type" when

Quoted 3 lines
Quoted 1 line

calling that in case the system kill our program.

Shouldn't we rather change is_fuse() to return 0 if fs_type is NULL?

​Ok, that sounds better, let me re-write this.

Thanks!​

Quoted 7 lines

Agreed.

--
Cyril Hrubis
[email protected]

Signature · 5 lines
Li Wang
[email protected]
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20180123/5196ec7f/attachment.html>