Skip to contentSkip to conversation

net/ibm/emac: wrong bit is used for STA control register write

PATCH In review Ivan Mikhaylov 2 participants 2 messages Jan 23, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 2/2 net/ibm/emac: wrong bit is used for STA control register write

STA control register has areas of mode and opcodes for opeations. 18 bit is using for mode selection, where 0 is old MIO/MDIO access method and 1 is indirect access mode. 19-20 bits are using for setting up read/write operation(STA opcodes). In current state 'read' is set into old MIO/MDIO mode with 19 bit and write operation is set into 18 bit which is mode selection, not a write operation. To correlate write with read we set it into 20 bit. All those bit operations are MSB 0 based.

---
 drivers/net/ethernet/ibm/emac/emac.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/ethernet/ibm/emac/emac.h +1 -1
index d0a0e3b..c26d263 100644
@@ -244,7 +244,7 @@ struct emac_regs {
 #define EMAC_STACR_PHYE			0x00004000
 #define EMAC_STACR_STAC_MASK		0x00003000
 #define EMAC_STACR_STAC_READ		0x00001000
-#define EMAC_STACR_STAC_WRITE		0x00002000
+#define EMAC_STACR_STAC_WRITE		0x00000800
 #define EMAC_STACR_OPBC_MASK		0x00000C00
 #define EMAC_STACR_OPBC_50		0x00000000
 #define EMAC_STACR_OPBC_66		0x00000400
Signature · 1 line
1.7.1
maintainer
#1 lore raw

When posting a new version of a patch which is part of a series, you must always repost the entire series not just the patches which change.

Thank you.