Skip to contentSkip to conversation

drm/etnaviv: fix '%x' warning

PATCH In review Gustavo A. R. Silva 3 participants 3 messages Jan 23, 2018 – Jan 24, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/etnaviv: fix '%x' warning

Fix the following warning by using %zx instead of %x for variable of type size_t:

warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 4 has type ‘size_t {aka long unsigned int}’ [-Wformat=]

Fixes 50073cf98d16 ("drm/etnaviv: mmu: stop using iommu map/unmap functions")

---
This code was compiled with GCC 7.2.0

 drivers/gpu/drm/etnaviv/etnaviv_mmu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/etnaviv/etnaviv_mmu.c +2 -2
index d113fe0..49e0497 100644
@@ -29,7 +29,7 @@ static void etnaviv_domain_unmap(struct etnaviv_iommu_domain *domain,
 	size_t pgsize = SZ_4K;
 
 	if (!IS_ALIGNED(iova | size, pgsize)) {
-		pr_err("unaligned: iova 0x%lx size 0x%zx min_pagesz 0x%x\n",
+		pr_err("unaligned: iova 0x%lx size 0x%zx min_pagesz 0x%zx\n",
 		       iova, size, pgsize);
 		return;
 	}
@@ -54,7 +54,7 @@ static int etnaviv_domain_map(struct etnaviv_iommu_domain *domain,
 	int ret = 0;
 
 	if (!IS_ALIGNED(iova | paddr | size, pgsize)) {
-		pr_err("unaligned: iova 0x%lx pa %pa size 0x%zx min_pagesz 0x%x\n",
+		pr_err("unaligned: iova 0x%lx pa %pa size 0x%zx min_pagesz 0x%zx\n",
 		       iova, &paddr, size, pgsize);
 		return -EINVAL;
 	}
Signature · 1 line
2.7.4
maintainer
#1 lore raw

Hi Gustavo,

Am Dienstag, den 23.01.2018, 11:07 -0600 schrieb Gustavo A. R. Silva:

Quoted 8 lines

Fix the following warning by using %zx instead of %x for variable of type size_t:

warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 4 has type ‘size_t {aka long unsigned int}’ [-Wformat=]

Fixes 50073cf98d16 ("drm/etnaviv: mmu: stop using iommu map/unmap functions")

Thanks for the patch, but I already have an equivalent change queued up.

Regards,
Lucas

Quoted 22 lines

---
This code was compiled with GCC 7.2.0

 drivers/gpu/drm/etnaviv/etnaviv_mmu.c | 4 ++--

 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/etnaviv/etnaviv_mmu.c +0 -0
index d113fe0..49e0497 100644
@@ -29,7 +29,7 @@ static void etnaviv_domain_unmap(struct etnaviv_iommu_domain *domain,
 >  	size_t pgsize = SZ_4K;

Quoted 6 lines

  if (!IS_ALIGNED(iova | size, pgsize)) {

drivers/gpu/drm/etnaviv/etnaviv_mmu.c +1 -1
-		pr_err("unaligned: iova 0x%lx size 0x%zx min_pagesz 0x%x\n",
+		pr_err("unaligned: iova 0x%lx size 0x%zx min_pagesz 0x%zx\n",

         iova, size, pgsize);
  return;
  }

drivers/gpu/drm/etnaviv/etnaviv_mmu.c +0 -0
@@ -54,7 +54,7 @@ static int etnaviv_domain_map(struct etnaviv_iommu_domain *domain,
 >  	int ret = 0;

Quoted 6 lines
Quoted 6 lines

  if (!IS_ALIGNED(iova | paddr | size, pgsize)) {

drivers/gpu/drm/etnaviv/etnaviv_mmu.c +1 -1
-		pr_err("unaligned: iova 0x%lx pa %pa size 0x%zx min_pagesz 0x%x\n",
+		pr_err("unaligned: iova 0x%lx pa %pa size 0x%zx min_pagesz 0x%zx\n",

         iova, &paddr, size, pgsize); return -EINVAL;
  }

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#2 lore raw

Hello Lucas,

Quoting Lucas Stach <[email protected]>:

Quoted 6 lines

Hi Gustavo,

Am Dienstag, den 23.01.2018, 11:07 -0600 schrieb Gustavo A. R. Silva:

Quoted 3 lines

Fix the following warning by using %zx instead of %x for variable of type size_t:

Quoted 8 lines
Quoted 5 lines

warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 4 has type ‘size_t {aka long unsigned int}’ [-Wformat=]

Fixes 50073cf98d16 ("drm/etnaviv: mmu: stop using iommu map/unmap functions")

Thanks for the patch, but I already have an equivalent change queued up.

That's great. I'm glad it is already fixed.

Thanks
--
Gustavo