drm/i915/cnl: Fix aux selection for WA 1178
Subsystems (2)
Rodrigo Vivi
maintainerPATCH 1/1 drm/i915/cnl: Fix aux selection for WA 1178
Current code always select _CNL_AUX_ANAOVRD1_B
register regardless the pw in use.
CNL_DISP_PW_AUX_B = 9CNL_DISP_PW_AUX_C = 10CNL_DISP_PW_AUX_D = 11
And for pick we want
B = 0
C = 1
D = 2
--- drivers/gpu/drm/i915/i915_reg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_reg.h +1 -1
@@ -8422,7 +8422,7 @@ enum skl_power_gate {#define SKL_PW_TO_PG (pw) ((pw) - SKL_DISP_PW_1 + SKL_PG1)#define SKL_FUSE_PG_DIST_STATUS (pg) (1 << (27 - (pg))) -#define _CNL_AUX_REG_IDX (pw) ((pw - 1) >> 4) +#define _CNL_AUX_REG_IDX (pw) ((pw) - 9)#define _CNL_AUX_ANAOVRD1_B 0x162250#define _CNL_AUX_ANAOVRD1_C 0x162210#define _CNL_AUX_ANAOVRD1_D 0x1622D0
Signature · 6 lines
2.13.6 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915/cnl: Fix aux selection for WA 1178
== Series Details ==
== Series Details ==
Series: drm/i915/cnl: Fix aux selection for WA 1178
URL : https://patchwork.freedesktop.org/series/36997/
State : success
== Summary ==
Series 36997v1 drm/i915/cnl: Fix aux selection for WA 1178
https://patchwork.freedesktop.org/api/1.0/series/36997/revisions/1/mbox/
Test debugfs_test:
Subgroup read_all_entries:
dmesg-fail -> DMESG-WARN (fi-elk-e7500) fdo#103989
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-a:
pass -> INCOMPLETE (fi-hsw-4770) fdo#103375
Subgroup suspend-read-crc-pipe-b:
pass -> INCOMPLETE (fi-snb-2520m) fdo#103713fdo#103989 https://bugs.freedesktop.org/show_bug.cgi?id=103989
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fi-bdw-5557u total:288 pass:267 dwarn:0 dfail:0 fail:0 skip:21 time:422s fi-bdw-gvtdvm total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:428s fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:379s fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:487s fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:281s fi-bxt-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:484s fi-bxt-j4205 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:492s fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:466s fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:456s fi-elk-e7500 total:224 pass:168 dwarn:10 dfail:0 fail:0 skip:45 fi-gdg-551 total:288 pass:179 dwarn:0 dfail:0 fail:1 skip:108 time:276s fi-glk-1 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:512s fi-hsw-4770 total:244 pass:220 dwarn:0 dfail:0 fail:0 skip:23 fi-hsw-4770r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:400s fi-ilk-650 total:288 pass:228 dwarn:0 dfail:0 fail:0 skip:60 time:415s fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:450s fi-ivb-3770 total:288 pass:255 dwarn:0 dfail:0 fail:0 skip:33 time:414s fi-kbl-7500u total:288 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:460s fi-kbl-7560u total:288 pass:269 dwarn:0 dfail:0 fail:0 skip:19 time:496s fi-kbl-7567u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:449s fi-kbl-r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:499s fi-pnv-d510 total:288 pass:222 dwarn:1 dfail:0 fail:0 skip:65 time:582s fi-skl-6260u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:426s fi-skl-6600u total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:512s fi-skl-6700hq total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:529s fi-skl-6700k2 total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:489s fi-skl-6770hq total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:479s fi-skl-guc total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:416s fi-snb-2520m total:245 pass:211 dwarn:0 dfail:0 fail:0 skip:33 fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:400s Blacklisted hosts: fi-cfl-s2 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:561s fi-glk-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:471s
5e022f5f329c7909cb9aa938364072329f694fb2 drm-tip: 2018y-01m-23d-17h-29m-20s UTC integration manifest 1d4d6da9c90e drm/i915/cnl: Fix aux selection for WA 1178
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7760/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 25 lines · Rodrigo Vivi
Current code always select
_CNL_AUX_ANAOVRD1_B
register regardless the pw in use.
CNL_DISP_PW_AUX_B= 9CNL_DISP_PW_AUX_C= 10CNL_DISP_PW_AUX_D= 11And for pick we want
B = 0
C = 1
D = 2Fixes ddd39e4b3f8f ("drm/i915/cnl: apply Display WA #1178 to fix type C dongles")Cc Lucas De Marchi <[email protected]>Signed-off-by Rodrigo Vivi <[email protected]>--- drivers/gpu/drm/i915/i915_reg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/i915_reg.h +0
-0
drivers/gpu/drm/i915/i915_reg.h enum skl_power_gate { · line 8425
Quoted 5 lines
drivers/gpu/drm/i915/i915_reg.h +1
-1@@ -8422,7 +8422,7 @@ enum skl_power_gate {#define SKL_PW_TO_PG (pw) ((pw) - SKL_DISP_PW_1 + SKL_PG1)#define SKL_FUSE_PG_DIST_STATUS (pg) (1 << (27 - (pg))) -#define _CNL_AUX_REG_IDX (pw) ((pw - 1) >> 4) +#define _CNL_AUX_REG_IDX (pw) ((pw) - 9)
Ugh, I guess I based this on the _HSW_PW_REG_IDX() macro and made a complete mess out of it, sorry.
Lucas De Marchi
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Rodrigo Vivi
maintainerQuoted 29 lines · Lucas De Marchi
Quoted 28 lines · Rodrigo Vivi
Current code always select
_CNL_AUX_ANAOVRD1_B
register regardless the pw in use.
CNL_DISP_PW_AUX_B= 9CNL_DISP_PW_AUX_C= 10CNL_DISP_PW_AUX_D= 11And for pick we want
B = 0
C = 1
D = 2Fixes ddd39e4b3f8f ("drm/i915/cnl: apply Display WA #1178 to fix type C dongles")Cc Lucas De Marchi <[email protected]>Signed-off-by Rodrigo Vivi <[email protected]>--- drivers/gpu/drm/i915/i915_reg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/i915_reg.h +0
-0@@ -8422,7 +8422,7 @@ enum skl_power_gate {#define SKL_PW_TO_PG (pw) ((pw) - SKL_DISP_PW_1 + SKL_PG1)#define SKL_FUSE_PG_DIST_STATUS (pg) (1 << (27 - (pg)))
Quoted 5 lines
drivers/gpu/drm/i915/i915_reg.h enum skl_power_gate { · line 8425
Quoted 2 lines
drivers/gpu/drm/i915/i915_reg.h +1
-1-#define _CNL_AUX_REG_IDX (pw) ((pw - 1) >> 4) +#define _CNL_AUX_REG_IDX (pw) ((pw) - 9)Ugh, I guess I based this on the
_HSW_PW_REG_IDX()macro and made a complete mess out of it, sorry.
whatever you did back there I fully agreed, so my bad as well
Quoted 2 lines
Acked-by Lucas De Marchi <[email protected]>
merged. thanks.
Quoted 3 lines
Lucas De Marchi
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.IGT: warning for drm/i915/cnl: Fix aux selection for WA 1178
In reply to Rodrigo Vivi== Series Details ==
== Series Details ==
Series: drm/i915/cnl: Fix aux selection for WA 1178
URL : https://patchwork.freedesktop.org/series/36997/
State : warning
== Summary ==
Test kms_flip:
Subgroup flip-vs-expired-vblank-interruptible:
fail -> PASS (shard-hsw) fdo#102887
Subgroup vblank-vs-dpms-suspend-interruptible:
pass -> SKIP (shard-snb)
Subgroup flip-vs-blocking-wf-vblank:
pass -> FAIL (shard-hsw) fdo#100368
Subgroup 2x-plain-flip-fb-recreate:
fail -> PASS (shard-hsw)
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-offscren-pri-indfb-draw-mmap-gtt:
pass -> FAIL (shard-apl) fdo#101623 +1
Test perf:
Subgroup buffer-fill:
pass -> FAIL (shard-apl) fdo#103755
Test drv_suspend:
Subgroup fence-restore-untiled:
skip -> PASS (shard-snb) fdo#102365fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#103755 https://bugs.freedesktop.org/show_bug.cgi?id=103755
fdo#102365 https://bugs.freedesktop.org/show_bug.cgi?id=102365
shard-apl total:2753 pass:1714 dwarn:1 dfail:0 fail:24 skip:1013 time:13971s shard-hsw total:2753 pass:1725 dwarn:1 dfail:0 fail:11 skip:1015 time:15388s shard-snb total:2753 pass:1317 dwarn:1 dfail:0 fail:11 skip:1424 time:7829s
Blacklisted hosts:
shard-kbl total:2753 pass:1839 dwarn:3 dfail:0 fail:24 skip:887 time:11031s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7760/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx