Skip to contentSkip to conversation

sound: omap-twl4030: do not complain on -EPROBE_DEFER when initializing

PATCH RESEND Superseded Ladislav Michl 2 participants 2 messages Jan 24, 2018 – Feb 11, 2018

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 sound: omap-twl4030: do not complain on -EPROBE_DEFER when initializing

Don't complain on -EPROBE_DEFER when when initializing, the driver probe will be retried later.

---
Note: Just a resend of patch from 9 Nov 2016 as there were no
reply by then.

 sound/soc/omap/omap-twl4030.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
sound/soc/omap/omap-twl4030.c +4 -2
index cccc316743fa..7c1f71884768 100644
@@ -322,8 +322,10 @@ static int omap_twl4030_probe(struct platform_device *pdev)
 	snd_soc_card_set_drvdata(card, priv);
 	ret = devm_snd_soc_register_card(&pdev->dev, card);
 	if (ret) {
-		dev_err(&pdev->dev, "devm_snd_soc_register_card() failed: %d\n",
-			ret);
+		if (ret != -EPROBE_DEFER)
+			dev_err(&pdev->dev,
+				"devm_snd_soc_register_card() failed: %d\n",
+				ret);
 		return ret;
 	}
 
Signature · 1 line
2.15.1
Acked-by on v1 1/1
#1 lore raw

Hi

Quoted 17 lines · Ladislav Michl

Don't complain on -EPROBE_DEFER when when initializing, the driver probe will be retried later.

---
Note: Just a resend of patch from 9 Nov 2016 as there were no
reply by then.

 sound/soc/omap/omap-twl4030.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
sound/soc/omap/omap-twl4030.c +0 -0
index cccc316743fa..7c1f71884768 100644
@@ -322,8 +322,10 @@ static int omap_twl4030_probe(struct platform_device *pdev)
 	snd_soc_card_set_drvdata(card, priv);

sound/soc/omap/omap-twl4030.c static int omap_twl4030_probe(struct platform_device *pdev) · line 330

Quoted 10 lines
sound/soc/omap/omap-twl4030.c +4 -2
 	ret = devm_snd_soc_register_card(&pdev->dev, card);
 	if (ret) {
-		dev_err(&pdev->dev, "devm_snd_soc_register_card() failed: %d\n",
-			ret);
+		if (ret != -EPROBE_DEFER)
+			dev_err(&pdev->dev,
+				"devm_snd_soc_register_card() failed: %d\n",
+				ret);
 		return ret;
 	}

Sorry the delay. Please Cc Mark Brown <[email protected]> and repost. You may add my