Skip to contentSkip to conversation

ARM: dts: use a correct at24 fallback for at91-nattis-2-natte-2

PATCH In review Bartosz Golaszewski 2 participants 3 messages Jan 24, 2018 – Jan 25, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: use a correct at24 fallback for at91-nattis-2-natte-2

We now require all at24 users to use the "atmel,<model>" fallback in device tree for different manufacturers.

---
 arch/arm/boot/dts/at91-nattis-2-natte-2.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/at91-nattis-2-natte-2.dts +1 -1
index 3ea1d26e1c68..9ae2a9de6123 100644
@@ -146,7 +146,7 @@
 	};
 
 	eeprom at 50 {
-		compatible = "nxp,24c02";
+		compatible = "nxp,24c02", "atmel,24c02";
 		reg = <0x50>;
 		pagesize = <16>;
 	};
Signature · 1 line
2.16.1
#1 lore raw

Hi Bartosz,

Quoted 2 lines · Bartosz Golaszewski

We now require all at24 users to use the "atmel,<model>" fallback in device tree for different manufacturers.

I think my patch [3/4] from about a week ago was just a tiny bit better.
https://lkml.org/lkml/2018/1/16/609

Can we please pick that one directly instead of doing this partial step?

Cheers,
Peter

Quoted 19 lines
---
 arch/arm/boot/dts/at91-nattis-2-natte-2.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/at91-nattis-2-natte-2.dts +1 -1
index 3ea1d26e1c68..9ae2a9de6123 100644
@@ -146,7 +146,7 @@
 	};
 
 	eeprom at 50 {
-		compatible = "nxp,24c02";
+		compatible = "nxp,24c02", "atmel,24c02";
 		reg = <0x50>;
 		pagesize = <16>;
 	};
#2 lore raw

2018-01-24 23:12 GMT+01:00 Peter Rosin <[email protected]>:

Quoted 10 lines

Hi Bartosz,

Quoted 2 lines · Bartosz Golaszewski

We now require all at24 users to use the "atmel,<model>" fallback in device tree for different manufacturers.

I think my patch [3/4] from about a week ago was just a tiny bit better.
https://lkml.org/lkml/2018/1/16/609

Quoted 5 lines

Can we please pick that one directly instead of doing this partial step?

Cheers,
Peter

Hi Peter,

oh yes, sorry - I just grepped the entire code base from next for invalid compatibles and didn't notice this was already fixed by you. Let's drop it.

Thanks,
Bartosz