drm/mgag200: fix a test in mga_vga_mode_valid()
PATCH 1/1 drm/mgag200: fix a test in mga_vga_mode_valid()
The parentheses are in the wrong place here so we pass the bits per pixel as zero.
Fixes abbee6238775 ("drm/mgag200: Added resolution and bandwidth limits for various G200e products.")
Signed-off-by Dan Carpenter <[email protected]>
---
Static analysis. Not tested.
drivers/gpu/drm/mgag200/mgag200_mode.c +2 -2
@@ -1620,8 +1620,8 @@ static int mga_vga_mode_valid(struct drm_connector *connector,return MODE_VIRTUAL_X ;if (mode->vdisplay >1024 )return MODE_VIRTUAL_Y ; -if (mga_vga_calculate_mode_bandwidth (mode, - bpp > (31877 *1024 ))) +if (mga_vga_calculate_mode_bandwidth (mode, bpp) > + (31877 *1024 ))return MODE_BANDWIDTH ; } else if (mdev->type == G200_EV && (mga_vga_calculate_mode_bandwidth(mode, bpp)
Quoted 7 lines · Dan Carpenter
The parentheses are in the wrong place here so we pass the bits per pixel as zero.
Fixes abbee6238775 ("drm/mgag200: Added resolution and bandwidth limits for various G200e products.")Signed-off-by Dan Carpenter <[email protected]>---
Static analysis. Not tested.
Looks reasonable. Thanks for the patch, applied.
-Daniel
Quoted 16 lines
drivers/gpu/drm/mgag200/mgag200_mode.c +2
-2@@ -1620,8 +1620,8 @@ static int mga_vga_mode_valid(struct drm_connector *connector,return MODE_VIRTUAL_X ;if (mode->vdisplay >1024 )return MODE_VIRTUAL_Y ; -if (mga_vga_calculate_mode_bandwidth (mode, - bpp > (31877 *1024 ))) +if (mga_vga_calculate_mode_bandwidth (mode, bpp) > + (31877 *1024 ))return MODE_BANDWIDTH ; } else if (mdev->type == G200_EV && (mga_vga_calculate_mode_bandwidth(mode, bpp)
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch