Skip to contentSkip to conversation

nvme-rdma: remove redundant boolean for inline_data

PATCH New Max Gurtovoy 4 participants 5 messages Dec 6, 2017 – Jan 25, 2018 NVMe

lore
Share & tools
lore

Max Gurtovoy

author
#0 lore raw

PATCH 1/1 nvme-rdma: remove redundant boolean for inline_data

Signed-off-by Max Gurtovoy <maxg at mellanox.com>
---
 drivers/nvme/host/rdma.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/nvme/host/rdma.c +0 -3
index 37af565..225f7f1 100644
@@ -66,7 +66,6 @@ struct nvme_rdma_request {
 	struct ib_sge		sge[1 + NVME_RDMA_MAX_INLINE_SEGMENTS];
 	u32			num_sge;
 	int			nents;
-	bool			inline_data;
 	struct ib_reg_wr	reg_wr;
 	struct ib_cqe		reg_cqe;
 	struct nvme_rdma_queue  *queue;

@@ -1086,7 +1085,6 @@ static int nvme_rdma_map_sg_inline(struct nvme_rdma_queue *queue,
 	sg->length = cpu_to_le32(sg_dma_len(req->sg_table.sgl));
 	sg->type = (NVME_SGL_FMT_DATA_DESC << 4) | NVME_SGL_FMT_OFFSET;
 
-	req->inline_data = true;
 	req->num_sge++;
 	return 0;
 }

@@ -1158,7 +1156,6 @@ static int nvme_rdma_map_data(struct nvme_rdma_queue *queue,
 	int count, ret;
 
 	req->num_sge = 1;
-	req->inline_data = false;
 	refcount_set(&req->ref, 2); /* send and recv completions */
 
 	c->common.flags |= NVME_CMD_SGL_METABUF;
Signature · 1 line
1.8.3.1
maintainer
#1 lore raw

PATCH 1/1 nvme-rdma: remove redundant boolean for inline_data

Reviewed-by Sagi Grimberg <sagi at grimberg.me>
author
#2 lore raw

PATCH 1/1 nvme-rdma: remove redundant boolean for inline_data

In reply to Max Gurtovoy

ping :)

Quoted 34 lines · Max Gurtovoy
Signed-off-by Max Gurtovoy <maxg at mellanox.com>
---
  drivers/nvme/host/rdma.c | 3 ---
  1 file changed, 3 deletions(-)
drivers/nvme/host/rdma.c +0 -3
index 37af565..225f7f1 100644
@@ -66,7 +66,6 @@ struct nvme_rdma_request {
  	struct ib_sge		sge[1 + NVME_RDMA_MAX_INLINE_SEGMENTS];
  	u32			num_sge;
  	int			nents;
-	bool			inline_data;
  	struct ib_reg_wr	reg_wr;
  	struct ib_cqe		reg_cqe;
  	struct nvme_rdma_queue  *queue;

@@ -1086,7 +1085,6 @@ static int nvme_rdma_map_sg_inline(struct nvme_rdma_queue *queue,
  	sg->length = cpu_to_le32(sg_dma_len(req->sg_table.sgl));
  	sg->type = (NVME_SGL_FMT_DATA_DESC << 4) | NVME_SGL_FMT_OFFSET;
 
-	req->inline_data = true;
  	req->num_sge++;
  	return 0;
  }

@@ -1158,7 +1156,6 @@ static int nvme_rdma_map_data(struct nvme_rdma_queue *queue,
  	int count, ret;
 
  	req->num_sge = 1;
-	req->inline_data = false;
  	refcount_set(&req->ref, 2); /* send and recv completions */
 
  	c->common.flags |= NVME_CMD_SGL_METABUF;
#3 lore raw

PATCH 1/1 nvme-rdma: remove redundant boolean for inline_data

In reply to Max Gurtovoy
Reviewed-by Johannes Thumshirn <jthumshirn at suse.de>
Signature · 6 lines
Johannes Thumshirn                                          Storage
jthumshirn at suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850