Skip to contentSkip to conversation

spl: add option to disable SPL banner output

PATCH Superseded Lukasz Majewski 2 participants 3 messages Jan 25, 2018

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Lukasz Majewski

author
#0 lore raw

PATCH 1/1 spl: add option to disable SPL banner output

From: Anatolij Gustschin <[email protected]>

Selecting this option will reduce SPL boot time by approx. 6 ms (e. g. with 70 bytes long banner string at 115200 baud).

Signed-off-by Anatolij Gustschin <[email protected]>
Tested-by Lukasz Majewski <[email protected]>

---

 common/spl/Kconfig | 7 +++++++
 common/spl/spl.c   | 2 ++
 2 files changed, 9 insertions(+)
common/spl/Kconfig +7 -0
index d686b1ecbd..d1f9cae6b7 100644
@@ -118,6 +118,13 @@ config SPL_SEPARATE_BSS
 	  location is used. Normally we put the device tree at the end of BSS
 	  but with this option enabled, it goes at _image_binary_end.
 
+config SPL_DISABLE_BANNER_PRINT
+	bool "Disable output of the SPL banner 'U-Boot SPL ...'"
+	help
+	  If this option is enabled, SPL will not print the banner with version
+	  info. Selecting this option could be useful to reduce SPL boot time
+	  (e.g. approx. 6 ms slower, when output on i.MX6 with 1152000 baud).
+
 config SPL_DISPLAY_PRINT
 	bool "Display a board-specific message in SPL"
 	help
common/spl/spl.c +2 -0
index 76c1963611..898c416a66 100644
@@ -477,8 +477,10 @@ void preloader_console_init(void)
 
 	gd->have_console = 1;
 
+#ifndef CONFIG_SPL_DISABLE_BANNER_PRINT
 	puts("\nU-Boot SPL " PLAIN_VERSION " (" U_BOOT_DATE " - " \
 			U_BOOT_TIME ")\n");
+#endif
 #ifdef CONFIG_SPL_DISPLAY_PRINT
 	spl_display_print();
 #endif
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 spl: add option to disable SPL banner output

Quoted 10 lines · Lukasz Majewski

From: Anatolij Gustschin <[email protected]>

Selecting this option will reduce SPL boot time by approx. 6 ms (e. g. with 70 bytes long banner string at 115200 baud).

Signed-off-by Anatolij Gustschin <[email protected]>
Tested-by Lukasz Majewski <[email protected]>
Reviewed-by Philipp Tomsich <[email protected]>

See below for a nitpick.

Quoted 11 lines

---

common/spl/Kconfig | 7 +++++++
common/spl/spl.c | 2 ++

2 files changed, 9 insertions(+)
common/spl/Kconfig +0 -0
index d686b1ecbd..d1f9cae6b7 100644

common/spl/Kconfig config SPL_SEPARATE_BSS · line 126

Quoted 9 lines
common/spl/Kconfig +6 -0
@@ -118,6 +118,13 @@ config SPL_SEPARATE_BSS
 	  location is used. Normally we put the device tree at the end of BSS
 	  but with this option enabled, it goes at _image_binary_end.
 
+config SPL_DISABLE_BANNER_PRINT
+	bool "Disable output of the SPL banner 'U-Boot SPL ...'"
+	help
+	  If this option is enabled, SPL will not print the banner with version
+	  info. Selecting this option could be useful to reduce SPL boot time
+	  (e.g. approx. 6 ms slower, when output on i.MX6 with 1152000 baud).

You seem to be off by “times 10” for the baud-rate.

Quoted 22 lines
common/spl/Kconfig +1 -0
+

config SPL_DISPLAY_PRINT
bool "Display a board-specific message in SPL" help

common/spl/spl.c +2 -0
index 76c1963611..898c416a66 100644
@@ -477,8 +477,10 @@ void preloader_console_init(void)
 
 	gd->have_console = 1;
 
+#ifndef CONFIG_SPL_DISABLE_BANNER_PRINT
 	puts("\nU-Boot SPL " PLAIN_VERSION " (" U_BOOT_DATE " - " \
 			U_BOOT_TIME ")\n");
+#endif
 #ifdef CONFIG_SPL_DISPLAY_PRINT
 	spl_display_print();
 #endif
Signature · 1 line
2.11.0
author
#2 lore raw

PATCH 1/1 spl: add option to disable SPL banner output

Hi Philipp,

Quoted 29 lines
Quoted 9 lines · Lukasz Majewski

From: Anatolij Gustschin <[email protected]>

Selecting this option will reduce SPL boot time by approx. 6 ms (e. g. with 70 bytes long banner string at 115200 baud).

Signed-off-by Anatolij Gustschin <[email protected]>
Tested-by Lukasz Majewski <[email protected]>
Reviewed-by Philipp Tomsich <[email protected]>

See below for a nitpick.

Quoted 15 lines

---

common/spl/Kconfig | 7 +++++++
common/spl/spl.c | 2 ++

2 files changed, 9 insertions(+)
common/spl/Kconfig +0 -0
index d686b1ecbd..d1f9cae6b7 100644
@@ -118,6 +118,13 @@ config SPL_SEPARATE_BSS
 	  location is used. Normally we put the device tree at the

end of BSS but with this option enabled, it goes at _image_binary_end.

Quoted 11 lines
Quoted 9 lines
common/spl/Kconfig +4 -0
+config SPL_DISABLE_BANNER_PRINT
+	bool "Disable output of the SPL banner 'U-Boot SPL ...'"
+	help
+	  If this option is enabled, SPL will not print the banner

with version

common/spl/Kconfig +1 -0
+	  info. Selecting this option could be useful to reduce

SPL boot time

common/spl/Kconfig +1 -0
+	  (e.g. approx. 6 ms slower, when output on i.MX6 with

1152000 baud).

You seem to be off by “times 10” for the baud-rate.

Extra boost :-)

Fixed in v2. Thanks for spotting.

Quoted 13 lines
Quoted 13 lines

+
config SPL_DISPLAY_PRINT
bool "Display a board-specific message in SPL" help

common/spl/spl.c +0 -0
index 76c1963611..898c416a66 100644
@@ -477,8 +477,10 @@ void preloader_console_init(void)
 
 	gd->have_console = 1;
Quoted 11 lines
Quoted 10 lines
common/spl/spl.c +2 -0
+#ifndef CONFIG_SPL_DISABLE_BANNER_PRINT
 	puts("\nU-Boot SPL " PLAIN_VERSION " (" U_BOOT_DATE " - " \
 			U_BOOT_TIME ")\n");
+#endif
 #ifdef CONFIG_SPL_DISPLAY_PRINT
 	spl_display_print();
 #endif
Signature · 1 line
2.11.0

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180125/c518319f/attachment.sig>