ssb: Do not disable PCI host on non-Mips

After upgrading an old laptop to 4.15-rc9, I found that the eth0 and wlan0 interfaces had disappeared. It turns out that the b43 and b44 drivers require SSB_PCIHOST_POSSIBLE which depends on PCI_DRIVERS_LEGACY, a config option that only exists on Mips.

Fixes 58eae1416b80 ("ssb: Disable PCI host for PCI_DRIVERS_GENERIC")

Cc [email protected]

Signed-off-by Sven Joachim <[email protected]>

---
 drivers/ssb/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/ssb/Kconfig +1 -1

index 71c73766ee22..65af12c3bdb2 100644
@@ -32,7 +32,7 @@ config SSB_BLOCKIO
 
 config SSB_PCIHOST_POSSIBLE
 	bool
-	depends on SSB && (PCI = y || PCI = SSB) && PCI_DRIVERS_LEGACY
+	depends on SSB && (PCI = y || PCI = SSB) && (PCI_DRIVERS_LEGACY || !MIPS)
 	default y
 
 config SSB_PCIHOST

Signature · 1 line

2.15.1

Quoted 8 lines · Sven Joachim

After upgrading an old laptop to 4.15-rc9, I found that the eth0 and wlan0 interfaces had disappeared. It turns out that the b43 and b44 drivers require SSB_PCIHOST_POSSIBLE which depends on PCI_DRIVERS_LEGACY, a config option that only exists on Mips.

Fixes 58eae1416b80 ("ssb: Disable PCI host for PCI_DRIVERS_GENERIC")

Cc [email protected]

Signed-off-by Sven Joachim <[email protected]>

Whoops, thats a very good point. I hadn't twigged that PCI_DRIVERS_LEGACY was MIPS specific (one of the disadvantages of using "tig grep" I suppose!).

Reviewed-by James Hogan <[email protected]>

I think this is obviously correct, so it'd be great to squeeze it into 4.15 final.

Quoted 14 lines · James Hogan

Quoted 8 lines · Sven Joachim

After upgrading an old laptop to 4.15-rc9, I found that the eth0 and wlan0 interfaces had disappeared. It turns out that the b43 and b44 drivers require SSB_PCIHOST_POSSIBLE which depends on PCI_DRIVERS_LEGACY, a config option that only exists on Mips.

Fixes 58eae1416b80 ("ssb: Disable PCI host for PCI_DRIVERS_GENERIC")

Cc [email protected]

Signed-off-by Sven Joachim <[email protected]>

Whoops, thats a very good point. I hadn't twigged that PCI_DRIVERS_LEGACY was MIPS specific (one of the disadvantages of using "tig grep" I suppose!).

Quoted 4 lines

Reviewed-by James Hogan <[email protected]>

I think this is obviously correct, so it'd be great to squeeze it into 4.15 final.

I'm not sure if I'm able to get it to 4.15 as it has go via the net tree, and we have only two days before the (likely) final release, but I'll try.

Quoted 21 lines · Kalle Valo

Quoted 18 lines · James Hogan

Quoted 8 lines · Sven Joachim

After upgrading an old laptop to 4.15-rc9, I found that the eth0 and wlan0 interfaces had disappeared. It turns out that the b43 and b44 drivers require SSB_PCIHOST_POSSIBLE which depends on PCI_DRIVERS_LEGACY, a config option that only exists on Mips.

Fixes 58eae1416b80 ("ssb: Disable PCI host for PCI_DRIVERS_GENERIC")

Cc [email protected]

Signed-off-by Sven Joachim <[email protected]>

Whoops, thats a very good point. I hadn't twigged that PCI_DRIVERS_LEGACY was MIPS specific (one of the disadvantages of using "tig grep" I suppose!).

Reviewed-by James Hogan <[email protected]>

I think this is obviously correct, so it'd be great to squeeze it into 4.15 final.

Quoted 3 lines

I'm not sure if I'm able to get it to 4.15 as it has go via the net tree, and we have only two days before the (likely) final release, but I'll try.

Too late, Dave already sent his last pull request for 4.15. This will be in 4.16.

After upgrading an old laptop to 4.15-rc9, I found that the eth0 and wlan0 interfaces had disappeared. It turns out that the b43 and b44 drivers require SSB_PCIHOST_POSSIBLE which depends on PCI_DRIVERS_LEGACY, a config option that only exists on Mips.

Fixes 58eae1416b80 ("ssb: Disable PCI host for PCI_DRIVERS_GENERIC")

Cc [email protected]

Signed-off-by Sven Joachim <[email protected]>

Reviewed-by James Hogan <[email protected]>

After upgrading an old laptop to 4.15-rc9, I found that the eth0 and wlan0 interfaces had disappeared. It turns out that the b43 and b44 drivers require SSB_PCIHOST_POSSIBLE which depends on PCI_DRIVERS_LEGACY, a config option that only exists on Mips.

Fixes 58eae1416b80 ("ssb: Disable PCI host for PCI_DRIVERS_GENERIC")

Cc [email protected]

Signed-off-by Sven Joachim <[email protected]>

Reviewed-by James Hogan <[email protected]>