Skip to contentSkip to conversation

net/rocker: Remove unreachable return instruction

PATCH Applied Leon Romanovsky 2 participants 2 messages Jan 28, 2018

Subsystems (3)
Networking Network drivers Rocker driver
lore
Share & tools
lore

Leon Romanovsky

author
#0 lore raw

PATCH 1/1 net/rocker: Remove unreachable return instruction

From: Leon Romanovsky <[email protected]>

The "return 0" instruction follows other return instruction and it makes it impossible to execute, hence remove it.

Fixes 00fc0c51e35b ("rocker: Change world_ops API and implementation to be switchdev independant")
Signed-off-by Leon Romanovsky <[email protected]>
---
 drivers/net/ethernet/rocker/rocker_ofdpa.c | 1 -
 1 file changed, 1 deletion(-)
drivers/net/ethernet/rocker/rocker_ofdpa.c +0 -1
index 6d6fb8cf3e7c..6473cc68c2d5 100644
@@ -789,7 +789,6 @@ static int ofdpa_flow_tbl_add(struct ofdpa_port *ofdpa_port,
 			       ofdpa_flags_nowait(flags),
 			       ofdpa_cmd_flow_tbl_add,
 			       found, NULL, NULL);
-	return 0;
 }
 
 static int ofdpa_flow_tbl_del(struct ofdpa_port *ofdpa_port,
maintainer Applied
#1 lore raw

From: Leon Romanovsky <[email protected]>
Date: Sun, 28 Jan 2018 15:54:38 +0200

Quoted 7 lines

From: Leon Romanovsky <[email protected]>

The "return 0" instruction follows other return instruction and it makes it impossible to execute, hence remove it.

Fixes 00fc0c51e35b ("rocker: Change world_ops API and implementation to be switchdev independant")
Signed-off-by Leon Romanovsky <[email protected]>

Applied, thanks.